doc/cross_build: update the list supported Arm SoCs

Message ID 20210429075416.9864-1-thierry.herbelot@6wind.com (mailing list archive)
State Rejected, archived
Delegated to: David Marchand
Headers
Series doc/cross_build: update the list supported Arm SoCs |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Thierry Herbelot April 29, 2021, 7:54 a.m. UTC
  Align the list of supported targets with config/arm/meson.build

Fixes: f2340c858046 ("config/arm: add platform config option")

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
 doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 5 +++++
 1 file changed, 5 insertions(+)
  

Comments

Juraj Linkeš April 29, 2021, 9:12 a.m. UTC | #1
> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Thursday, April 29, 2021 9:54 AM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; Thomas Monjalon
> <thomas@monjalon.net>; Juraj Linkeš <juraj.linkes@pantheon.tech>; Honnappa
> Nagarahalli <honnappa.nagarahalli@arm.com>; Ruifeng Wang
> <ruifeng.wang@arm.com>
> Subject: [PATCH] doc/cross_build: update the list supported Arm SoCs
> 
> Align the list of supported targets with config/arm/meson.build
> 
> Fixes: f2340c858046 ("config/arm: add platform config option")
> 

I believe this also fixes the patches that introduced the kunpeng and cn10k soc. f2340c858046 was merged first (with n2 missing in the docs), then 7cf32a22b240 and 1b4c86a721c9 added the kunpeng and cn10k configs without adding to the docs.

With that said,
Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>

> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
>  doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> index 3857cdefe9fb..5513948c9037 100644
> --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
> @@ -202,11 +202,16 @@ Substitute <target_soc> with one of the supported
> SoCs::
>     generic:     Generic un-optimized build for all aarch64 machines.
>     armada:      Marvell ARMADA
>     bluefield:   NVIDIA BlueField
> +   cn10k:       Marvell OCTEON 10
>     dpaa:        NXP DPAA
>     emag:        Ampere eMAG
>     graviton2:   AWS Graviton2
> +   kunpeng920:  HiSilicon Kunpeng 920
> +   kunpeng930:  HiSilicon Kunpeng 930
>     n1sdp:       Arm Neoverse N1SDP
> +   n2:          Arm Neoverse N2
>     octeontx2:   Marvell OCTEON TX2
> +   qualcomm:    Qualcomm Centriq 2400
>     stingray:    Broadcom Stingray
>     thunderx2:   Marvell ThunderX2 T99
>     thunderxt88: Marvell ThunderX T88
> --
> 2.29.2
>
  
David Marchand April 29, 2021, 9:17 a.m. UTC | #2
On Thu, Apr 29, 2021 at 11:12 AM Juraj Linkeš
<juraj.linkes@pantheon.tech> wrote:
> > -----Original Message-----
> > From: Thierry Herbelot <thierry.herbelot@6wind.com>
> > Sent: Thursday, April 29, 2021 9:54 AM
> > To: dev@dpdk.org
> > Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; Thomas Monjalon
> > <thomas@monjalon.net>; Juraj Linkeš <juraj.linkes@pantheon.tech>; Honnappa
> > Nagarahalli <honnappa.nagarahalli@arm.com>; Ruifeng Wang
> > <ruifeng.wang@arm.com>
> > Subject: [PATCH] doc/cross_build: update the list supported Arm SoCs
> >
> > Align the list of supported targets with config/arm/meson.build
> >
> > Fixes: f2340c858046 ("config/arm: add platform config option")
> >
>
> I believe this also fixes the patches that introduced the kunpeng and cn10k soc. f2340c858046 was merged first (with n2 missing in the docs), then 7cf32a22b240 and 1b4c86a721c9 added the kunpeng and cn10k configs without adding to the docs.
>
> With that said,
> Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>

This patch is wrong.

It fixes the qualcomm doc part while it should go in:
http://patchwork.dpdk.org/project/dpdk/patch/20210429080644.11423-1-thierry.herbelot@6wind.com/
It fixes kunpeng and cn10k, so the fixes line is wrong.

Please drop it, I already submitted a different fix for the latter.
  

Patch

diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
index 3857cdefe9fb..5513948c9037 100644
--- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
+++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst
@@ -202,11 +202,16 @@  Substitute <target_soc> with one of the supported SoCs::
    generic:     Generic un-optimized build for all aarch64 machines.
    armada:      Marvell ARMADA
    bluefield:   NVIDIA BlueField
+   cn10k:       Marvell OCTEON 10
    dpaa:        NXP DPAA
    emag:        Ampere eMAG
    graviton2:   AWS Graviton2
+   kunpeng920:  HiSilicon Kunpeng 920
+   kunpeng930:  HiSilicon Kunpeng 930
    n1sdp:       Arm Neoverse N1SDP
+   n2:          Arm Neoverse N2
    octeontx2:   Marvell OCTEON TX2
+   qualcomm:    Qualcomm Centriq 2400
    stingray:    Broadcom Stingray
    thunderx2:   Marvell ThunderX2 T99
    thunderxt88: Marvell ThunderX T88