diff mbox series

[2/5] app/testpmd: remove indirect RSS action query

Message ID 20210426124250.42771-3-michaelba@nvidia.com (mailing list archive)
State Superseded, archived
Delegated to: Raslan Darawsheh
Headers show
Series net/mlx5: add indirect count action | expand

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Michael Baum April 26, 2021, 12:42 p.m. UTC
The port_action_handle_query function supports query operation for
indirect RSS action.

No driver currently supports this operation, and this support is
unnecessary.

Remove it.

Signed-off-by: Michael Baum <michaelba@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 app/test-pmd/config.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

Ori Kam April 29, 2021, 1:46 p.m. UTC | #1
Hi Michael,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Michael Baum
> Sent: Monday, April 26, 2021 3:43 PM
> Subject: [dpdk-dev] [PATCH 2/5] app/testpmd: remove indirect RSS action
> query
> 
> The port_action_handle_query function supports query operation for
> indirect RSS action.
> 
> No driver currently supports this operation, and this support is unnecessary.
> 
> Remove it.
> 
> Signed-off-by: Michael Baum <michaelba@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  app/test-pmd/config.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> e189062..a9805cc 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1626,7 +1626,6 @@ struct rte_flow_action_handle *
>  	if (!pia)
>  		return -EINVAL;
>  	switch (pia->type) {
> -	case RTE_FLOW_ACTION_TYPE_RSS:
>  	case RTE_FLOW_ACTION_TYPE_AGE:
>  		data = &default_data;
>  		break;
> @@ -1638,12 +1637,6 @@ struct rte_flow_action_handle *
>  	if (rte_flow_action_handle_query(port_id, pia->handle, data,
> &error))
>  		ret = port_flow_complain(&error);
>  	switch (pia->type) {
> -	case RTE_FLOW_ACTION_TYPE_RSS:
> -		if (!ret)
> -			printf("Shared RSS action:\n\trefs:%u\n",
> -			       *((uint32_t *)data));
> -		data = NULL;
> -		break;
>  	case RTE_FLOW_ACTION_TYPE_AGE:
>  		if (!ret) {
>  			struct rte_flow_query_age *resp = data;
> --
> 1.8.3.1
Acked-by: Ori Kam <orika@nvidia.com>
Thanks,
Ori
diff mbox series

Patch

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index e189062..a9805cc 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1626,7 +1626,6 @@  struct rte_flow_action_handle *
 	if (!pia)
 		return -EINVAL;
 	switch (pia->type) {
-	case RTE_FLOW_ACTION_TYPE_RSS:
 	case RTE_FLOW_ACTION_TYPE_AGE:
 		data = &default_data;
 		break;
@@ -1638,12 +1637,6 @@  struct rte_flow_action_handle *
 	if (rte_flow_action_handle_query(port_id, pia->handle, data, &error))
 		ret = port_flow_complain(&error);
 	switch (pia->type) {
-	case RTE_FLOW_ACTION_TYPE_RSS:
-		if (!ret)
-			printf("Shared RSS action:\n\trefs:%u\n",
-			       *((uint32_t *)data));
-		data = NULL;
-		break;
 	case RTE_FLOW_ACTION_TYPE_AGE:
 		if (!ret) {
 			struct rte_flow_query_age *resp = data;