diff mbox series

net/bnxt: drop the unused attribute

Message ID 20210423052226.13592-1-kalesh-anakkur.purayil@broadcom.com (mailing list archive)
State Accepted
Delegated to: Ajit Khaparde
Headers show
Series net/bnxt: drop the unused attribute | expand

Checks

Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot success github build: passed
ci/checkpatch success coding style OK

Commit Message

Kalesh A P April 23, 2021, 5:22 a.m. UTC
From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

Remove "__rte_unused" instances that are wrongly marked.

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_reps.c  | 4 ++--
 drivers/net/bnxt/bnxt_stats.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Ajit Khaparde April 24, 2021, 7:23 p.m. UTC | #1
On Thu, Apr 22, 2021 at 10:00 PM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> Remove "__rte_unused" instances that are wrongly marked.
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Patch applied to dpdk-next-net-brcm.

> ---
>  drivers/net/bnxt/bnxt_reps.c  | 4 ++--
>  drivers/net/bnxt/bnxt_stats.h | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c
> index b224a7d..bdbad53 100644
> --- a/drivers/net/bnxt/bnxt_reps.c
> +++ b/drivers/net/bnxt/bnxt_reps.c
> @@ -104,7 +104,7 @@ bnxt_rep_rx_burst(void *rx_queue,
>  static uint16_t
>  bnxt_rep_tx_burst(void *tx_queue,
>                      struct rte_mbuf **tx_pkts,
> -                    __rte_unused uint16_t nb_pkts)
> +                    uint16_t nb_pkts)
>  {
>         struct bnxt_vf_rep_tx_queue *vfr_txq = tx_queue;
>         struct bnxt_tx_queue *ptxq;
> @@ -548,7 +548,7 @@ int bnxt_rep_dev_info_get_op(struct rte_eth_dev *eth_dev,
>         return 0;
>  }
>
> -int bnxt_rep_dev_configure_op(__rte_unused struct rte_eth_dev *eth_dev)
> +int bnxt_rep_dev_configure_op(struct rte_eth_dev *eth_dev)
>  {
>         struct bnxt_representor *rep_bp = eth_dev->data->dev_private;
>
> diff --git a/drivers/net/bnxt/bnxt_stats.h b/drivers/net/bnxt/bnxt_stats.h
> index 0ee2269..ee6b1be 100644
> --- a/drivers/net/bnxt/bnxt_stats.h
> +++ b/drivers/net/bnxt/bnxt_stats.h
> @@ -12,7 +12,7 @@ void bnxt_free_stats(struct bnxt *bp);
>  int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,
>                            struct rte_eth_stats *bnxt_stats);
>  int bnxt_stats_reset_op(struct rte_eth_dev *eth_dev);
> -int bnxt_dev_xstats_get_names_op(__rte_unused struct rte_eth_dev *eth_dev,
> +int bnxt_dev_xstats_get_names_op(struct rte_eth_dev *eth_dev,
>         struct rte_eth_xstat_name *xstats_names,
>         __rte_unused unsigned int limit);
>  int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,
> --
> 2.10.1
>
Ferruh Yigit April 28, 2021, 3:48 p.m. UTC | #2
On 4/23/2021 6:22 AM, Kalesh A P wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> 
> Remove "__rte_unused" instances that are wrongly marked.
> 

Can you please provide the fixes tags, so that patch can be backported to
required stable versions?

> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

<...>
Kalesh A P April 29, 2021, 4:20 a.m. UTC | #3
Hi Ferruh,

On Wed, Apr 28, 2021 at 9:18 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 4/23/2021 6:22 AM, Kalesh A P wrote:
> > From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> >
> > Remove "__rte_unused" instances that are wrongly marked.
> >
>
> Can you please provide the fixes tags, so that patch can be backported to
> required stable versions?
>
[Kalesh]: I was not sure whether it qualifies as a fix. That's why I didn't
add it in the first place.
Below is the fixes tags:

Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
Fixes: 1bf01f5135f8 ("net/bnxt: prevent device access when device is in
reset")
Cc: stable@dpdk.org

Do you want me to send a new version?

Regards,
Kalesh

>
> > Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> > Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> > Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
> <...>
>
Ferruh Yigit April 29, 2021, 11:08 a.m. UTC | #4
On 4/29/2021 5:20 AM, Kalesh Anakkur Purayil wrote:
> Hi Ferruh,
> 
> On Wed, Apr 28, 2021 at 9:18 PM Ferruh Yigit <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>> wrote:
> 
>     On 4/23/2021 6:22 AM, Kalesh A P wrote:
>     > From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com
>     <mailto:kalesh-anakkur.purayil@broadcom.com>>
>     >
>     > Remove "__rte_unused" instances that are wrongly marked.
>     >
> 
>     Can you please provide the fixes tags, so that patch can be backported to
>     required stable versions?
> 
> [Kalesh]: I was not sure whether it qualifies as a fix. That's why I didn't add
> it in the first place.
> Below is the fixes tags:
> 
> Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
> Fixes: 1bf01f5135f8 ("net/bnxt: prevent device access when device is in reset")
> Cc: stable@dpdk.org <mailto:stable@dpdk.org>
> 
> Do you want me to send a new version? 
> 

No, above is good enough, I can add them in repo. Thanks.

> Regards,
> Kalesh
> 
> 
>     > Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com
>     <mailto:kalesh-anakkur.purayil@broadcom.com>>
>     > Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com
>     <mailto:somnath.kotur@broadcom.com>>
>     > Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com
>     <mailto:ajit.khaparde@broadcom.com>>
> 
>     <...>
> 
> 
> 
> -- 
> Regards,
> Kalesh A P
Kalesh A P April 29, 2021, 11:37 a.m. UTC | #5
On Thu, Apr 29, 2021 at 4:38 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 4/29/2021 5:20 AM, Kalesh Anakkur Purayil wrote:
> > Hi Ferruh,
> >
> > On Wed, Apr 28, 2021 at 9:18 PM Ferruh Yigit <ferruh.yigit@intel.com
> > <mailto:ferruh.yigit@intel.com>> wrote:
> >
> >     On 4/23/2021 6:22 AM, Kalesh A P wrote:
> >     > From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com
> >     <mailto:kalesh-anakkur.purayil@broadcom.com>>
> >     >
> >     > Remove "__rte_unused" instances that are wrongly marked.
> >     >
> >
> >     Can you please provide the fixes tags, so that patch can be
> backported to
> >     required stable versions?
> >
> > [Kalesh]: I was not sure whether it qualifies as a fix. That's why I
> didn't add
> > it in the first place.
> > Below is the fixes tags:
> >
> > Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
> > Fixes: 1bf01f5135f8 ("net/bnxt: prevent device access when device is in
> reset")
> > Cc: stable@dpdk.org <mailto:stable@dpdk.org>
> >
> > Do you want me to send a new version?
> >
>
> No, above is good enough, I can add them in repo. Thanks.
>
[Kalesh]: Thank you Ferruh.

>
> > Regards,
> > Kalesh
> >
> >
> >     > Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com
> >     <mailto:kalesh-anakkur.purayil@broadcom.com>>
> >     > Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com
> >     <mailto:somnath.kotur@broadcom.com>>
> >     > Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com
> >     <mailto:ajit.khaparde@broadcom.com>>
> >
> >     <...>
> >
> >
> >
> > --
> > Regards,
> > Kalesh A P
>
>
diff mbox series

Patch

diff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c
index b224a7d..bdbad53 100644
--- a/drivers/net/bnxt/bnxt_reps.c
+++ b/drivers/net/bnxt/bnxt_reps.c
@@ -104,7 +104,7 @@  bnxt_rep_rx_burst(void *rx_queue,
 static uint16_t
 bnxt_rep_tx_burst(void *tx_queue,
 		     struct rte_mbuf **tx_pkts,
-		     __rte_unused uint16_t nb_pkts)
+		     uint16_t nb_pkts)
 {
 	struct bnxt_vf_rep_tx_queue *vfr_txq = tx_queue;
 	struct bnxt_tx_queue *ptxq;
@@ -548,7 +548,7 @@  int bnxt_rep_dev_info_get_op(struct rte_eth_dev *eth_dev,
 	return 0;
 }
 
-int bnxt_rep_dev_configure_op(__rte_unused struct rte_eth_dev *eth_dev)
+int bnxt_rep_dev_configure_op(struct rte_eth_dev *eth_dev)
 {
 	struct bnxt_representor *rep_bp = eth_dev->data->dev_private;
 
diff --git a/drivers/net/bnxt/bnxt_stats.h b/drivers/net/bnxt/bnxt_stats.h
index 0ee2269..ee6b1be 100644
--- a/drivers/net/bnxt/bnxt_stats.h
+++ b/drivers/net/bnxt/bnxt_stats.h
@@ -12,7 +12,7 @@  void bnxt_free_stats(struct bnxt *bp);
 int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,
 			   struct rte_eth_stats *bnxt_stats);
 int bnxt_stats_reset_op(struct rte_eth_dev *eth_dev);
-int bnxt_dev_xstats_get_names_op(__rte_unused struct rte_eth_dev *eth_dev,
+int bnxt_dev_xstats_get_names_op(struct rte_eth_dev *eth_dev,
 	struct rte_eth_xstat_name *xstats_names,
 	__rte_unused unsigned int limit);
 int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,