diff mbox series

drivers: fix indentation in build files

Message ID 20210421220358.2597249-1-thomas@monjalon.net (mailing list archive)
State Superseded
Delegated to: Thomas Monjalon
Headers show
Series drivers: fix indentation in build files | expand

Checks

Context Check Description
ci/iol-mellanox-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/github-robot success github build: passed
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Thomas Monjalon April 21, 2021, 10:03 p.m. UTC
A couple of mistakes slipped in the mass change.

More mistakes could happen, especially when rebasing pending patches,
so we need an automatic check.

Fixes: 4ad4b20a7905 ("drivers: change indentation in build files")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/crypto/qat/meson.build   | 4 ++--
 drivers/raw/skeleton/meson.build | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Bruce Richardson April 22, 2021, 8:39 a.m. UTC | #1
On Thu, Apr 22, 2021 at 12:03:57AM +0200, Thomas Monjalon wrote:
> A couple of mistakes slipped in the mass change.
> 
> More mistakes could happen, especially when rebasing pending patches, so
> we need an automatic check.
>
I have a partially-done script from when I was doing the original
reindenting work, which I'll clean up a little and send on shortly.

It only checks indent of lists and I'm extending it to check for trailing
commas, but it may serve as a basis for further checks. On the plus side,
it does automatic fixing of those issues though. Running it will probably
show up more minor misses, so I'd suggest holding off on this patch until
then.

Regards,
/Bruce
Thomas Monjalon April 22, 2021, 9:20 a.m. UTC | #2
22/04/2021 10:39, Bruce Richardson:
> On Thu, Apr 22, 2021 at 12:03:57AM +0200, Thomas Monjalon wrote:
> > A couple of mistakes slipped in the mass change.
> > 
> > More mistakes could happen, especially when rebasing pending patches, so
> > we need an automatic check.
> >
> I have a partially-done script from when I was doing the original
> reindenting work, which I'll clean up a little and send on shortly.
> 
> It only checks indent of lists and I'm extending it to check for trailing
> commas, but it may serve as a basis for further checks. On the plus side,
> it does automatic fixing of those issues though. Running it will probably
> show up more minor misses, so I'd suggest holding off on this patch until
> then.

OK, I've sent this patch just for remembering.
I am happy to leave it to you for a v2 :)
Feel free to change the author of course.

Note: I've found tabs with this simple grep:
	git grep ' ' '**/meson.build'
The tab is inserted with ^V-tab.
Bruce Richardson April 26, 2021, 10:56 a.m. UTC | #3
On Thu, Apr 22, 2021 at 11:20:19AM +0200, Thomas Monjalon wrote:
> 22/04/2021 10:39, Bruce Richardson:
> > On Thu, Apr 22, 2021 at 12:03:57AM +0200, Thomas Monjalon wrote:
> > > A couple of mistakes slipped in the mass change.
> > > 
> > > More mistakes could happen, especially when rebasing pending patches, so
> > > we need an automatic check.
> > >
> > I have a partially-done script from when I was doing the original
> > reindenting work, which I'll clean up a little and send on shortly.
> > 
> > It only checks indent of lists and I'm extending it to check for trailing
> > commas, but it may serve as a basis for further checks. On the plus side,
> > it does automatic fixing of those issues though. Running it will probably
> > show up more minor misses, so I'd suggest holding off on this patch until
> > then.
> 
> OK, I've sent this patch just for remembering.
> I am happy to leave it to you for a v2 :)
> Feel free to change the author of course.
> 
> Note: I've found tabs with this simple grep:
> 	git grep ' ' '**/meson.build'
> The tab is inserted with ^V-tab.
> 
I've included fixes for these issues in V2 set of the python script to
check for them.

http://patches.dpdk.org/project/dpdk/patch/20210426105403.226004-2-bruce.richardson@intel.com/
diff mbox series

Patch

diff --git a/drivers/crypto/qat/meson.build b/drivers/crypto/qat/meson.build
index 4da819d65a..544f481067 100644
--- a/drivers/crypto/qat/meson.build
+++ b/drivers/crypto/qat/meson.build
@@ -17,9 +17,9 @@  if dep.found()
             'qat_asym_pmd.c',
             'qat_sym.c',
             'qat_sym_hw_dp.c',
-			'qat_sym_pmd.c',
+            'qat_sym_pmd.c',
             'qat_sym_session.c',
-	)
+    )
     qat_ext_deps += dep
     qat_cflags += '-DBUILD_QAT_SYM'
     qat_cflags += '-DBUILD_QAT_ASYM'
diff --git a/drivers/raw/skeleton/meson.build b/drivers/raw/skeleton/meson.build
index b5d87652f5..950a33cc20 100644
--- a/drivers/raw/skeleton/meson.build
+++ b/drivers/raw/skeleton/meson.build
@@ -3,6 +3,6 @@ 
 
 deps += ['rawdev', 'kvargs', 'mbuf', 'bus_vdev']
 sources = files(
-		'skeleton_rawdev.c',
+        'skeleton_rawdev.c',
         'skeleton_rawdev_test.c',
 )