From patchwork Mon Apr 19 12:44:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 91750 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22D44A0524; Mon, 19 Apr 2021 14:45:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88437412DA; Mon, 19 Apr 2021 14:45:04 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-eopbgr770079.outbound.protection.outlook.com [40.107.77.79]) by mails.dpdk.org (Postfix) with ESMTP id 9DB30412DF for ; Mon, 19 Apr 2021 14:45:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mub0yctSLMPqA5bPRw6oAlW2DHfMxBBDRwfsPHOEVoJ3fmlNqmPINrTYLmVSpkPjzhL9NdVpPqPbVv/tTCJPd7cqXEVOBsqYME4TXh38fDD4urGtH8T6+Su6QyZOwR0FaZTqlkg5U+JXcKrsRZoxl3URiiFXh1pyyjRQL7SnRQ7k7PmIwlkSSsDRIIIYziY4OAmoi0pMudmOgaJAjkX2JGlGAfU1L6FB0Z9HkWGW0eOH21Yv6vx4suJBqlRF8//pGGTnRdHvvn24c+Ro2VTUKRBmUjJYFR3pyZflKYngBYBI1gsP1s+TvL349e/k8PIR3dYoL6qNsEwnsJ9j1vr5Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l3jgr6W/MxC4h07wfnrSUw2uyFiW+XZMLGYj1X50PAg=; b=FuUiwIGVqy9Mi5630Bf8gSioXLYpmV59yFK86R3hAUPdtKBKWHsraWxIUdgzSGWxG+PANzHrD4DmwzGcaRPNjPqiLnQpe9ivaF8+J3xzxf/43po6PN/0e2Ec5NGoowYrpyXFRlA48WYssFWV13EHMN1hpd2BIjwsGZOASp7BlLYSJjtZuytuOBQzqvYK3uDvd8rhuf2xFBQpu4WaHbW5SdN9Q5EKlxutAsoWTILtuZHlnGW53M8X5rkLCyzQiMM/1XfOVOM8pGdAsyv+uBas+ApI6gMmJAZWFZCXZjEm35DjxUOUo4o9PBAQaISDDOTD3VAgOHfZkhNO4AGfAMZxJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=6wind.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l3jgr6W/MxC4h07wfnrSUw2uyFiW+XZMLGYj1X50PAg=; b=qeMZ7bomDGZANLUZ4pELfUWMnSwgzWpb4p5QdWmPImE17iF0Z7EiruFyf3YLGRbnB/wu3iGX7ZhB5xjV7s+6hJ0PdB/SUebb7iuae3Bh6Ph9asoKphbNECkf1oLKWvQDuT+0DQIXAJpJaqsXHwuRX/84s5VMCu2oYEFUtb+CwRJA659grukNrK3QJDcOnm+6l4Kd7QdYIyGPpuIlb4L73i02D0jVbiyLHaUHJ2KuXJJqwsomS+HWz2mNUuhHsKWyNp6r3fvIBm91xJLoApTfIgv7y5AKIM2iZy1bs/Psc3Gy6B6Gk2Regs0FLzvsFKxfmsCnG+7sk//fMuMRHABv/g== Received: from BN0PR02CA0059.namprd02.prod.outlook.com (2603:10b6:408:e5::34) by MN2PR12MB3645.namprd12.prod.outlook.com (2603:10b6:208:cc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.22; Mon, 19 Apr 2021 12:44:58 +0000 Received: from BN8NAM11FT024.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e5:cafe::d4) by BN0PR02CA0059.outlook.office365.com (2603:10b6:408:e5::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Mon, 19 Apr 2021 12:44:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT024.mail.protection.outlook.com (10.13.177.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4042.16 via Frontend Transport; Mon, 19 Apr 2021 12:44:57 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 19 Apr 2021 12:44:53 +0000 From: Gregory Etelson To: CC: , , , , , , , , , , , , Xiaoyun Li Date: Mon, 19 Apr 2021 15:44:31 +0300 Message-ID: <20210419124431.21826-3-getelson@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210419124431.21826-1-getelson@nvidia.com> References: <20210419124431.21826-1-getelson@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d9e304be-636d-451b-bc44-08d90330f064 X-MS-TrafficTypeDiagnostic: MN2PR12MB3645: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-Transport-Forked: True X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3U6wWNrBP0uA6R/KQmTZZ5npCTdFVTJtgh+nHMgP+XiI2ZFfO/A6DuzT30lTGs8hJ+Sa7WCvbf84qPYxdmAy32QK4Uu7ci+D9aWCsWpcwCnrdMZGYG7sApJM7O6mq3aMGllOWKM2PcnIhgdg4YCKkVtz/2QyYDZmsYyQ0g2GtJ+XDboHdH3tVFJpPtkWYBgAJrB4PINVEi8E0nlSfB8fVAUx1vtkTubmWVl8ZxTGFGtWMw9iQqAcQBhtGbGYTeYkZKyKgbNmULnTL6tdikn+tLx1IT18Ryd0pu7Z8cyishydbE28OIfFvUVHEzn33ctVCHMJv1UF0dl4OsJbM5zooyf4XDSCVeCU/YGhJ/chRqgpA+mF8N9mWa6z96xBvlLocSBHyN5vw77EPAXCHgKAL1DU5boGtjebv4QxSYbQrGaT9mAO0z6gdMNxMylHLBq6WBknmOQ8G/8hsVGDCOsnvF0xB5nBbsSiq6yd3w6bX67PF1CVVV06wDrAxvK7/S7MkdtgpNcw+azCfp3YTOaUZtXRsAvtouZNp8ABqydunvoTXTdZcxz3OL3VNd+PbyysW3dnXAR/U1nUgPfpFg/m5GtFXrJmURuBvwG0eUjauNW6dhJCfqm5NdiBIRYkvPP7JYJPMZTHvZhkQU+oibHIVgU38PxDdUCRUFCmeIOZOlk= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(39850400004)(376002)(36840700001)(46966006)(16526019)(55016002)(186003)(478600001)(8936002)(426003)(70206006)(2906002)(82310400003)(6862004)(36860700001)(26005)(8676002)(82740400003)(36906005)(356005)(336012)(1076003)(47076005)(6636002)(5660300002)(37006003)(7636003)(83380400001)(70586007)(7696005)(6286002)(54906003)(6666004)(86362001)(316002)(36756003)(4326008)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2021 12:44:57.4343 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d9e304be-636d-451b-bc44-08d90330f064 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT024.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3645 Subject: [dpdk-dev] [PATCH v8 2/2] app/testpmd: add support for integrity item X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Ori Kam The integrity item allows the application to match on the integrity of a packet. use example: match that packet integrity checks are ok. The checks depend on packet layers. For example ICMP packet will not check L4 level. flow create 0 ingress pattern integrity value mask 0x01 value spec 0x01 match that L4 packet is ok - check L2 & L3 & L4 layers: flow create 0 ingress pattern integrity value mask 0xfe value spec 0xfe Signed-off-by: Ori Kam Signed-off-by: Gregory Etelson Acked-by: Ferruh Yigit Acked-by: Ajit Khaparde --- app/test-pmd/cmdline_flow.c | 39 +++++++++++++++++++++ doc/guides/testpmd_app_ug/testpmd_funcs.rst | 28 +++++++++++++++ 2 files changed, 67 insertions(+) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 0127d9e7d6..a1b0fa4a32 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -293,6 +293,9 @@ enum index { ITEM_GENEVE_OPT_TYPE, ITEM_GENEVE_OPT_LENGTH, ITEM_GENEVE_OPT_DATA, + ITEM_INTEGRITY, + ITEM_INTEGRITY_LEVEL, + ITEM_INTEGRITY_VALUE, /* Validate/create actions. */ ACTIONS, @@ -968,6 +971,7 @@ static const enum index next_item[] = { ITEM_PFCP, ITEM_ECPRI, ITEM_GENEVE_OPT, + ITEM_INTEGRITY, END_SET, ZERO, }; @@ -1319,6 +1323,19 @@ static const enum index item_geneve_opt[] = { ZERO, }; +static const enum index item_integrity[] = { + ITEM_INTEGRITY_LEVEL, + ITEM_INTEGRITY_VALUE, + ZERO, +}; + +static const enum index item_integrity_lv[] = { + ITEM_INTEGRITY_LEVEL, + ITEM_INTEGRITY_VALUE, + ITEM_NEXT, + ZERO, +}; + static const enum index next_action[] = { ACTION_END, ACTION_VOID, @@ -3400,6 +3417,28 @@ static const struct token token_list[] = { (sizeof(struct rte_flow_item_geneve_opt), ITEM_GENEVE_OPT_DATA_SIZE)), }, + [ITEM_INTEGRITY] = { + .name = "integrity", + .help = "match packet integrity", + .priv = PRIV_ITEM(INTEGRITY, + sizeof(struct rte_flow_item_integrity)), + .next = NEXT(item_integrity), + .call = parse_vc, + }, + [ITEM_INTEGRITY_LEVEL] = { + .name = "level", + .help = "integrity level", + .next = NEXT(item_integrity_lv, NEXT_ENTRY(UNSIGNED), + item_param), + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_integrity, level)), + }, + [ITEM_INTEGRITY_VALUE] = { + .name = "value", + .help = "integrity value", + .next = NEXT(item_integrity_lv, NEXT_ENTRY(UNSIGNED), + item_param), + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_integrity, value)), + }, /* Validate/create actions. */ [ACTIONS] = { .name = "actions", diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index e3bfed566d..feaae9350b 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -3791,6 +3791,13 @@ This section lists supported pattern items and their attributes, if any. - ``s_field {unsigned}``: S field. - ``seid {unsigned}``: session endpoint identifier. +- ``integrity``: match packet integrity. + + - ``level {unsigned}``: Packet encapsulation level the item should + apply to. See rte_flow_action_rss for details. + - ``value {unsigned}``: A bitmask that specify what packet elements + must be matched for integrity. + Actions list ^^^^^^^^^^^^ @@ -4925,6 +4932,27 @@ NVGRE encapsulation header and sent to port id 0. testpmd> flow create 0 ingress transfer pattern eth / end actions sample ratio 1 index 0 / port_id id 2 / end +Sample integrity rules +~~~~~~~~~~~~~~~~~~~~~~ + +Integrity rules can be created by the following commands: + +Integrity rule that forwards valid TCP packets to group 1. +TCP packet integrity is matched with the ``l4_ok`` bit 3. + +:: + + testpmd> flow create 0 ingress + pattern eth / ipv4 / tcp / integrity value mask 8 value spec 8 / end + actions jump group 1 / end + +Integrity rule that forwards invalid packets to application. +General packet integrity is matched with the ``packet_ok`` bit 0. + +:: + + testpmd> flow create 0 ingress pattern integrity value mask 1 value spec 0 / end actions queue index 0 / end + BPF Functions --------------