From patchwork Mon Apr 19 05:44:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jiang, Cheng1" X-Patchwork-Id: 91725 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3F3DA0547; Mon, 19 Apr 2021 07:59:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AEDA341195; Mon, 19 Apr 2021 07:59:29 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id B01D141193; Mon, 19 Apr 2021 07:59:27 +0200 (CEST) IronPort-SDR: slmWcPHE2djM8mJO2xav271rxPcRCjhvMhLYOuMxe7q3jvPk7enn1/Y77SU69wLmgLGKW8b8Di QKqP5I15+PEw== X-IronPort-AV: E=McAfee;i="6200,9189,9958"; a="192084070" X-IronPort-AV: E=Sophos;i="5.82,233,1613462400"; d="scan'208";a="192084070" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Apr 2021 22:59:25 -0700 IronPort-SDR: RV/NHxHoglU2KfVFNL8f1sN5RZ75gEzBMpBHbTE4NffpojpBEJyor1UB5tAUOQ1lRtj1bHXUIv xR7G4GWb/pUA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,233,1613462400"; d="scan'208";a="462623903" Received: from dpdk_jiangcheng.sh.intel.com ([10.67.119.112]) by orsmga001.jf.intel.com with ESMTP; 18 Apr 2021 22:59:23 -0700 From: Cheng Jiang To: maxime.coquelin@redhat.com, chenbo.xia@intel.com Cc: dev@dpdk.org, Cheng Jiang , stable@dpdk.org Date: Mon, 19 Apr 2021 05:44:26 +0000 Message-Id: <20210419054426.26812-1-Cheng1.jiang@intel.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] examples/vhost: fix potential overflow in args process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add args length check to fix potential overflow issue. Coverity issue: 363741 Fixes: 965b06f0358 ("examples/vhost: enhance getopt_long usage") Cc: stable@dpdk.org Signed-off-by: Cheng Jiang --- examples/vhost/main.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index 119ba7e01..5df36ad3c 100644 --- a/examples/vhost/main.c +++ b/examples/vhost/main.c @@ -669,6 +669,11 @@ us_vhost_parse_args(int argc, char **argv) break; case OPT_DMA_TYPE_NUM: + if (strlen(optarg) >= MAX_LONG_OPT_SZ) { + RTE_LOG(INFO, VHOST_CONFIG, "Wrong DMA type\n"); + us_vhost_usage(prgname); + return -1; + } strcpy(dma_type, optarg); break;