diff mbox series

ci: bump ABI reference version

Message ID 20210415163230.22263-1-david.marchand@redhat.com (mailing list archive)
State Superseded
Headers show
Series ci: bump ABI reference version | expand

Checks

Context Check Description
ci/iol-abi-testing warning Testing issues
ci/github-robot fail github build: failed
ci/travis-robot fail travis build: failed
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch warning coding style issues

Commit Message

David Marchand April 15, 2021, 4:32 p.m. UTC
When bumping DPDK version, we should have bumped the ABI reference too.

Fixes: 442155f70c6b ("version: 21.05-rc0")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 .github/workflows/build.yml | 2 +-
 .travis.yml                 | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Monjalon April 15, 2021, 4:57 p.m. UTC | #1
15/04/2021 18:32, David Marchand:
> When bumping DPDK version, we should have bumped the ABI reference too.
> 
> Fixes: 442155f70c6b ("version: 21.05-rc0")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> -      REF_GIT_TAG: v20.11
> +      REF_GIT_TAG: v21.02

Yes, checking against 21.02 may catch breakage of ABI
added in 21.02.

Acked-by: Thomas Monjalon <thomas@monjalon.net>
David Marchand April 15, 2021, 7:28 p.m. UTC | #2
On Thu, Apr 15, 2021 at 6:57 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 15/04/2021 18:32, David Marchand:
> > When bumping DPDK version, we should have bumped the ABI reference too.
> >
> > Fixes: 442155f70c6b ("version: 21.05-rc0")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > -      REF_GIT_TAG: v20.11
> > +      REF_GIT_TAG: v21.02
>
> Yes, checking against 21.02 may catch breakage of ABI
> added in 21.02.
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>

Unfortunately, we have a regression when (re)generating a ABI
reference in the CI script (compat issue with -Dmachine=generic that
is not understood by v21.02).
Testing the fix, will post later.
diff mbox series

Patch

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 9175ec43d3..d38feace69 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -21,7 +21,7 @@  jobs:
       CC: ccache ${{ matrix.config.compiler }}
       DEF_LIB: ${{ matrix.config.library }}
       LIBABIGAIL_VERSION: libabigail-1.8
-      REF_GIT_TAG: v20.11
+      REF_GIT_TAG: v21.02
       RUN_TESTS: ${{ contains(matrix.config.checks, 'tests') }}
 
     strategy:
diff --git a/.travis.yml b/.travis.yml
index 7ed982ac07..898cffd998 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -41,7 +41,7 @@  script: ./.ci/${TRAVIS_OS_NAME}-build.sh
 env:
   global:
     - LIBABIGAIL_VERSION=libabigail-1.8
-    - REF_GIT_TAG=v20.11
+    - REF_GIT_TAG=v21.02
 
 jobs:
   include: