From patchwork Mon Apr 12 10:06:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Kardach X-Patchwork-Id: 91113 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E810A0C44; Mon, 12 Apr 2021 12:07:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BDFB81410BB; Mon, 12 Apr 2021 12:07:02 +0200 (CEST) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by mails.dpdk.org (Postfix) with ESMTP id 42C8D141096 for ; Mon, 12 Apr 2021 12:06:59 +0200 (CEST) Received: by mail-lj1-f179.google.com with SMTP id z8so14633245ljm.12 for ; Mon, 12 Apr 2021 03:06:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oSkUGtRTNN55g7hONGCvOMWJvZXlRljwfNHxbYce8xI=; b=2R85gecZUPNEXdoKdzalaCv6oqC8fpHt1gTV7QjeWpIQfT5UMsmNe9Z93a3gGuAhbC FacfKiXCR4xa9qFCllQo0eOmJNiZploXwC3MbLdVmXsJCQaj5ekAlRyFa7GXwzCu4qDd aG68c4lUBxDIP0ZWI5E+umChldpbUr25ZrBcAfO4FN03lCSuhqDkRPNyjMBbk6L8JGcQ ii4B6M2vvzLDcTmsYvWdYwn5TtlS61I2rmQZMGP3/kgGdb+/LwcBt/bdoNw/q6gFduSs 4Dya7iUPGZFKsh9K6NphG7cxWxlK6XdRxN0uRlfyzVO5mx42ziphtcJ+EXJzpDgu3A9z 10Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oSkUGtRTNN55g7hONGCvOMWJvZXlRljwfNHxbYce8xI=; b=GtkyZKBhAGTKq3VSMRqAXyimqrAG+3r4iE9flYTheKDpunNcl0rjWVf1MKXbIsSyQA SUO1R+i189F3bSNswX3BZnNvTTlcq18AIwa/Vxst0w1wUPCOTitWaI08lLohJO6zha5K egci8DW8VQ7tI2CAKeiieXWnJfsH1TwPBgWP8nBKgdGnmf5idnbh58onnPmWaedReMr4 tCwgd+M/VN6clXOxO6bcLQJE36l3jrnz+bAis46Grk3+rTTrq727M6XMSumdsPTRi6qD RDExbCyGJpqHWNCVW0tHTORdjhgHVRfLaCUJtY6dgEuBgXni1WtddD2TH0BcBmFAtr9B 5r+A== X-Gm-Message-State: AOAM530kc1L/ouQetcUj/BKKeQcIOv/Xa0uU6WDbMs2LGV9d2Yn12y/Y DJkcS5DygJP2rKwSXTO3TXB6rA== X-Google-Smtp-Source: ABdhPJxfgEV6I5bfkrgmGifb/tAat9ov2DATINiyqhTxUeHUgLpCFTLRD0bdv6AFooVT0COOHWRpQw== X-Received: by 2002:a05:651c:222:: with SMTP id z2mr6998375ljn.109.1618222018837; Mon, 12 Apr 2021 03:06:58 -0700 (PDT) Received: from toster.semihalf.com (host-193.106.246.139.static.3s.pl. [193.106.246.139]) by smtp.gmail.com with ESMTPSA id u9sm2781326ljj.0.2021.04.12.03.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 03:06:58 -0700 (PDT) From: Stanislaw Kardach To: Anatoly Burakov Cc: dev@dpdk.org, Stanislaw Kardach , stable@dpdk.org Date: Mon, 12 Apr 2021 12:06:45 +0200 Message-Id: <20210412100645.668395-4-kda@semihalf.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210412100645.668395-1-kda@semihalf.com> References: <20210412100645.668395-1-kda@semihalf.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 3/3] test: fix the -n unit test description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When -n argument became optional, the test logic was fixed (by 1e0b51fd4) but the comment indicating why --no-huge and --no-shconf are used was not changed. Today those flags are used for compatibility with FreeBSD (see b5d878e6d), so change the comment to reflect that. Signed-off-by: Stanislaw Kardach Fixes: b5d878e6db56 ("test: fix EAL flags autotest on FreeBSD") Cc: stable@dpdk.org --- app/test/test_eal_flags.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index cfc54684a..894e2e90c 100644 --- a/app/test/test_eal_flags.c +++ b/app/test/test_eal_flags.c @@ -666,8 +666,8 @@ test_main_lcore_flag(void) /* * Test that the app doesn't run with invalid -n flag option. * Final test ensures it does run with valid options as sanity check - * Since -n is not compulsory for MP, we instead use --no-huge and --no-shconf - * flags. + * For compatibility with BSD use --no-huge and --no-shconf flags as we need to + * run a primary process. */ static int test_invalid_n_flag(void)