From patchwork Sun Apr 11 12:21:36 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tal Shnaiderman X-Patchwork-Id: 91070 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6CB2A0562; Sun, 11 Apr 2021 14:22:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D2071413D9; Sun, 11 Apr 2021 14:22:24 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by mails.dpdk.org (Postfix) with ESMTP id 45BA01413C8 for ; Sun, 11 Apr 2021 14:22:23 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from talshn@nvidia.com) with SMTP; 11 Apr 2021 15:22:21 +0300 Received: from nvidia.com (l-wincomp04-vm.mtl.labs.mlnx [10.237.1.5]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 13BCMLax006999; Sun, 11 Apr 2021 15:22:21 +0300 From: Tal Shnaiderman To: dev@dpdk.org Cc: thomas@monjalon.net, matan@nvidia.com, rasland@nvidia.com, asafp@nvidia.com, wisamm@nvidia.com, stable@dpdk.org Date: Sun, 11 Apr 2021 15:21:36 +0300 Message-Id: <20210411122136.2560-1-talshn@nvidia.com> X-Mailer: git-send-email 2.16.1.windows.4 Subject: [dpdk-dev] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Several functions introduced in the addition of the Windows support to mlx5 were missing the __rte_internal tag although being exported. Fixes: 1552fb287166 ("common/mlx5: add alloc/dealloc PD on Windows") Fixes: 1969ee424405 ("common/mlx5: add UMEM reg/dereg functions on Windows") Fixes: ba420719823c ("common/mlx5: add reg/dereg MR on Windows") Cc: stable@dpdk.org Signed-off-by: Tal Shnaiderman Acked-by: Matan Azrad Tested-by: Wisam Jaddo Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/linux/mlx5_common_os.h | 4 ++++ drivers/common/mlx5/windows/mlx5_common_os.h | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/drivers/common/mlx5/linux/mlx5_common_os.h b/drivers/common/mlx5/linux/mlx5_common_os.h index 63f070d9c4..d1c7e3dce0 100644 --- a/drivers/common/mlx5/linux/mlx5_common_os.h +++ b/drivers/common/mlx5/linux/mlx5_common_os.h @@ -203,24 +203,28 @@ mlx5_os_get_devx_uar_page_id(void *uar) #endif } +__rte_internal static inline void * mlx5_os_alloc_pd(void *ctx) { return mlx5_glue->alloc_pd(ctx); } +__rte_internal static inline int mlx5_os_dealloc_pd(void *pd) { return mlx5_glue->dealloc_pd(pd); } +__rte_internal static inline void * mlx5_os_umem_reg(void *ctx, void *addr, size_t size, uint32_t access) { return mlx5_glue->devx_umem_reg(ctx, addr, size, access); } +__rte_internal static inline int mlx5_os_umem_dereg(void *pumem) { diff --git a/drivers/common/mlx5/windows/mlx5_common_os.h b/drivers/common/mlx5/windows/mlx5_common_os.h index e92533c4d3..3756e1959b 100644 --- a/drivers/common/mlx5/windows/mlx5_common_os.h +++ b/drivers/common/mlx5/windows/mlx5_common_os.h @@ -248,11 +248,17 @@ mlx5_os_devx_subscribe_devx_event(void *eventc, return -ENOTSUP; } +__rte_internal void *mlx5_os_alloc_pd(void *ctx); +__rte_internal int mlx5_os_dealloc_pd(void *pd); +__rte_internal void *mlx5_os_umem_reg(void *ctx, void *addr, size_t size, uint32_t access); +__rte_internal int mlx5_os_umem_dereg(void *pumem); +__rte_internal int mlx5_os_reg_mr(void *pd, void *addr, size_t length, struct mlx5_pmd_mr *pmd_mr); +__rte_internal void mlx5_os_dereg_mr(struct mlx5_pmd_mr *pmd_mr); #endif /* RTE_PMD_MLX5_COMMON_OS_H_ */