From patchwork Thu Apr 1 08:28:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yu, DapengX" X-Patchwork-Id: 90285 X-Patchwork-Delegate: andrew.rybchenko@oktetlabs.ru Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AD7EA034F; Thu, 1 Apr 2021 10:29:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1FB00140ECE; Thu, 1 Apr 2021 10:29:00 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 15AE740142; Thu, 1 Apr 2021 10:28:58 +0200 (CEST) IronPort-SDR: XYA6HI4QhpdWTE2vDDzBMSuHIRlYUqjj7g/B3S09E2+UzqAoMbyyWM4cD62c+/XRVdQa6RyhaK II8NEcnZcGfQ== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="256167798" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="256167798" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 01:28:55 -0700 IronPort-SDR: hiGSStlGZnrm7/uXLzfuoxxdFP35kh72sZiacZU+IqeP94ozbMyoriN7iWEjfT1SoLIcjRX63j LZr0my4/Dpsw== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="412573135" Received: from unknown (HELO localhost.localdomain) ([10.240.183.93]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 01:28:52 -0700 From: dapengx.yu@intel.com To: xiaoyun.li@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, Dapeng Yu , stable@dpdk.org Date: Thu, 1 Apr 2021 16:28:44 +0800 Message-Id: <20210401082844.401918-1-dapengx.yu@intel.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Dapeng Yu Configure per queue rx offloading and per queue tx offloading command shouldn't trigger the rte_eth_dev_configure() to reconfigure device. The patch sets the queue reconfiguration flag only, and does not set the device reconfiguration flag. Therefore after port is restarted, rte_eth_dev_configure() will not be called again. Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") Cc: stable@dpdk.org Signed-off-by: Dapeng Yu Acked-by: Xiaoyun Li --- app/test-pmd/cmdline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 14110eb2e..b49e9f52b 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -15626,7 +15626,7 @@ cmd_config_per_queue_rx_offload_parsed(void *parsed_result, else port->rx_conf[queue_id].offloads &= ~single_offload; - cmd_reconfig_device_queue(port_id, 1, 1); + cmd_reconfig_device_queue(port_id, 0, 1); } cmdline_parse_inst_t cmd_config_per_queue_rx_offload = { @@ -16044,7 +16044,7 @@ cmd_config_per_queue_tx_offload_parsed(void *parsed_result, else port->tx_conf[queue_id].offloads &= ~single_offload; - cmd_reconfig_device_queue(port_id, 1, 1); + cmd_reconfig_device_queue(port_id, 0, 1); } cmdline_parse_inst_t cmd_config_per_queue_tx_offload = {