diff mbox series

net/igc: fix Rx error counter for badlen packets

Message ID 20210401011648.17888-1-alvinx.zhang@intel.com (mailing list archive)
State Superseded
Headers show
Series net/igc: fix Rx error counter for badlen packets | expand

Checks

Context Check Description
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot success github build: passed
ci/travis-robot success travis build: passed
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Alvin Zhang April 1, 2021, 1:16 a.m. UTC
When the size of the packet is less than the minimum or greater
than the maximum, the packet will be counted twice in the error
packet counter.

Fixes: e6defdfddc3b ("net/igc: enable statistics")
Cc: stable@dpdk.org

Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
---
 drivers/net/igc/igc_ethdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Wang, Haiyue April 1, 2021, 1:57 a.m. UTC | #1
> -----Original Message-----
> From: Zhang, AlvinX <alvinx.zhang@intel.com>
> Sent: Thursday, April 1, 2021 09:17
> To: Wang, Haiyue <haiyue.wang@intel.com>; Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/igc: fix Rx error counter for badlen packets
> 
> When the size of the packet is less than the minimum or greater
> than the maximum, the packet will be counted twice in the error
> packet counter.

This message is not clear, the packet should be minimum or greater,
but not at the same time, why twice ? Please describe the new stats
you use more clear.

> 
> Fixes: e6defdfddc3b ("net/igc: enable statistics")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> ---
>  drivers/net/igc/igc_ethdev.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c
> index 0ea6e2a..c398701 100644
> --- a/drivers/net/igc/igc_ethdev.c
> +++ b/drivers/net/igc/igc_ethdev.c
> @@ -1901,8 +1901,7 @@ static int eth_igc_vlan_tpid_set(struct rte_eth_dev *dev,
> 
>  	/* Rx Errors */
>  	rte_stats->imissed = stats->mpc;
> -	rte_stats->ierrors = stats->crcerrs +
> -			stats->rlec + stats->ruc + stats->roc +
> +	rte_stats->ierrors = stats->crcerrs + stats->rlec +
>  			stats->rxerrc + stats->algnerrc;
> 
>  	/* Tx Errors */
> --
> 1.8.3.1
diff mbox series

Patch

diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c
index 0ea6e2a..c398701 100644
--- a/drivers/net/igc/igc_ethdev.c
+++ b/drivers/net/igc/igc_ethdev.c
@@ -1901,8 +1901,7 @@  static int eth_igc_vlan_tpid_set(struct rte_eth_dev *dev,
 
 	/* Rx Errors */
 	rte_stats->imissed = stats->mpc;
-	rte_stats->ierrors = stats->crcerrs +
-			stats->rlec + stats->ruc + stats->roc +
+	rte_stats->ierrors = stats->crcerrs + stats->rlec +
 			stats->rxerrc + stats->algnerrc;
 
 	/* Tx Errors */