diff mbox series

[v3] net/ixgbe: fix RSS RETA be reset after port start

Message ID 20210329082845.33038-1-murphyx.yang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers show
Series [v3] net/ixgbe: fix RSS RETA be reset after port start | expand

Checks

Context Check Description
ci/iol-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-abi-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot success github build: passed
ci/travis-robot success travis build: passed
ci/checkpatch success coding style OK

Commit Message

Murphy Yang March 29, 2021, 8:28 a.m. UTC
If one calls ‘rte_eth_dev_rss_reta_update’ with ixgbe before starting
the device (but after setting everything else), then RSS RETA
configuration be zero after starting the device.

This patch gives a notification if the port not started.

Bugzilla ID: 664
Fixes: 249358424eab ("ixgbe: RSS RETA configuration")

Signed-off-by: Murphy Yang <murphyx.yang@intel.com>
---
v3:
- modify the notify message
v2:
- tune the return value
 drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Wang, Haiyue March 29, 2021, 12:40 p.m. UTC | #1
> -----Original Message-----
> From: Yang, MurphyX <murphyx.yang@intel.com>
> Sent: Monday, March 29, 2021 16:29
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Guo, Jia
> <jia.guo@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Zhang, RobinX <robinx.zhang@intel.com>;
> Yang, MurphyX <murphyx.yang@intel.com>
> Subject: [PATCH v3] net/ixgbe: fix RSS RETA be reset after port start
> 
> If one calls ‘rte_eth_dev_rss_reta_update’ with ixgbe before starting
> the device (but after setting everything else), then RSS RETA
> configuration be zero after starting the device.
> 
> This patch gives a notification if the port not started.
> 
> Bugzilla ID: 664
> Fixes: 249358424eab ("ixgbe: RSS RETA configuration")
> 
> Signed-off-by: Murphy Yang <murphyx.yang@intel.com>
> ---
> v3:
> - modify the notify message
> v2:
> - tune the return value
>  drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 8a9a21e7c2..d8ef618e5f 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c

Acked-by: Haiyue Wang <haiyue.wang@intel.com>


> --
> 2.17.1
Zhang, Qi Z April 1, 2021, 1:17 a.m. UTC | #2
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Wang, Haiyue
> Sent: Monday, March 29, 2021 8:41 PM
> To: Yang, MurphyX <murphyx.yang@intel.com>; dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Guo, Jia <jia.guo@intel.com>;
> Yang, SteveX <stevex.yang@intel.com>; Zhang, RobinX
> <robinx.zhang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix RSS RETA be reset after port
> start
> 
> > -----Original Message-----
> > From: Yang, MurphyX <murphyx.yang@intel.com>
> > Sent: Monday, March 29, 2021 16:29
> > To: dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; Wang, Haiyue
> > <haiyue.wang@intel.com>; Guo, Jia <jia.guo@intel.com>; Yang, SteveX
> > <stevex.yang@intel.com>; Zhang, RobinX <robinx.zhang@intel.com>; Yang,
> > MurphyX <murphyx.yang@intel.com>
> > Subject: [PATCH v3] net/ixgbe: fix RSS RETA be reset after port start
> >
> > If one calls ‘rte_eth_dev_rss_reta_update’ with ixgbe before starting
> > the device (but after setting everything else), then RSS RETA
> > configuration be zero after starting the device.
> >
> > This patch gives a notification if the port not started.
> >
> > Bugzilla ID: 664
> > Fixes: 249358424eab ("ixgbe: RSS RETA configuration")
> >
> > Signed-off-by: Murphy Yang <murphyx.yang@intel.com>
> > ---
> > v3:
> > - modify the notify message
> > v2:
> > - tune the return value
> >  drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> > b/drivers/net/ixgbe/ixgbe_ethdev.c
> > index 8a9a21e7c2..d8ef618e5f 100644
> > --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> 
> Acked-by: Haiyue Wang <haiyue.wang@intel.com>
> 
Applied to dpdk-next-net-intel.

Thanks
Qi
> 
> > --
> > 2.17.1
diff mbox series

Patch

diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 8a9a21e7c2..d8ef618e5f 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -5015,11 +5015,19 @@  ixgbe_dev_rss_reta_update(struct rte_eth_dev *dev,
 	uint32_t reta, r;
 	uint16_t idx, shift;
 	struct ixgbe_adapter *adapter = dev->data->dev_private;
+	struct rte_eth_dev_data *dev_data = dev->data;
 	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
 	uint32_t reta_reg;
 
 	PMD_INIT_FUNC_TRACE();
 
+	if (!dev_data->dev_started) {
+		PMD_DRV_LOG(ERR,
+			"port %d must be started before rss reta update",
+			 dev_data->port_id);
+		return -EIO;
+	}
+
 	if (!ixgbe_rss_update_sp(hw->mac.type)) {
 		PMD_DRV_LOG(ERR, "RSS reta update is not supported on this "
 			"NIC.");