| Message ID | 20210329081048.32676-1-murphyx.yang@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v2] net/ixgbe: fix RSS RETA be reset after port start | expand |
| Context | Check | Description |
|---|---|---|
| ci/intel-Testing | success | Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/checkpatch | warning | coding style issues |
> -----Original Message----- > From: Murphy Yang <murphyx.yang@intel.com> > Sent: Monday, March 29, 2021 16:11 > To: dev@dpdk.org > Cc: Yang, Qiming <qiming.yang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Guo, Jia > <jia.guo@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Zhang, RobinX <robinx.zhang@intel.com>; > Yang, MurphyX <murphyx.yang@intel.com> > Subject: [PATCH v2] net/ixgbe: fix RSS RETA be reset after port start > > If one calls ‘rte_eth_dev_rss_reta_update’ with ixgbe before starting > the device (but after setting everything else), then RSS RETA > configuration be zero after starting the device. > > This patch gives a notification if the port not started. > > Bugzilla ID: 664 > Fixes: 249358424eab ("ixgbe: RSS RETA configuration") > > Signed-off-by: Murphy Yang <murphyx.yang@intel.com> > --- > v2: > - tune the return value > > drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++++++ > 1 file changed, 8 insertions(+) Acked-by: Haiyue Wang <haiyue.wang@intel.com> > -- > 2.17.1
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 8a9a21e7c2..6aebf9c11e 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -5015,11 +5015,19 @@ ixgbe_dev_rss_reta_update(struct rte_eth_dev *dev, uint32_t reta, r; uint16_t idx, shift; struct ixgbe_adapter *adapter = dev->data->dev_private; + struct rte_eth_dev_data *dev_data = dev->data; struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private); uint32_t reta_reg; PMD_INIT_FUNC_TRACE(); + if (!dev_data->dev_started) { + PMD_DRV_LOG(ERR, + "port %d must be started before configuration", + dev_data->port_id); + return -EIO; + } + if (!ixgbe_rss_update_sp(hw->mac.type)) { PMD_DRV_LOG(ERR, "RSS reta update is not supported on this " "NIC.");
If one calls ‘rte_eth_dev_rss_reta_update’ with ixgbe before starting the device (but after setting everything else), then RSS RETA configuration be zero after starting the device. This patch gives a notification if the port not started. Bugzilla ID: 664 Fixes: 249358424eab ("ixgbe: RSS RETA configuration") Signed-off-by: Murphy Yang <murphyx.yang@intel.com> --- v2: - tune the return value drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++++++ 1 file changed, 8 insertions(+)