From patchwork Thu Mar 25 08:22:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Loftus, Ciara" X-Patchwork-Id: 89832 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70DA6A0A02; Thu, 25 Mar 2021 09:53:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57E64140D08; Thu, 25 Mar 2021 09:53:40 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 5770C40693 for ; Thu, 25 Mar 2021 09:53:38 +0100 (CET) IronPort-SDR: HoKdW/egrnUlzPBG160WYjgAe717iGZk8C6ho1i/nQLRWte3S9XzEQe2F1VDYu6e8KS8AItbc8 LQM0P5ZZp6CA== X-IronPort-AV: E=McAfee;i="6000,8403,9933"; a="276010068" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="276010068" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 01:53:37 -0700 IronPort-SDR: ia32rq66eNLmrvLf4msVYL1fw9ZlUsDuBaStcSr4+dqWk3E03zs7gGogdTe/BLcwcXvrkxXCRP zP6/AS4Xorlg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="436385902" Received: from silpixa00399839.ir.intel.com (HELO localhost.localdomain) ([10.237.222.142]) by fmsmga004.fm.intel.com with ESMTP; 25 Mar 2021 01:53:36 -0700 From: Ciara Loftus To: dev@dpdk.org Cc: Ciara Loftus Date: Thu, 25 Mar 2021 08:22:09 +0000 Message-Id: <20210325082209.29550-1-ciara.loftus@intel.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] net/af_xdp: fix unchecked return of recvfrom() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Coverity complains that the return value of recvfrom() in the AF_XDP datapath is not checked. We don't care about the return value because in the case of an error we still return 0 from the receive function to indicate no packets were received. So to make Coverity happy we cast the return to 'void'. Coverity issue: 369671 Fixes: 63e8989fe5a4 ("net/af_xdp: use recvfrom instead of poll syscall") Signed-off-by: Ciara Loftus --- drivers/net/af_xdp/rte_eth_af_xdp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index a64fef1cf5..6e44a21c64 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -274,7 +274,7 @@ af_xdp_rx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) if (nb_pkts == 0) { if (syscall_needed(&rxq->fq, rxq->busy_budget)) - recvfrom(xsk_socket__fd(rxq->xsk), NULL, 0, + (void)recvfrom(xsk_socket__fd(rxq->xsk), NULL, 0, MSG_DONTWAIT, NULL, NULL); return 0; @@ -346,7 +346,7 @@ af_xdp_rx_cp(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) if (nb_pkts == 0) { #if defined(XDP_USE_NEED_WAKEUP) if (xsk_ring_prod__needs_wakeup(fq)) - recvfrom(xsk_socket__fd(rxq->xsk), NULL, 0, + (void)recvfrom(xsk_socket__fd(rxq->xsk), NULL, 0, MSG_DONTWAIT, NULL, NULL); #endif return 0;