| Message ID | 20210318195229.683367-1-lance.richardson@broadcom.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Ajit Khaparde |
| Headers | show |
| Series | [1/1] net/bnxt: fix transmit length hint threshold | expand |
| Context | Check | Description |
|---|---|---|
| ci/intel-Testing | success | Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/iol-testing | success | Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-abi-testing | success | Testing PASS |
| ci/github-robot | success | github build: passed |
| ci/travis-robot | success | travis build: passed |
| ci/checkpatch | success | coding style OK |
On Thu, Mar 18, 2021 at 12:52 PM Lance Richardson <lance.richardson@broadcom.com> wrote: > > Use correct threshold when selecting "greater than or equal to > 2K" length hint. > > Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") > Cc: stable@dpdk.org > > Signed-off-by: Lance Richardson <lance.richardson@broadcom.com> > Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com> > Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_txr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c > index 65355fb040..27459960de 100644 > --- a/drivers/net/bnxt/bnxt_txr.c > +++ b/drivers/net/bnxt/bnxt_txr.c > @@ -187,7 +187,7 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt, > txbd->flags_type |= TX_BD_SHORT_FLAGS_COAL_NOW; > txbd->flags_type |= TX_BD_LONG_FLAGS_NO_CMPL; > txbd->len = tx_pkt->data_len; > - if (tx_pkt->pkt_len >= 2014) > + if (tx_pkt->pkt_len >= 2048) > txbd->flags_type |= TX_BD_LONG_FLAGS_LHINT_GTE2K; > else > txbd->flags_type |= lhint_arr[tx_pkt->pkt_len >> 9]; > -- > 2.25.1 >
diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c index 65355fb040..27459960de 100644 --- a/drivers/net/bnxt/bnxt_txr.c +++ b/drivers/net/bnxt/bnxt_txr.c @@ -187,7 +187,7 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt, txbd->flags_type |= TX_BD_SHORT_FLAGS_COAL_NOW; txbd->flags_type |= TX_BD_LONG_FLAGS_NO_CMPL; txbd->len = tx_pkt->data_len; - if (tx_pkt->pkt_len >= 2014) + if (tx_pkt->pkt_len >= 2048) txbd->flags_type |= TX_BD_LONG_FLAGS_LHINT_GTE2K; else txbd->flags_type |= lhint_arr[tx_pkt->pkt_len >> 9];
Use correct threshold when selecting "greater than or equal to 2K" length hint. Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Cc: stable@dpdk.org Signed-off-by: Lance Richardson <lance.richardson@broadcom.com> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com> --- drivers/net/bnxt/bnxt_txr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)