From patchwork Mon Mar 15 10:52:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabriel Ganne X-Patchwork-Id: 89117 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E7BBA054F; Mon, 15 Mar 2021 11:52:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 38C1324261F; Mon, 15 Mar 2021 11:52:53 +0100 (CET) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mails.dpdk.org (Postfix) with ESMTP id 9D45C4003C for ; Mon, 15 Mar 2021 11:52:52 +0100 (CET) Received: by mail-wr1-f54.google.com with SMTP id o16so5435469wrn.0 for ; Mon, 15 Mar 2021 03:52:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hXi/9Rsv335jhO86mNb4N/G3mWVYz7eZ1m+5IOC2ECc=; b=LcpAUy7SLF6kshi2M9pMLyfqPyImgp7VnsEurxp92bwQr2m2M1qPvfCLhQK6/C61OJ Z8kyUJYQqp14BfTyAfJfTh97yLzAVSco8zDkTmchoOQAR7OT7o57eHjWgNlhdfMDHhwP cGFGLXVKrREQflZtBQ4pEHnbxGsoTFFQ2t3yykUq8Inpchwq/AZiZ75nKtUvrYjuWX3J zzkGdFQH8dsEgIubilpStxTsn2P2BHNK55X0PJamC95jdESf7J0WvRh8R3avgfkzyL0Y odpxNFV8ESi/U3x73rfqigEvYoLiiASpOnN7fAAiPeFudtshw+R7hNDCyFXh3j0ZfdYb GyYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hXi/9Rsv335jhO86mNb4N/G3mWVYz7eZ1m+5IOC2ECc=; b=NsCaXc4SfbqmCR7703cFlDeHx5HXU+zR3jGB0ytl0dlnEkmDqJsiLIP47SC61NCaHj QZfB+ZlmpAyqEMsvKEbkEzrjyPKGwuV/4nrE6gudelZl+Jnn5Nm62VKmemxYhqEXxH/1 F8iAsL/oyjSUHMlu8uadfJ2no/YU8dphaDwRXjHuAXo8hoON0HvZz3SavcxcTM6AJLDZ oHRlzZuTH9OV38GewXNK+3xYenMxH0OYIJY6P4zq2RS6EFaFMNdISpTwceBObaQlfHdW VN/0/5WI28ouT9XkE/MNWASn4uF47hAT80D8/jBoK/VaY4PGVsJJOQhL4ZWynbcwU9BX HVWA== X-Gm-Message-State: AOAM530HriTXbL8Hdi9AmtXaS8NWj6Bq4NP8Mi3nttFNRuwgZXcNjDhV lGXcoCbUvIJclv82rTJsKZZYDw7LHk9SWTrKtic= X-Google-Smtp-Source: ABdhPJxmp1oGk9JNU7nyDvSF//S/ryLXg9xMDMIrQHy5S2a4uO+JgKYxt5cKvwDDmcVgwmwcE5nbrg== X-Received: by 2002:adf:a3c2:: with SMTP id m2mr26901930wrb.195.1615805572391; Mon, 15 Mar 2021 03:52:52 -0700 (PDT) Received: from mastodon.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id a12sm17371460wrx.5.2021.03.15.03.52.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 03:52:52 -0700 (PDT) From: Gabriel Ganne To: Bruce Richardson Cc: dev@dpdk.org, olivier.matz@6wind.com, thierry.herbelot@6wind.com Date: Mon, 15 Mar 2021 11:52:42 +0100 Message-Id: <20210315105242.19506-1-gabriel.ganne@6wind.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Subject: [dpdk-dev] [RFC PATCH] meson: remove unnecessary explicit link to libpcap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" libpcap is already found and registered as a dependency by meson, and the dependency is already correctly used in librte_port. This line is just unnecessary. It also has the side effect of messing with the meson link line: dpdk link will be declared twice: manually and then through pkg-config. If you configure meson to prefer static linking over dynamic, this will cause the build to fail on librte_port, since the pcap deps are not yet seen by the linker. Signed-off-by: Gabriel Ganne --- config/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/config/meson.build b/config/meson.build index 0fb7e1b27a0f..3eb90327dfcc 100644 --- a/config/meson.build +++ b/config/meson.build @@ -177,7 +177,6 @@ if not pcap_dep.found() endif if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep) dpdk_conf.set('RTE_PORT_PCAP', 1) - dpdk_extra_ldflags += '-lpcap' endif # for clang 32-bit compiles we need libatomic for 64-bit atomic ops