From patchwork Sun Mar 14 09:54:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wisam Monther X-Patchwork-Id: 89068 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42629A0524; Sun, 14 Mar 2021 10:55:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 80F6B1608CE; Sun, 14 Mar 2021 10:54:52 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2089.outbound.protection.outlook.com [40.107.220.89]) by mails.dpdk.org (Postfix) with ESMTP id 4F2751608A4 for ; Sun, 14 Mar 2021 10:54:50 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C9to6moXhvBgTUWe/xjoyTZ8DZ6MVlSpLFfD4gf4mlNfkLAMnsWui5b8vADIaMuRKamHvDugMphfvaCKhOD5p+Rx7F0NQ1uq3RTOwY8u5bH1NpR8ReJp0aSTpC1+nqRl0fuj34KseTUiNzLexcPAT4iPMzHjzltuM6XvprZUwKRIJX6JwVK24V7yCNNwoZJHvnyDofCHB+DyI2Unr2RZeFBHFATFduRS+Uzac3pau2tRfbHsShZsbhrFVBkC6eWybQbrja/oR2Ss+4P4LLUTnqNRQ76BgFYUdvLsyU1eY80QVswe0YYm1yKJ7tig6Ubv1DykdX78QHmY6gafBvckKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nA3GAZLiB6xpvLCixWLaXPiI2kDFs2JmpRuLoI5rjwc=; b=Irf2grBkyW9Fn/yDtrnJ7Sk56X0YjlSpafKK+Mqge5egFlKn6uptkjAVWo2QaZTe07lN2jGPnSeb56aiSQnnA4FEE/l2jQvVsniJlPY1xzFUQ2UUvPX+ngp6lu8n7pgwRpvDXsP5MTTQtoVJNDt1gXIzGzFhQ5NDAIrGDym+m+MsXH8Ceukwp/8wW4gr+4NBVFmaafKZbRTs5V/oOcx8ntYgBnZcg4VJrYhYRVMIOfgTQjPrvuQvfQGogmjXroB4AcQCbNxlntdnpUngWLpcioha3OonK0zkP7l8CTKX9fs6kEXYp4ZGpa8wUUHQsnTH7jn84RRMhbujQYEy7ZRpgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nA3GAZLiB6xpvLCixWLaXPiI2kDFs2JmpRuLoI5rjwc=; b=hzf4XTQRmZ2wEJS4vcVpX9HfK9DubcHX4xaRe4HFer31uyVS3QKuDNrfZ9k+C5Z8XNGG19T1nepKWFfA49uCUXmjeyLXrQwhc8V4Rklap+0mUM3LVHPCtX0ylieLcS+/IJSN/DzAQxnGJ7CD3lQUeM9LE6Ip/QTQkHFQYjfJxZGZcXUcPkC8kojLmFylGTVjXLx06tk8Z+3o05Ha5bo6ysZbcQsKrD+NehbQR4qnsTZnSxB00xORerKNzL9QgqEPkHOUU5I1R+ana7cxl5I3A7gpZaQbrVgjMCFEI6+3EzJE3NzPqLJfZO+DbTLJPNfX4nTbGAO/9PZB9NKUvKvwRQ== Received: from BN6PR21CA0014.namprd21.prod.outlook.com (2603:10b6:404:8e::24) by MWHPR12MB1231.namprd12.prod.outlook.com (2603:10b6:300:e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31; Sun, 14 Mar 2021 09:54:48 +0000 Received: from BN8NAM11FT059.eop-nam11.prod.protection.outlook.com (2603:10b6:404:8e:cafe::13) by BN6PR21CA0014.outlook.office365.com (2603:10b6:404:8e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.2 via Frontend Transport; Sun, 14 Mar 2021 09:54:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT059.mail.protection.outlook.com (10.13.177.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.3933.31 via Frontend Transport; Sun, 14 Mar 2021 09:54:47 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 14 Mar 2021 09:54:45 +0000 From: Wisam Jaddo To: , , , , CC: Date: Sun, 14 Mar 2021 11:54:23 +0200 Message-ID: <20210314095427.10101-4-wisamm@nvidia.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210314095427.10101-1-wisamm@nvidia.com> References: <20210310135546.8680-2-wisamm@nvidia.com> <20210314095427.10101-1-wisamm@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5c69a135-5de3-4d4f-6dec-08d8e6cf340d X-MS-TrafficTypeDiagnostic: MWHPR12MB1231: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:204; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GGl21YJr6S3oyFpfKKR0cEqt9sdKWXyvXbPkiH+U0VsbB1wml2ZwawWXtnGZYgBDcx0CHSP8mdEZcUK0uVZRU7v5Bc/KNbKK5OYA1nSr5/GQvpUsYjfxSYgCvaIS/EdRonMPLm4tG9dBRRNHYkaOqCuPuCVlQq6dkvVeCng9mamq6jxAhJtGiPTUawo7UgA6109kfcOgjCpBU31ZEMKJ6c9LBZfvIesfXLzdjkapdAQjnyJjVwK7iUtjPGYOHq8Deh3yIKLRdDfmmsHTyeVjiU59uJUTPnSU47k1fXRMsUkUxr9N4Gaae4f+TyabWllYV1+e91mOpiJwdHERkbiZiYyO2PzDTGkSXEeGpFkezFHXi7NTHacxZlBiEbuN1vinP0gCpsFPfrCtOf03g4o0xGlC0AgnnqFSu8gZ7mTizZm2soCLIyclp4kfGRuJsfoNWh2/A7HeGzOc0iRJU/bq6ai8Bj4ywVJURAv7e5445qd18s6by3RraySo6HAT7UYWGqbWyXureawqlrIlBEqvPWYQ2fsZ3B8x2I4NATqdH5+Ok2kNkI4lp2MTJOarNvwDoPdWRWBrbrFM4c32Y4/jMQ/6z68coxwB+o/iQcljbfTNaE0G/acNcQm17r3LnAiGwCYlvlK+d4lESMupyQlBDRGxsmT+xQJWuuxEy/jLdGgGFOQX9DAlrn0/m3QS8YxK X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(376002)(39860400002)(346002)(136003)(46966006)(36840700001)(316002)(70586007)(1076003)(8936002)(36906005)(186003)(2906002)(7696005)(47076005)(16526019)(110136005)(26005)(426003)(478600001)(6286002)(6666004)(5660300002)(336012)(55016002)(4326008)(83380400001)(70206006)(107886003)(7636003)(86362001)(82310400003)(36860700001)(34020700004)(8676002)(36756003)(82740400003)(356005)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2021 09:54:47.7283 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5c69a135-5de3-4d4f-6dec-08d8e6cf340d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT059.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1231 Subject: [dpdk-dev] [PATCH v4 3/7] app/flow-perf: fix naming of CPU used structured data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" create_flow and create_meter are not correct names since those are records that contain creation and deletion, which makes them more of a record for such data. Fixes: d8099d7ecbd0 ("app/flow-perf: split dump functions") Cc: dongzhou@nvidia.com Signed-off-by: Wisam Jaddo Acked-by: Alexander Kozyrev --- app/test-flow-perf/main.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c index 4054178273..01607881df 100644 --- a/app/test-flow-perf/main.c +++ b/app/test-flow-perf/main.c @@ -105,8 +105,8 @@ struct used_cpu_time { struct multi_cores_pool { uint32_t cores_count; uint32_t rules_count; - struct used_cpu_time create_meter; - struct used_cpu_time create_flow; + struct used_cpu_time meters_record; + struct used_cpu_time flows_record; int64_t last_alloc[RTE_MAX_LCORE]; int64_t current_alloc[RTE_MAX_LCORE]; } __rte_cache_aligned; @@ -1013,10 +1013,10 @@ meters_handler(int port_id, uint8_t core_id, uint8_t ops) cpu_time_used, insertion_rate); if (ops == METER_CREATE) - mc_pool.create_meter.insertion[port_id][core_id] + mc_pool.meters_record.insertion[port_id][core_id] = cpu_time_used; else - mc_pool.create_meter.deletion[port_id][core_id] + mc_pool.meters_record.deletion[port_id][core_id] = cpu_time_used; } @@ -1134,7 +1134,7 @@ destroy_flows(int port_id, uint8_t core_id, struct rte_flow **flows_list) printf(":: Port %d :: Core %d :: The time for deleting %d rules is %f seconds\n", port_id, core_id, rules_count_per_core, cpu_time_used); - mc_pool.create_flow.deletion[port_id][core_id] = cpu_time_used; + mc_pool.flows_record.deletion[port_id][core_id] = cpu_time_used; } static struct rte_flow ** @@ -1241,7 +1241,7 @@ insert_flows(int port_id, uint8_t core_id) printf(":: Port %d :: Core %d :: The time for creating %d in rules %f seconds\n", port_id, core_id, rules_count_per_core, cpu_time_used); - mc_pool.create_flow.insertion[port_id][core_id] = cpu_time_used; + mc_pool.flows_record.insertion[port_id][core_id] = cpu_time_used; return flows_list; } @@ -1439,9 +1439,9 @@ run_rte_flow_handler_cores(void *data __rte_unused) RTE_ETH_FOREACH_DEV(port) { if (has_meter()) dump_used_cpu_time("Meters:", - port, &mc_pool.create_meter); + port, &mc_pool.meters_record); dump_used_cpu_time("Flows:", - port, &mc_pool.create_flow); + port, &mc_pool.flows_record); dump_used_mem(port); }