From patchwork Wed Mar 10 13:48:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wisam Monther X-Patchwork-Id: 88864 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2467A0567; Wed, 10 Mar 2021 14:49:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4C3D22A67A; Wed, 10 Mar 2021 14:49:25 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2089.outbound.protection.outlook.com [40.107.244.89]) by mails.dpdk.org (Postfix) with ESMTP id 182EA22A668 for ; Wed, 10 Mar 2021 14:49:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AYDyZUIZhyCqQrni3HJo743pJJBgDAIeU84DJLn4I+VupFHyml+Z+vEi040A1Xb6r8Q+WFv32gBm6UvuUv9nIep0jAHvuTFP2D8eBZJIPiLQjwMOvR4clcw8xPPHRSL4MqNx+gdfTyiUKAxJAp1dVkICCdc2siXE6ioJMglng6rhJ/y0/Fb1aatoLgxuth+PiLEinNYvzwwJHk6XPljTQAayD77gazY3PEnc6brhDiuN2Xg70plwpnQfMuTkzc1ecr9947Lh7smbf6yOLx6GCW9oJp0+kQtgWxyF2SqPi5AY2TY8FdI0lfat5nlIiR9+h7U0H1N4TGTUV3x/y2mEYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VEXot2nBvO2wWAZRVzmX0DRD63UrL0EkDxrULp8ehUg=; b=VFf1ps1iskkBj/Zd762ILhbRcwa/YMcE9rcJyu5b9p6yNFCsuNA4di94M+fMsAX/7H4QjzqigKyfauqdBNnOWDZj9tC1tOcawW9axT/WsFF/c5nuHiTP90HSyhvwSxph5H+lAqtb0jXo/rQLVPvpA+WJL0+dEZtjG3Ae5ctoUxvMcm0zQVIjdhv8euZ8R4DJtvI853CR7eT7nxhd+urZfqhTI3wpq4MvO1djWBV68r5yX7tMseciVCazIF2G/bfEEc+8aVhgp9eKKIsm8hSUaRS1u3rnwlxMiAPsYTMhQfEfvvYJ+o0HRf4UWtGQZxZnUIgZbIfrVkJRH2VZWCrc4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VEXot2nBvO2wWAZRVzmX0DRD63UrL0EkDxrULp8ehUg=; b=N5S+JTB2G6/XV67PDyTerU96q6VokWZJfjE18ng7fVacIc/co7oMCV7xZCwCxIV/BYJJX6pAksNXpXyDxUg09x9ioaoC98ePiH2ESuHHOjh68zlhG4ejEXGwRQXuj2a3dzZu7tDwa0GksxFy8H8ZlGIO3YUassO4Deh1KAtwD7CgpjZ1g+Um4S26URqInMRRhzPu+opz/ZvsLHFbo/YtOfUQFPb/oMftIUmRFhpflVzsLcqxCqdk7LkeATJpg7FMPgPg4nGhAV/DEvW9v5S3URmhNaGbS+BTh5HxxHbE4R1NrS6yUfe9DAo+6vj+Bi5tbN+bEU7wZY/8RySIxR/OfQ== Received: from MWHPR18CA0027.namprd18.prod.outlook.com (2603:10b6:320:31::13) by DM5PR12MB1418.namprd12.prod.outlook.com (2603:10b6:3:7a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 10 Mar 2021 13:49:22 +0000 Received: from CO1NAM11FT068.eop-nam11.prod.protection.outlook.com (2603:10b6:320:31:cafe::c9) by MWHPR18CA0027.outlook.office365.com (2603:10b6:320:31::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 10 Mar 2021 13:49:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT068.mail.protection.outlook.com (10.13.175.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.3890.19 via Frontend Transport; Wed, 10 Mar 2021 13:49:21 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 10 Mar 2021 13:49:19 +0000 From: Wisam Jaddo To: , , , , CC: Date: Wed, 10 Mar 2021 15:48:54 +0200 Message-ID: <20210310134858.8104-4-wisamm@nvidia.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210310134858.8104-1-wisamm@nvidia.com> References: <20210307091202.586-2-wisamm@nvidia.com> <20210310134858.8104-1-wisamm@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fe88b84e-db60-4477-e17f-08d8e3cb4f23 X-MS-TrafficTypeDiagnostic: DM5PR12MB1418: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:204; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YCVN+Hjua4avKrd5FeZwh134xpuSkns3YpNAGTXxwKCKXny/joDXaNzj4MuHePKF1skTW09Or+v0cRz9pQBQi7eFvUPqqN4K472STWyl5wz72hnGdQNBtS2gvMkLLD8+VSvt1/pHrfdFx7iZb/Aux7Fqw1Wq7LGW528yaDe2g57h6ppFDnnKG8/DsNepzO0iIIx/clwJbNktsPLD8uOwH7UsBmM8QoQrYRDfigPKruhpZMAQ/xOcnJrjnYK4aohxytDkA2uo1N6Qv3hpgxYn91LJ2ZhWjjfvCIGKQ0YZkSwRq9fGCFz5mP9iaHi0D9MgkyK4iSVwm/OwqA9uYdiMuOAZXFTRgWlqzHTZtAIMSkpKL8hSXOHi7hbY3elYbJQ1eCK86KmXFS5vq6WuMQKvl3f2rrWaAJMgEmz8kc+4HaXLHDbwugQ2KJ5HmvJ7vZrKIi3v4Sdea/+wV/PDxjauROYqZTzBhJhhPT/djZv475BN0AUuE34qT5efRMKBOqLxzLEVY+dvU+GIjr5jy4bqQsPOdu409pLP1LRFV1+bE/itMAzxPn6lQuzHJubhoLdXm8waWX7dcx/p1JcJVLFGEP+5gd5r5MF8ugPh8HCZyi8Q3AlafI4njK7mQwBprCVqqG9S8CrhQeeixlviOeiuLBq8u6JGnJ1TultkVCx224ys9qBk9TXN/jcdpnBqCdNt X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(136003)(39860400002)(396003)(376002)(36840700001)(46966006)(26005)(82310400003)(36906005)(36756003)(36860700001)(70586007)(6286002)(107886003)(7636003)(82740400003)(86362001)(34020700004)(110136005)(70206006)(16526019)(83380400001)(186003)(478600001)(4326008)(336012)(7696005)(47076005)(2616005)(316002)(426003)(5660300002)(8676002)(2906002)(356005)(1076003)(6666004)(8936002)(55016002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2021 13:49:21.7463 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fe88b84e-db60-4477-e17f-08d8e3cb4f23 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT068.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1418 Subject: [dpdk-dev] [PATCH v2 3/7] app/flow-perf: fix naming of CPU used structured data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" create_flow and create_meter are not correct names since those are records that contain creation and deletion, which makes them more of a record for such data. Fixes: d8099d7ecbd0 ("app/flow-perf: split dump functions") Cc: dongzhou@nvidia.com Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c index 4054178273..01607881df 100644 --- a/app/test-flow-perf/main.c +++ b/app/test-flow-perf/main.c @@ -105,8 +105,8 @@ struct used_cpu_time { struct multi_cores_pool { uint32_t cores_count; uint32_t rules_count; - struct used_cpu_time create_meter; - struct used_cpu_time create_flow; + struct used_cpu_time meters_record; + struct used_cpu_time flows_record; int64_t last_alloc[RTE_MAX_LCORE]; int64_t current_alloc[RTE_MAX_LCORE]; } __rte_cache_aligned; @@ -1013,10 +1013,10 @@ meters_handler(int port_id, uint8_t core_id, uint8_t ops) cpu_time_used, insertion_rate); if (ops == METER_CREATE) - mc_pool.create_meter.insertion[port_id][core_id] + mc_pool.meters_record.insertion[port_id][core_id] = cpu_time_used; else - mc_pool.create_meter.deletion[port_id][core_id] + mc_pool.meters_record.deletion[port_id][core_id] = cpu_time_used; } @@ -1134,7 +1134,7 @@ destroy_flows(int port_id, uint8_t core_id, struct rte_flow **flows_list) printf(":: Port %d :: Core %d :: The time for deleting %d rules is %f seconds\n", port_id, core_id, rules_count_per_core, cpu_time_used); - mc_pool.create_flow.deletion[port_id][core_id] = cpu_time_used; + mc_pool.flows_record.deletion[port_id][core_id] = cpu_time_used; } static struct rte_flow ** @@ -1241,7 +1241,7 @@ insert_flows(int port_id, uint8_t core_id) printf(":: Port %d :: Core %d :: The time for creating %d in rules %f seconds\n", port_id, core_id, rules_count_per_core, cpu_time_used); - mc_pool.create_flow.insertion[port_id][core_id] = cpu_time_used; + mc_pool.flows_record.insertion[port_id][core_id] = cpu_time_used; return flows_list; } @@ -1439,9 +1439,9 @@ run_rte_flow_handler_cores(void *data __rte_unused) RTE_ETH_FOREACH_DEV(port) { if (has_meter()) dump_used_cpu_time("Meters:", - port, &mc_pool.create_meter); + port, &mc_pool.meters_record); dump_used_cpu_time("Flows:", - port, &mc_pool.create_flow); + port, &mc_pool.flows_record); dump_used_mem(port); }