From patchwork Tue Mar 9 08:43:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Wang X-Patchwork-Id: 88737 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74136A0567; Tue, 9 Mar 2021 10:03:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B1D922A443; Tue, 9 Mar 2021 10:03:29 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 28CA04069D; Tue, 9 Mar 2021 10:03:28 +0100 (CET) IronPort-SDR: arNMNRVnsfhaf2lKW1cWnXym8WMknkFj1GCoYvTxb19OGSPpPHDYSyuthVQQkCEtdge5xm2puj Qd/vaytCtgLA== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="273221668" X-IronPort-AV: E=Sophos;i="5.81,234,1610438400"; d="scan'208";a="273221668" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2021 01:03:16 -0800 IronPort-SDR: /7jkQmASo+BdIQ7zIGn/wXtg9xahiFlmpqlNBDLKUkMXUYpHRZ3MAdMI2CiwUkchCfPWF1YLJ3 4u+59UEdhZ0w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,234,1610438400"; d="scan'208";a="588365735" Received: from dpdk-xiao1.sh.intel.com ([10.67.110.193]) by orsmga005.jf.intel.com with ESMTP; 09 Mar 2021 01:03:14 -0800 From: Xiao Wang To: chenbo.xia@intel.com Cc: dev@dpdk.org, Xiao Wang , stable@dpdk.org Date: Tue, 9 Mar 2021 16:43:15 +0800 Message-Id: <20210309084315.12276-1-xiao.w.wang@intel.com> X-Mailer: git-send-email 2.15.1 Subject: [dpdk-dev] [PATCH] vdpa/ifc: check return value for PCI config read X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The return value of rte_pci_read_config should be checked. Coverity issue: 302860 Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") Cc: stable@dpdk.org Signed-off-by: Xiao Wang Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/base/ifcvf.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/ifc/base/ifcvf.c b/drivers/vdpa/ifc/base/ifcvf.c index 3c0b2dff66..721cb1da8a 100644 --- a/drivers/vdpa/ifc/base/ifcvf.c +++ b/drivers/vdpa/ifc/base/ifcvf.c @@ -65,8 +65,13 @@ ifcvf_init_hw(struct ifcvf_hw *hw, PCI_DEV *dev) hw->common_cfg = get_cap_addr(hw, &cap); break; case IFCVF_PCI_CAP_NOTIFY_CFG: - PCI_READ_CONFIG_DWORD(dev, &hw->notify_off_multiplier, + ret = PCI_READ_CONFIG_DWORD(dev, + &hw->notify_off_multiplier, pos + sizeof(cap)); + if (ret < 0) { + DEBUGOUT("failed to read notify_off_multiplier\n"); + return -1; + } hw->notify_base = get_cap_addr(hw, &cap); hw->notify_region = cap.bar; break;