Message ID | 20210301075714.1636918-1-qi.z.zhang@intel.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Qi Zhang |
Headers | show |
Series | net/iavf: fix TSO max segment size | expand |
Context | Check | Description |
---|---|---|
ci/intel-Testing | success | Testing PASS |
ci/iol-testing | success | Testing PASS |
ci/iol-abi-testing | success | Testing PASS |
ci/iol-intel-Performance | success | Performance Testing PASS |
ci/iol-mellanox-Functional | success | Functional Testing PASS |
ci/iol-mellanox-Performance | success | Performance Testing PASS |
ci/github-robot | success | github build: passed |
ci/travis-robot | fail | travis build: failed |
ci/Intel-compilation | success | Compilation OK |
ci/checkpatch | success | coding style OK |
> -----Original Message----- > From: Zhang, Qi Z <qi.z.zhang@intel.com> > Sent: Monday, March 1, 2021 3:57 PM > To: Wu, Jingjing <jingjing.wu@intel.com> > Cc: Anantharam, Arjun <arjun.anantharam@intel.com>; Miskell, Timothy > <timothy.miskell@intel.com>; Xing, Beilei <beilei.xing@intel.com>; > dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org > Subject: [PATCH] net/iavf: fix TSO max segment size > > According to Intel® AVF spec > (https://www.intel.com/content/dam/ > www/public/us/en/documents/product-specifications/ > ethernet-adaptive-virtual-function-hardware-spec.pdf) > section 2.2.2.3: > The max segment size(MSS) of TSO should not be set lower than 88. > > Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx") > Cc: stable@dpdk.org > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> > --- > drivers/net/iavf/iavf_rxtx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h index > 922ddadad1..69979971fd 100644 > --- a/drivers/net/iavf/iavf_rxtx.h > +++ b/drivers/net/iavf/iavf_rxtx.h > @@ -34,7 +34,7 @@ > #define DEFAULT_TX_RS_THRESH 32 > #define DEFAULT_TX_FREE_THRESH 32 > > -#define IAVF_MIN_TSO_MSS 256 > +#define IAVF_MIN_TSO_MSS 88 > #define IAVF_MAX_TSO_MSS 9668 > #define IAVF_TSO_MAX_SEG UINT8_MAX > #define IAVF_TX_MAX_MTU_SEG 8 > -- > 2.26.2 Acked-by: Beilei Xing <beilei.xing@intel.com>
> -----Original Message----- > From: Xing, Beilei <beilei.xing@intel.com> > Sent: Friday, March 26, 2021 9:28 AM > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing <jingjing.wu@intel.com> > Cc: Anantharam, Arjun <arjun.anantharam@intel.com>; Miskell, Timothy > <timothy.miskell@intel.com>; dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH] net/iavf: fix TSO max segment size > > > > > -----Original Message----- > > From: Zhang, Qi Z <qi.z.zhang@intel.com> > > Sent: Monday, March 1, 2021 3:57 PM > > To: Wu, Jingjing <jingjing.wu@intel.com> > > Cc: Anantharam, Arjun <arjun.anantharam@intel.com>; Miskell, Timothy > > <timothy.miskell@intel.com>; Xing, Beilei <beilei.xing@intel.com>; > > dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org > > Subject: [PATCH] net/iavf: fix TSO max segment size > > > > According to Intel® AVF spec > > (https://www.intel.com/content/dam/ > > www/public/us/en/documents/product-specifications/ > > ethernet-adaptive-virtual-function-hardware-spec.pdf) > > section 2.2.2.3: > > The max segment size(MSS) of TSO should not be set lower than 88. > > > > Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx") > > Cc: stable@dpdk.org > > > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> > > --- > > drivers/net/iavf/iavf_rxtx.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/iavf/iavf_rxtx.h > > b/drivers/net/iavf/iavf_rxtx.h index 922ddadad1..69979971fd 100644 > > --- a/drivers/net/iavf/iavf_rxtx.h > > +++ b/drivers/net/iavf/iavf_rxtx.h > > @@ -34,7 +34,7 @@ > > #define DEFAULT_TX_RS_THRESH 32 > > #define DEFAULT_TX_FREE_THRESH 32 > > > > -#define IAVF_MIN_TSO_MSS 256 > > +#define IAVF_MIN_TSO_MSS 88 > > #define IAVF_MAX_TSO_MSS 9668 > > #define IAVF_TSO_MAX_SEG UINT8_MAX > > #define IAVF_TX_MAX_MTU_SEG 8 > > -- > > 2.26.2 > > Acked-by: Beilei Xing <beilei.xing@intel.com> > Applied to dpdk-next-net-intel. Thanks Qi
diff --git a/drivers/net/iavf/iavf_rxtx.h b/drivers/net/iavf/iavf_rxtx.h index 922ddadad1..69979971fd 100644 --- a/drivers/net/iavf/iavf_rxtx.h +++ b/drivers/net/iavf/iavf_rxtx.h @@ -34,7 +34,7 @@ #define DEFAULT_TX_RS_THRESH 32 #define DEFAULT_TX_FREE_THRESH 32 -#define IAVF_MIN_TSO_MSS 256 +#define IAVF_MIN_TSO_MSS 88 #define IAVF_MAX_TSO_MSS 9668 #define IAVF_TSO_MAX_SEG UINT8_MAX #define IAVF_TX_MAX_MTU_SEG 8
According to Intel® AVF spec (https://www.intel.com/content/dam/ www/public/us/en/documents/product-specifications/ ethernet-adaptive-virtual-function-hardware-spec.pdf) section 2.2.2.3: The max segment size(MSS) of TSO should not be set lower than 88. Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx") Cc: stable@dpdk.org Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> --- drivers/net/iavf/iavf_rxtx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)