diff mbox series

[v2] power: remove duplicated symbols from map file

Message ID 20210225105449.4111878-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers show
Series [v2] power: remove duplicated symbols from map file | expand

Checks

Context Check Description
ci/iol-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-mellanox-Functional fail Functional Testing issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/github-robot success github build: passed
ci/travis-robot fail travis build: failed
ci/intel-Testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Ferruh Yigit Feb. 25, 2021, 10:54 a.m. UTC
This is causing build error, like:
https://travis-ci.com/github/ovsrobot/dpdk/jobs/482121104

Also '@internal' marker removed from doxygen comment, since public API
should not be internal.
Experimental tag removed from 'rte_power_guest_channel_send_msg()'

Fixes: 4d3892dcd77b ("power: make channel message functions public")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: Aaron Conole <aconole@redhat.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>
Cc: David Marchand <david.marchand@redhat.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>

v2:
* Keep old symbols, remove the ones added in 21.02
---
 lib/librte_power/rte_power_guest_channel.h | 8 --------
 lib/librte_power/version.map               | 2 --
 2 files changed, 10 deletions(-)

Comments

David Marchand Feb. 25, 2021, 2:38 p.m. UTC | #1
On Thu, Feb 25, 2021 at 11:55 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> This is causing build error, like:
> https://travis-ci.com/github/ovsrobot/dpdk/jobs/482121104
>
> Also '@internal' marker removed from doxygen comment, since public API
> should not be internal.
> Experimental tag removed from 'rte_power_guest_channel_send_msg()'
>
> Fixes: 4d3892dcd77b ("power: make channel message functions public")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Reviewed-by: David Marchand <david.marchand@redhat.com>
David Marchand March 2, 2021, 12:42 p.m. UTC | #2
On Thu, Feb 25, 2021 at 3:38 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Thu, Feb 25, 2021 at 11:55 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >
> > This is causing build error, like:
> > https://travis-ci.com/github/ovsrobot/dpdk/jobs/482121104
> >
> > Also '@internal' marker removed from doxygen comment, since public API
> > should not be internal.
> > Experimental tag removed from 'rte_power_guest_channel_send_msg()'
> >
> > Fixes: 4d3892dcd77b ("power: make channel message functions public")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied, thanks Ferruh.

Hopefully, with the update to Graviton2, Travis jobs will run fine now.
diff mbox series

Patch

diff --git a/lib/librte_power/rte_power_guest_channel.h b/lib/librte_power/rte_power_guest_channel.h
index ed4fbfdcd38a..b5de1bd24318 100644
--- a/lib/librte_power/rte_power_guest_channel.h
+++ b/lib/librte_power/rte_power_guest_channel.h
@@ -119,11 +119,6 @@  struct rte_power_channel_packet_caps_list {
 };
 
 /**
- * @internal
- *
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Send a message contained in pkt over the Virtio-Serial to the host endpoint.
  *
  * @param pkt
@@ -136,13 +131,10 @@  struct rte_power_channel_packet_caps_list {
  *  - 0 on success.
  *  - Negative on error.
  */
-__rte_experimental
 int rte_power_guest_channel_send_msg(struct rte_power_channel_packet *pkt,
 			unsigned int lcore_id);
 
 /**
- * @internal
- *
  * @warning
  * @b EXPERIMENTAL: this API may change without prior notice.
  *
diff --git a/lib/librte_power/version.map b/lib/librte_power/version.map
index 3ba9390241d2..b004e3e4a9c1 100644
--- a/lib/librte_power/version.map
+++ b/lib/librte_power/version.map
@@ -38,6 +38,4 @@  EXPERIMENTAL {
 	# added in 21.02
 	rte_power_ethdev_pmgmt_queue_disable;
 	rte_power_ethdev_pmgmt_queue_enable;
-	rte_power_guest_channel_receive_msg;
-	rte_power_guest_channel_send_msg;
 };