diff mbox series

net/mlx5: fix TCP flag field modification

Message ID 20210205030304.29477-1-akozyrev@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers show
Series net/mlx5: fix TCP flag field modification | expand

Checks

Context Check Description
ci/iol-testing warning Testing issues
ci/intel-Testing success Testing PASS
ci/travis-robot warning Travis build: failed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Alexander Kozyrev Feb. 5, 2021, 3:03 a.m. UTC
Wrong modification field ID is used for TCP flags: the inner
TCP flag field is changing instead of the outermost one.
Use the proper field ID to match the expectations.

Fixes: 641dbe4fb0 ("net/mlx5: support modify field flow action")
Cc: stable@dpdk.org

Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Viacheslav Ovsiienko Feb. 5, 2021, 4:27 p.m. UTC | #1
> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Friday, February 5, 2021 5:03
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>;
> Ori Kam <orika@nvidia.com>
> Subject: [PATCH] net/mlx5: fix TCP flag field modification
> 
> Wrong modification field ID is used for TCP flags: the inner TCP flag field is
> changing instead of the outermost one.
> Use the proper field ID to match the expectations.
> 
> Fixes: 641dbe4fb0 ("net/mlx5: support modify field flow action")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

> ---
>  drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c index 76696b7b62..a44291a3c9 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -1653,7 +1653,7 @@ mlx5_flow_field_id_to_modify_info
>  		break;
>  	case RTE_FLOW_FIELD_TCP_FLAGS:
>  		info[idx] = (struct field_modify_info){1, 0,
> -					MLX5_MODI_IN_TCP_FLAGS};
> +					MLX5_MODI_OUT_TCP_FLAGS};
>  		if (mask) {
>  			mask[idx] = 0x0000003f;
>  			if (width < 6)
> --
> 2.24.1
Raslan Darawsheh Feb. 21, 2021, 9:32 a.m. UTC | #2
Hi,

> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Friday, February 5, 2021 5:03 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>;
> Ori Kam <orika@nvidia.com>
> Subject: [PATCH] net/mlx5: fix TCP flag field modification
> 
> Wrong modification field ID is used for TCP flags: the inner
> TCP flag field is changing instead of the outermost one.
> Use the proper field ID to match the expectations.
> 
> Fixes: 641dbe4fb0 ("net/mlx5: support modify field flow action")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 76696b7b62..a44291a3c9 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -1653,7 +1653,7 @@  mlx5_flow_field_id_to_modify_info
 		break;
 	case RTE_FLOW_FIELD_TCP_FLAGS:
 		info[idx] = (struct field_modify_info){1, 0,
-					MLX5_MODI_IN_TCP_FLAGS};
+					MLX5_MODI_OUT_TCP_FLAGS};
 		if (mask) {
 			mask[idx] = 0x0000003f;
 			if (width < 6)