From patchwork Thu Feb 4 19:58:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Boyer X-Patchwork-Id: 87769 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9342DA0524; Thu, 4 Feb 2021 21:01:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0DAC240848; Thu, 4 Feb 2021 20:59:48 +0100 (CET) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id E2414240846 for ; Thu, 4 Feb 2021 20:59:47 +0100 (CET) Received: by mail-pj1-f53.google.com with SMTP id fa16so1884835pjb.1 for ; Thu, 04 Feb 2021 11:59:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DvgvfWSZ5T++gECStxr6V74FNWCdtej6oqiRpIiOyxI=; b=jZn4UdJd5E38tHPxfq4ED6rEqpn3zHXfLzi1cyPVqp2DdvQ+ZWRBWcbPompUNSJhIm mI6D8gmtKiDgQOsMAFqdx5B44H9OO7hf0kmJ8X3uFhzHUuvVoFerfeUrRvexxeb/Iah3 02GEsAdmt5HA25WL9yGkd4I8jIjVOJkUyUXTnpq6panY7QF+WtTdu/Xm90sKGqHPCvXS kkU+5Yk2HmFi1KPZZXAR0FYzT6A70yuq9+b8x82GpH3I0aTGgwCtYKXFcBD/RHUXYP5V Y+hd2unFwoXLoSrdPmMAjHwvglZXVjPDrYg72puUTPe/dP3QkmyJCpx28iUdJwbkI2sX GJJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DvgvfWSZ5T++gECStxr6V74FNWCdtej6oqiRpIiOyxI=; b=joR6FemsIwSoFUdYM5HYRtl8JVwMrcKPE/p90mOzoh/A6HCBnbHJcHmH8GF2kvDdIa tITbmHJyrFWRacAqiBoPAFzXh81WKANIGJBzWKO76BskjxqnEAmh2wGdqtMRXR/A9opt u3UfnlMQDBDnPlam+5BLX0zmRP+QvQ2ve7PiPoxkJbBGtbqojLclXgmfXeE2fepPaNG6 BNoU7Rm57qNjI0qVXQRPMZCbSvGFooiP3Pro6w6jlLggyJpQ8YDDPFTXfJ5XaeFc1I3m WbDrcoEXlDGR1bEKIwxTR0rZDsR8iuFogc6sxknSQoavk5zsB7mP97cmo4HNHgfI53aZ oq1Q== X-Gm-Message-State: AOAM532pvp0fywfnCoPXi4kXDNgCqiR/DhoM2Su/H8UvS1UrOnTHVtJE dJSPzkRneUdeazSzQYxs6ewzkgp179f6RQ== X-Google-Smtp-Source: ABdhPJxEONqgEuktLAEs4qP0TpEq1xIa1Tb5hRoSJ/EIJ00Mkd1JUc2lXr3hJF9UXyHMYv9uTAnc5A== X-Received: by 2002:a17:90a:ab17:: with SMTP id m23mr621252pjq.0.1612468786953; Thu, 04 Feb 2021 11:59:46 -0800 (PST) Received: from driver-dev1.pensando.io ([12.226.153.42]) by smtp.gmail.com with ESMTPSA id r14sm7757915pgi.27.2021.02.04.11.59.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 11:59:46 -0800 (PST) From: Andrew Boyer To: dev@dpdk.org Cc: Alfredo Cardigliano , Andrew Boyer , stable@dpdk.org Date: Thu, 4 Feb 2021 11:58:53 -0800 Message-Id: <20210204195853.13411-15-aboyer@pensando.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210204195853.13411-1-aboyer@pensando.io> References: <20210204195853.13411-1-aboyer@pensando.io> Subject: [dpdk-dev] [PATCH 14/14] net/ionic: fix code around lif init devcmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The completion type was wrong. Don't check the completion if the wait timed out. Fixes: 669c8de67c88 ("net/ionic: support basic LIF") Cc: cardigliano@ntop.org Cc: stable@dpdk.org Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index b8023e0632..cd220abee2 100644 --- a/drivers/net/ionic/ionic_lif.c +++ b/drivers/net/ionic/ionic_lif.c @@ -1605,17 +1605,18 @@ int ionic_lif_init(struct ionic_lif *lif) { struct ionic_dev *idev = &lif->adapter->idev; - struct ionic_q_init_comp comp; + struct ionic_lif_init_comp comp; int err; memset(&lif->stats_base, 0, sizeof(lif->stats_base)); ionic_dev_cmd_lif_init(idev, lif->info_pa); err = ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT); - ionic_dev_cmd_comp(idev, &comp); if (err) return err; + ionic_dev_cmd_comp(idev, &comp); + lif->hw_index = rte_cpu_to_le_16(comp.hw_index); err = ionic_lif_adminq_init(lif);