diff mbox series

[v2,2/2] builtools: remove build flag for header includes check

Message ID 20210204100520.15414-2-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series mbuf: remove unneeded EAL header include |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

David Marchand Feb. 4, 2021, 10:05 a.m. UTC 
  Previous patch just removes the last case of direct inclusion of the
generic/ headers.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 buildtools/chkincs/meson.build | 1 -
 1 file changed, 1 deletion(-)

Comments

Bruce Richardson Feb. 4, 2021, 10:26 a.m. UTC | #1 
On Thu, Feb 04, 2021 at 11:05:20AM +0100, David Marchand wrote:
> Previous patch just removes the last case of direct inclusion of the
> generic/ headers.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thomas Monjalon Feb. 5, 2021, 6:48 p.m. UTC | #2 
04/02/2021 11:26, Bruce Richardson:
> On Thu, Feb 04, 2021 at 11:05:20AM +0100, David Marchand wrote:
> > Previous patch just removes the last case of direct inclusion of the
> > generic/ headers.
> > 
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

I think this patch is better understood (in git history I mean)
if squashed with the previous one.
Removing this flag is the direct consequence of removing the include in mbuf.

Squashed and applied, thanks.
diff mbox series

Patch

diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build
index f345e87551..f28cfd3cd4 100644
--- a/buildtools/chkincs/meson.build
+++ b/buildtools/chkincs/meson.build
@@ -17,7 +17,6 @@  gen_c_files = generator(gen_c_file_for_header,
 	arguments: ['@INPUT@', '@OUTPUT@'])
 
 cflags = machine_args
-cflags += '-Wno-unused-function' # needed if we include generic headers
 cflags += '-DALLOW_EXPERIMENTAL_API'
 
 sources = files('main.c')