diff mbox series

[v2] net/ice: drain out DCF AdminQ command queue

Message ID 20210121142316.84087-1-haiyue.wang@intel.com (mailing list archive)
State Superseded, archived
Headers show
Series [v2] net/ice: drain out DCF AdminQ command queue | expand

Checks

Context Check Description
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch warning coding style issues

Commit Message

Wang, Haiyue Jan. 21, 2021, 2:23 p.m. UTC
The virtchnl command message response is handled by matching the opcode
only for limitation.

The DCF AdminQ command with buffer data needs two virtchnl commands, one
is to handle the AdminQ header, the other is to handle AdminQ buffer. If
the AdminQ header command gets the failure response, the AdminQ buffer
command needs to wait for the buffer message response until timeout to
drain out the virtchnl command queue, since both of them are sent to PF,
the PF will handle them one by one, and send back the response. If not,
it will cause the next AdminQ command failure with the stall response.

Fixes: daa714d55c72 ("net/ice: handle AdminQ command by DCF")
Cc: stable@dpdk.org

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
v2: Fix the commit message typo : 'matchiing' should be 'matching'
---
 drivers/net/ice/ice_dcf.c | 1 -
 1 file changed, 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c
index 4a9af3292c..a211797d9e 100644
--- a/drivers/net/ice/ice_dcf.c
+++ b/drivers/net/ice/ice_dcf.c
@@ -506,7 +506,6 @@  ice_dcf_send_aq_cmd(void *dcf_hw, struct ice_aq_desc *desc,
 
 	do {
 		if ((!desc_cmd.pending && !buff_cmd.pending) ||
-		    (!desc_cmd.pending && desc_cmd.v_ret != IAVF_SUCCESS) ||
 		    (!buff_cmd.pending && buff_cmd.v_ret != IAVF_SUCCESS))
 			break;