From patchwork Thu Jan 21 07:26:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ding, Xuan" X-Patchwork-Id: 87026 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DBBCA09E4; Thu, 21 Jan 2021 08:27:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77657140ECB; Thu, 21 Jan 2021 08:27:22 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 8028B140EC4; Thu, 21 Jan 2021 08:27:20 +0100 (CET) IronPort-SDR: SAzCPX1fnSFLuINQGAfBwMyIQ1usiHh3qI+VTpB+AI+dnzBHI5YyHXkKL5sJJlPKfyMRSbbRnu l2WjcXNPLubg== X-IronPort-AV: E=McAfee;i="6000,8403,9870"; a="176658561" X-IronPort-AV: E=Sophos;i="5.79,363,1602572400"; d="scan'208";a="176658561" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 23:27:19 -0800 IronPort-SDR: pTgZrUH3Y3KP/JKa8HlXTUvlPpA3O8Z3Kxd4uM2OkII5iZqU4/Cs0+mz5zw9LvaEgYL9797WJp 7++vQthCUDWg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,363,1602572400"; d="scan'208";a="356358061" Received: from dpdk-xuanding-dev2.sh.intel.com ([10.67.119.124]) by fmsmga008.fm.intel.com with ESMTP; 20 Jan 2021 23:27:18 -0800 From: Xuan Ding To: qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, Xuan Ding , stable@dpdk.org Date: Thu, 21 Jan 2021 07:26:57 +0000 Message-Id: <20210121072657.17823-1-xuan.ding@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] net/ice: fix symmetric rule creating X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Only allow to create symmetric rule for L3/L4. Fixes: 38d632cbdc88("net/ice: refactor PF RSS") Cc: stable@dpdk.org Signed-off-by: Xuan Ding Acked-by: Qi Zhang --- drivers/net/ice/ice_hash.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index 2d23c8dd50..aee4761625 100644 --- a/drivers/net/ice/ice_hash.c +++ b/drivers/net/ice/ice_hash.c @@ -868,6 +868,13 @@ ice_any_invalid_rss_type(enum rte_eth_hash_function rss_func, if (rss_type & (ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY | ETH_RSS_L4_SRC_ONLY | ETH_RSS_L4_DST_ONLY)) return true; + + if (!(rss_type & + (ETH_RSS_IPV4 | ETH_RSS_IPV6 | + ETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_NONFRAG_IPV6_UDP | + ETH_RSS_NONFRAG_IPV4_TCP | ETH_RSS_NONFRAG_IPV6_TCP | + ETH_RSS_NONFRAG_IPV4_SCTP | ETH_RSS_NONFRAG_IPV6_SCTP))) + return true; } /* check invalid combination */