From patchwork Thu Jan 21 07:16:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 87025 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE6B3A09E4; Thu, 21 Jan 2021 08:17:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4A55140EAC; Thu, 21 Jan 2021 08:17:02 +0100 (CET) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id 81D30140EA9 for ; Thu, 21 Jan 2021 08:17:01 +0100 (CET) Received: by mail-pf1-f177.google.com with SMTP id m6so992850pfk.1 for ; Wed, 20 Jan 2021 23:17:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=chnSbtYFCQOUZraHlm9E2iRtlk+HcBLwO4rnQM/rQqk=; b=bMZdtXGvPPL9UOyyAQpGG5jySocicFc9qsHruJ2iGXdSHxKQBAGkXc7KJg7ihudm67 McuFoZSs03ujZNqGxvlTBXkRw5imZ6NMnXSklHLhTFVcyyDg2yFLuhbRdjs3L9sPBwDe MyJzytCDm3tAoiOs5Z7uP6a1H2Mh/g8VjCMdq5mRGduMnxmM27QfbLYdHeZe+4rhLj/T o7GFO6ueU3mvb1cJ3R1sAGhmTlbldy+9i7NBXH+Pkg5gCrNLgk+CCZGpVHSQImD5qaA8 Z+Sm4+RricRK05iwD5jgEzzmAbhrtpuZjzgQe+gXPJP7OWSn0GlufhuCz6jNkG528jan MyAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=chnSbtYFCQOUZraHlm9E2iRtlk+HcBLwO4rnQM/rQqk=; b=dhW9Yqgdzklt9lONI2MpiiZksPWjcQ7PZ4nuitKd9QmyLo5qRoCHn/p9jgWX2xmODH TstKK8iBWcki0kopbirERN+AvBMPunHWAVUrgFWZt26NZXTkbZ1k0fsKb8KZ1yKfOLUf dKto14qiYNmDLOesQ2e3gIfhPLjzMZfGeW9R/LVSGhCaV391RDKufHiBuTFiQWs5yMvr RCWpresfX9Tgv8fnmIqyXnoKAIm1ZeR42BIaNFYuwoW6qoRyJRj5O5St//7x3/ABtMZo UF8LlGGoJNgKFN2rVs2L1Rx7MwtHkymOH1CsPa/WPl3qrOewiweAkSPkOpF3Im2rhAG9 DVGw== X-Gm-Message-State: AOAM5338nrZOqv8iHntd7fX/1rdU0Tu8txPIWMDJj7s6qYEtdlSwgHM4 xZWuMG2mPvV5jMNVa8fc0fXQvpv6XqSseQ== X-Google-Smtp-Source: ABdhPJx63VpwjVFQjiR10PrrxKwa8qcBK0PnsAE2sRqNppksRhTrLQLGRYSm/w5Llv9RLxxJuRDIpQ== X-Received: by 2002:a63:cc05:: with SMTP id x5mr13065576pgf.254.1611213420284; Wed, 20 Jan 2021 23:17:00 -0800 (PST) Received: from localhost.localdomain ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id u1sm4473406pjr.51.2021.01.20.23.16.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jan 2021 23:16:59 -0800 (PST) From: Ajit Khaparde X-Google-Original-From: Ajit Khaparde To: dev@dpdk.org Cc: Somnath Kotur Date: Wed, 20 Jan 2021 23:16:56 -0800 Message-Id: <20210121071656.32879-1-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20210114022716.7999-1-ajit.khaparde@broadcom.com> References: <20210114022716.7999-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3] net/bnxt: fix lock handling in stop and close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Somnath Kotur err_recovery_lock needs to be released before returning in stop and close_op if FW_RESET flag is set. Fixes: dd3613560573 ("net/bnxt: check chip reset in dev stop and close") Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- v1->v2: rebased to latest dpdk-next-net and updated commit log. v2->v3: rebased to latest dpdk-next-net. --- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index f439aeee4..89e42ef14 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1374,6 +1374,7 @@ static int bnxt_dev_stop_op(struct rte_eth_dev *eth_dev) if (bp->flags & BNXT_FLAG_FW_RESET) { PMD_DRV_LOG(ERR, "Adapter recovering from error..Please retry\n"); + pthread_mutex_unlock(&bp->err_recovery_lock); return -EAGAIN; } pthread_mutex_unlock(&bp->err_recovery_lock); @@ -1497,6 +1498,7 @@ static int bnxt_dev_close_op(struct rte_eth_dev *eth_dev) if (bp->flags & BNXT_FLAG_FW_RESET) { PMD_DRV_LOG(ERR, "Adapter recovering from error...Please retry\n"); + pthread_mutex_unlock(&bp->err_recovery_lock); return -EAGAIN; } pthread_mutex_unlock(&bp->err_recovery_lock);