diff mbox series

[v3,5/6] power: add new header file to export list

Message ID 20210120135556.33763-6-david.hunt@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers show
Series power: fix make build for power apps | expand

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

David Hunt Jan. 20, 2021, 1:55 p.m. UTC
From: Bruce Richardson <bruce.richardson@intel.com>

Adjust meson.build so that 'ninja install' copies the new header
file into the installation directory.

Fixes: 210c383e247b ("power: packet format for vm power management")
Fixes: cd0d5547e873 ("power: vm communication channels in guest")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Signed-off-by: David Hunt <david.hunt@intel.com>
---
 lib/librte_power/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Anatoly Burakov Jan. 20, 2021, 2:28 p.m. UTC | #1
On 20-Jan-21 1:55 PM, David Hunt wrote:
> From: Bruce Richardson <bruce.richardson@intel.com>
> 
> Adjust meson.build so that 'ninja install' copies the new header
> file into the installation directory.
> 
> Fixes: 210c383e247b ("power: packet format for vm power management")
> Fixes: cd0d5547e873 ("power: vm communication channels in guest")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---

IMO this should be part of the first patch, otherwise the build could 
(will?) be broken until this patch.
David Hunt Jan. 20, 2021, 3:01 p.m. UTC | #2
On 20/1/2021 2:28 PM, Burakov, Anatoly wrote:
> On 20-Jan-21 1:55 PM, David Hunt wrote:
>> From: Bruce Richardson <bruce.richardson@intel.com>
>>
>> Adjust meson.build so that 'ninja install' copies the new header
>> file into the installation directory.
>>
>> Fixes: 210c383e247b ("power: packet format for vm power management")
>> Fixes: cd0d5547e873 ("power: vm communication channels in guest")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>> Signed-off-by: David Hunt <david.hunt@intel.com>
>> ---
>
> IMO this should be part of the first patch, otherwise the build could 
> (will?) be broken until this patch.
>
Hi Anatoly,

    It was broken before this patch set. I wanted to have everything in 
place, including the correct naming of structs/defines before allowing 
builds against the new header file, hence this order in the patch set.

Rgds,

Dave.
Bruce Richardson Jan. 20, 2021, 3:08 p.m. UTC | #3
On Wed, Jan 20, 2021 at 02:28:59PM +0000, Burakov, Anatoly wrote:
> On 20-Jan-21 1:55 PM, David Hunt wrote:
> > From: Bruce Richardson <bruce.richardson@intel.com>
> > 
> > Adjust meson.build so that 'ninja install' copies the new header
> > file into the installation directory.
> > 
> > Fixes: 210c383e247b ("power: packet format for vm power management")
> > Fixes: cd0d5547e873 ("power: vm communication channels in guest")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > Signed-off-by: David Hunt <david.hunt@intel.com>
> > ---
> 
> IMO this should be part of the first patch, otherwise the build could
> (will?) be broken until this patch.
> 
Since things were already broken before the set, I'm not sure this really
matters.
Anatoly Burakov Jan. 20, 2021, 3:17 p.m. UTC | #4
On 20-Jan-21 3:01 PM, David Hunt wrote:
> 
> On 20/1/2021 2:28 PM, Burakov, Anatoly wrote:
>> On 20-Jan-21 1:55 PM, David Hunt wrote:
>>> From: Bruce Richardson <bruce.richardson@intel.com>
>>>
>>> Adjust meson.build so that 'ninja install' copies the new header
>>> file into the installation directory.
>>>
>>> Fixes: 210c383e247b ("power: packet format for vm power management")
>>> Fixes: cd0d5547e873 ("power: vm communication channels in guest")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>>> Signed-off-by: David Hunt <david.hunt@intel.com>
>>> ---
>>
>> IMO this should be part of the first patch, otherwise the build could 
>> (will?) be broken until this patch.
>>
> Hi Anatoly,
> 
>     It was broken before this patch set. I wanted to have everything in 
> place, including the correct naming of structs/defines before allowing 
> builds against the new header file, hence this order in the patch set.
> 
> Rgds,
> 
> Dave.
> 

It's only my opinion obviously, but i rather prefer an approach of 
fixing build issues first, and then renaming everything, as I like to 
have each patch build at every step of the way. You probably know 
better, but from a cursory look, you should be able to keep 
progressively changing things but also keep everything building 
correctly every step of the way.
Anatoly Burakov Jan. 20, 2021, 3:18 p.m. UTC | #5
On 20-Jan-21 3:08 PM, Bruce Richardson wrote:
> On Wed, Jan 20, 2021 at 02:28:59PM +0000, Burakov, Anatoly wrote:
>> On 20-Jan-21 1:55 PM, David Hunt wrote:
>>> From: Bruce Richardson <bruce.richardson@intel.com>
>>>
>>> Adjust meson.build so that 'ninja install' copies the new header
>>> file into the installation directory.
>>>
>>> Fixes: 210c383e247b ("power: packet format for vm power management")
>>> Fixes: cd0d5547e873 ("power: vm communication channels in guest")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>>> Signed-off-by: David Hunt <david.hunt@intel.com>
>>> ---
>>
>> IMO this should be part of the first patch, otherwise the build could
>> (will?) be broken until this patch.
>>
> Since things were already broken before the set, I'm not sure this really
> matters.
> 

If they can be *un*broken sooner, that's a win in my book :)
David Hunt Jan. 20, 2021, 3:29 p.m. UTC | #6
On 20/1/2021 3:18 PM, Burakov, Anatoly wrote:
> On 20-Jan-21 3:08 PM, Bruce Richardson wrote:
>> On Wed, Jan 20, 2021 at 02:28:59PM +0000, Burakov, Anatoly wrote:
>>> On 20-Jan-21 1:55 PM, David Hunt wrote:
>>>> From: Bruce Richardson <bruce.richardson@intel.com>
>>>>
>>>> Adjust meson.build so that 'ninja install' copies the new header
>>>> file into the installation directory.
>>>>
>>>> Fixes: 210c383e247b ("power: packet format for vm power management")
>>>> Fixes: cd0d5547e873 ("power: vm communication channels in guest")
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>>>> Signed-off-by: David Hunt <david.hunt@intel.com>
>>>> ---
>>>
>>> IMO this should be part of the first patch, otherwise the build could
>>> (will?) be broken until this patch.
>>>
>> Since things were already broken before the set, I'm not sure this 
>> really
>> matters.
>>
>
> If they can be *un*broken sooner, that's a win in my book :)


I'll keep that in mind for future patch sets. For this one, the effort 
to change far outweighs the benefits, so I'll leave as is. OK with you?
Anatoly Burakov Jan. 20, 2021, 3:43 p.m. UTC | #7
On 20-Jan-21 3:29 PM, David Hunt wrote:
> 
> On 20/1/2021 3:18 PM, Burakov, Anatoly wrote:
>> On 20-Jan-21 3:08 PM, Bruce Richardson wrote:
>>> On Wed, Jan 20, 2021 at 02:28:59PM +0000, Burakov, Anatoly wrote:
>>>> On 20-Jan-21 1:55 PM, David Hunt wrote:
>>>>> From: Bruce Richardson <bruce.richardson@intel.com>
>>>>>
>>>>> Adjust meson.build so that 'ninja install' copies the new header
>>>>> file into the installation directory.
>>>>>
>>>>> Fixes: 210c383e247b ("power: packet format for vm power management")
>>>>> Fixes: cd0d5547e873 ("power: vm communication channels in guest")
>>>>> Cc: stable@dpdk.org
>>>>>
>>>>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>>>>> Signed-off-by: David Hunt <david.hunt@intel.com>
>>>>> ---
>>>>
>>>> IMO this should be part of the first patch, otherwise the build could
>>>> (will?) be broken until this patch.
>>>>
>>> Since things were already broken before the set, I'm not sure this 
>>> really
>>> matters.
>>>
>>
>> If they can be *un*broken sooner, that's a win in my book :)
> 
> 
> I'll keep that in mind for future patch sets. For this one, the effort 
> to change far outweighs the benefits, so I'll leave as is. OK with you?
> 

Sure.
diff mbox series

Patch

diff --git a/lib/librte_power/meson.build b/lib/librte_power/meson.build
index 4b4cf1b90..541569528 100644
--- a/lib/librte_power/meson.build
+++ b/lib/librte_power/meson.build
@@ -10,5 +10,6 @@  sources = files('rte_power.c', 'power_acpi_cpufreq.c',
 		'rte_power_empty_poll.c',
 		'power_pstate_cpufreq.c',
 		'power_common.c')
-headers = files('rte_power.h','rte_power_empty_poll.h')
+headers = files('rte_power.h','rte_power_empty_poll.h',
+	'rte_power_guest_channel.h')
 deps += ['timer']