| Message ID | 20210115111052.16437-6-bruce.richardson@intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Marchand |
| Headers | show |
| Series | ensure headers have correct includes | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
On 1/15/21 2:10 PM, Bruce Richardson wrote: > The rte_mbuf_dyn.h header file uses a number of types and macros without > including the required header files to get the definitions of those > macros/types. Similarly, the rte_mbuf_core.h file was missing an > include for rte_byteorder.h header. > > Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") > Fixes: 3eb860b08eb7 ("mbuf: move definitions into a separate file") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h index 567551deab..34e892f21b 100644 --- a/lib/librte_mbuf/rte_mbuf_core.h +++ b/lib/librte_mbuf/rte_mbuf_core.h @@ -18,6 +18,7 @@ #include <stdint.h> #include <rte_compat.h> +#include <rte_byteorder.h> #include <generic/rte_atomic.h> #ifdef __cplusplus diff --git a/lib/librte_mbuf/rte_mbuf_dyn.h b/lib/librte_mbuf/rte_mbuf_dyn.h index fc4eee71d0..f42deed012 100644 --- a/lib/librte_mbuf/rte_mbuf_dyn.h +++ b/lib/librte_mbuf/rte_mbuf_dyn.h @@ -66,7 +66,10 @@ * - any name that does not start with "rte_" in an application */ +#include <stdio.h> +#include <stdint.h> #include <sys/types.h> +#include <rte_compat.h> #ifdef __cplusplus extern "C" {
The rte_mbuf_dyn.h header file uses a number of types and macros without including the required header files to get the definitions of those macros/types. Similarly, the rte_mbuf_core.h file was missing an include for rte_byteorder.h header. Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") Fixes: 3eb860b08eb7 ("mbuf: move definitions into a separate file") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> --- lib/librte_mbuf/rte_mbuf_core.h | 1 + lib/librte_mbuf/rte_mbuf_dyn.h | 3 +++ 2 files changed, 4 insertions(+)