diff mbox series

[v2,09/19] ipsec: fix missing header include

Message ID 20210115111052.16437-10-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers show
Series ensure headers have correct includes | expand

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Bruce Richardson Jan. 15, 2021, 11:10 a.m. UTC
The rte_ipsec_sad.h header used the standard uintXX_t types, but did not
include stdint.h header for them.

Fixes: 401633d9c112 ("ipsec: add inbound SAD API")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/librte_ipsec/rte_ipsec_sad.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Ananyev, Konstantin Jan. 15, 2021, 11:35 a.m. UTC | #1
> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Sent: Friday, January 15, 2021 11:11 AM
> To: dev@dpdk.org
> Cc: david.marchand@redhat.com; Richardson, Bruce <bruce.richardson@intel.com>; stable@dpdk.org; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>; Medvedkin, Vladimir
> <vladimir.medvedkin@intel.com>; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [PATCH v2 09/19] ipsec: fix missing header include
> 
> The rte_ipsec_sad.h header used the standard uintXX_t types, but did not
> include stdint.h header for them.
> 
> Fixes: 401633d9c112 ("ipsec: add inbound SAD API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  lib/librte_ipsec/rte_ipsec_sad.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_ipsec/rte_ipsec_sad.h b/lib/librte_ipsec/rte_ipsec_sad.h
> index 3e67ab1e4b..66c703ff3a 100644
> --- a/lib/librte_ipsec/rte_ipsec_sad.h
> +++ b/lib/librte_ipsec/rte_ipsec_sad.h
> @@ -7,6 +7,7 @@
>  #define _RTE_IPSEC_SAD_H_
> 
>  #include <rte_compat.h>
> +#include <stdint.h>
> 
>  /**
>   * @file rte_ipsec_sad.h
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.27.0
Medvedkin, Vladimir Jan. 15, 2021, 11:37 a.m. UTC | #2
On 15/01/2021 11:10, Bruce Richardson wrote:
> The rte_ipsec_sad.h header used the standard uintXX_t types, but did not
> include stdint.h header for them.
> 
> Fixes: 401633d9c112 ("ipsec: add inbound SAD API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>   lib/librte_ipsec/rte_ipsec_sad.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_ipsec/rte_ipsec_sad.h b/lib/librte_ipsec/rte_ipsec_sad.h
> index 3e67ab1e4b..66c703ff3a 100644
> --- a/lib/librte_ipsec/rte_ipsec_sad.h
> +++ b/lib/librte_ipsec/rte_ipsec_sad.h
> @@ -7,6 +7,7 @@
>   #define _RTE_IPSEC_SAD_H_
>   
>   #include <rte_compat.h>
> +#include <stdint.h>
>   
>   /**
>    * @file rte_ipsec_sad.h
> 

Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Medvedkin, Vladimir Jan. 15, 2021, 11:45 a.m. UTC | #3
Hi Bruce,

Just a one nit, please put <stdint.h> before rte_ includes.

On 15/01/2021 11:37, Medvedkin, Vladimir wrote:
> 
> 
> On 15/01/2021 11:10, Bruce Richardson wrote:
>> The rte_ipsec_sad.h header used the standard uintXX_t types, but did not
>> include stdint.h header for them.
>>
>> Fixes: 401633d9c112 ("ipsec: add inbound SAD API")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>> ---
>>   lib/librte_ipsec/rte_ipsec_sad.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/librte_ipsec/rte_ipsec_sad.h 
>> b/lib/librte_ipsec/rte_ipsec_sad.h
>> index 3e67ab1e4b..66c703ff3a 100644
>> --- a/lib/librte_ipsec/rte_ipsec_sad.h
>> +++ b/lib/librte_ipsec/rte_ipsec_sad.h
>> @@ -7,6 +7,7 @@
>>   #define _RTE_IPSEC_SAD_H_
>>   #include <rte_compat.h>
>> +#include <stdint.h>
>>   /**
>>    * @file rte_ipsec_sad.h
>>
> 
> Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>
Bruce Richardson Jan. 15, 2021, 11:49 a.m. UTC | #4
On Fri, Jan 15, 2021 at 11:45:11AM +0000, Medvedkin, Vladimir wrote:
> Hi Bruce,
> 
> Just a one nit, please put <stdint.h> before rte_ includes.
>

Good point, I'll fix if I do a V3.
 
> On 15/01/2021 11:37, Medvedkin, Vladimir wrote:
> > 
> > 
> > On 15/01/2021 11:10, Bruce Richardson wrote:
> > > The rte_ipsec_sad.h header used the standard uintXX_t types, but did not
> > > include stdint.h header for them.
> > > 
> > > Fixes: 401633d9c112 ("ipsec: add inbound SAD API")
> > > Cc: stable@dpdk.org
> > > 
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > ---
> > >   lib/librte_ipsec/rte_ipsec_sad.h | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/lib/librte_ipsec/rte_ipsec_sad.h
> > > b/lib/librte_ipsec/rte_ipsec_sad.h
> > > index 3e67ab1e4b..66c703ff3a 100644
> > > --- a/lib/librte_ipsec/rte_ipsec_sad.h
> > > +++ b/lib/librte_ipsec/rte_ipsec_sad.h
> > > @@ -7,6 +7,7 @@
> > >   #define _RTE_IPSEC_SAD_H_
> > >   #include <rte_compat.h>
> > > +#include <stdint.h>
> > >   /**
> > >    * @file rte_ipsec_sad.h
> > > 
> > 
> > Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> > 
> 
> -- 
> Regards,
> Vladimir
diff mbox series

Patch

diff --git a/lib/librte_ipsec/rte_ipsec_sad.h b/lib/librte_ipsec/rte_ipsec_sad.h
index 3e67ab1e4b..66c703ff3a 100644
--- a/lib/librte_ipsec/rte_ipsec_sad.h
+++ b/lib/librte_ipsec/rte_ipsec_sad.h
@@ -7,6 +7,7 @@ 
 #define _RTE_IPSEC_SAD_H_
 
 #include <rte_compat.h>
+#include <stdint.h>
 
 /**
  * @file rte_ipsec_sad.h