diff mbox series

[v1,4/5] app/eventdev: remove unnecessary barriers for pipeline test

Message ID 20210114070830.707550-5-feifei.wang2@arm.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers show
Series refactor smp barriers in app/eventdev | expand

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Feifei Wang Jan. 14, 2021, 7:08 a.m. UTC
For "processed_pkts" function, no operations should keep the order that
being executed before loading "worker[i].processed_pkts".

Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 app/test-eventdev/test_pipeline_common.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Pavan Nikhilesh Bhagavatula Jan. 25, 2021, 5:50 p.m. UTC | #1
>For "processed_pkts" function, no operations should keep the order
>that
>being executed before loading "worker[i].processed_pkts".
>
>Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
>Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>---
> app/test-eventdev/test_pipeline_common.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-
>eventdev/test_pipeline_common.c
>index c67be48e9..b47d76743 100644
>--- a/app/test-eventdev/test_pipeline_common.c
>+++ b/app/test-eventdev/test_pipeline_common.c
>@@ -44,7 +44,6 @@ processed_pkts(struct test_pipeline *t)
> 	uint8_t i;
> 	uint64_t total = 0;
>
>-	rte_smp_rmb();
> 	for (i = 0; i < t->nb_workers; i++)
> 		total += t->worker[i].processed_pkts;
>
>--
>2.25.1
diff mbox series

Patch

diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
index c67be48e9..b47d76743 100644
--- a/app/test-eventdev/test_pipeline_common.c
+++ b/app/test-eventdev/test_pipeline_common.c
@@ -44,7 +44,6 @@  processed_pkts(struct test_pipeline *t)
 	uint8_t i;
 	uint64_t total = 0;
 
-	rte_smp_rmb();
 	for (i = 0; i < t->nb_workers; i++)
 		total += t->worker[i].processed_pkts;