From patchwork Thu Jan 14 05:23:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simei Su X-Patchwork-Id: 86497 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0D05A0A02; Thu, 14 Jan 2021 06:36:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A2C4140D25; Thu, 14 Jan 2021 06:36:18 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id B1ADD140D24 for ; Thu, 14 Jan 2021 06:36:16 +0100 (CET) IronPort-SDR: EZd9sSleUafCs5bawxNLdLkR+7K+AmOTFxWcTuiXB5JNyKJ3vtD9fi/tY5E92e55Yf2xIdkLFp 0/k5mTQWblpA== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178458869" X-IronPort-AV: E=Sophos;i="5.79,346,1602572400"; d="scan'208";a="178458869" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 21:36:15 -0800 IronPort-SDR: G71IQs0/o+YwHlaCrOiqtbON/VKeTD5z6auuMnJaz+7rhic59Y0GSZws5wZk0c1Z2rKZdeCovn jCWcUDCaFHPw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,346,1602572400"; d="scan'208";a="382142123" Received: from unknown (HELO npg-dpdk-cvl-simeisu-118d193.sh.intel.com) ([10.67.119.195]) by orsmga008.jf.intel.com with ESMTP; 13 Jan 2021 21:36:13 -0800 From: Simei Su To: qi.z.zhang@intel.com Cc: dev@dpdk.org, junfeng.guo@intel.com, jia.guo@intel.com, yahui.cao@intel.com, Simei Su Date: Thu, 14 Jan 2021 13:23:24 +0800 Message-Id: <20210114052324.393980-1-simei.su@intel.com> X-Mailer: git-send-email 2.9.5 Subject: [dpdk-dev] [PATCH] net/iavf: fix null pointer dereference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A pointer has already been dereferenced before checking if it is NULL. It doesn't make any sense, so correct to avoid it. Fixes: 4f3cfcbc3df3 ("net/iavf: support eCPRI msg type 0 for RSS") Coverity issue: 365290 Signed-off-by: Simei Su Acked-by: Qi Zhang --- drivers/net/iavf/iavf_hash.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index ebaac58..9901f4b 100644 --- a/drivers/net/iavf/iavf_hash.c +++ b/drivers/net/iavf/iavf_hash.c @@ -597,11 +597,13 @@ iavf_hash_parse_pattern(const struct rte_flow_item pattern[], uint64_t *phint, break; case RTE_FLOW_ITEM_TYPE_ECPRI: ecpri = item->spec; - ecpri_common.u32 = rte_be_to_cpu_32( - ecpri->hdr.common.u32); if (!ecpri) break; - else if (ecpri_common.type != + + ecpri_common.u32 = rte_be_to_cpu_32( + ecpri->hdr.common.u32); + + if (ecpri_common.type != RTE_ECPRI_MSG_TYPE_IQ_DATA) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, item,