| Message ID | 20210108083011.28700-1-murphyx.yang@intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Qi Zhang |
| Headers | show |
| Series | net/i40e: i40e PMD APIs add input pointer null check | expand |
| Context | Check | Description |
|---|---|---|
| ci/iol-testing | success | Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/iol-broadcom-Performance | success | Performance Testing PASS |
| ci/iol-broadcom-Functional | success | Functional Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/iol-abi-testing | success | Testing PASS |
| ci/checkpatch | success | coding style OK |
> -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Murphy Yang > Sent: Friday, January 8, 2021 4:30 PM > To: dev@dpdk.org > Cc: Yang, Qiming <qiming.yang@intel.com>; Yigit, Ferruh > <ferruh.yigit@intel.com>; Guo, Jia <jia.guo@intel.com>; Xing, Beilei > <beilei.xing@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Yang, > MurphyX <murphyx.yang@intel.com> > Subject: [dpdk-dev] [PATCH] net/i40e: i40e PMD APIs add input pointer null > check Changed title to "add input pointer null" > > Pointer 'NULL' check for 'mac_addr' or 'conf' within i40e PMD APIs. > > Fixes: 66c78f4799ff ("net/i40e: add support for packet template to flow > director") > Fixes: 04b443fb2c43 ("net/i40e: fix port id type") > > Signed-off-by: Murphy Yang <murphyx.yang@intel.com> Acked-by: Qi Zhang <qi.z.zhang@intel.com> Applied to dpdk-next-net-intel. Thanks Qi
diff --git a/drivers/net/i40e/rte_pmd_i40e.c b/drivers/net/i40e/rte_pmd_i40e.c index 790d042002..2e34140c5b 100644 --- a/drivers/net/i40e/rte_pmd_i40e.c +++ b/drivers/net/i40e/rte_pmd_i40e.c @@ -2366,6 +2366,9 @@ rte_pmd_i40e_add_vf_mac_addr(uint16_t port, uint16_t vf_id, struct i40e_mac_filter_info mac_filter; int ret; + if (mac_addr == NULL) + return -EINVAL; + if (i40e_validate_mac_addr((u8 *)mac_addr) != I40E_SUCCESS) return -EINVAL; @@ -3042,6 +3045,9 @@ int rte_pmd_i40e_flow_add_del_packet_template( RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV); + if (conf == NULL) + return -EINVAL; + if (!is_i40e_supported(dev)) return -ENOTSUP;
Pointer 'NULL' check for 'mac_addr' or 'conf' within i40e PMD APIs. Fixes: 66c78f4799ff ("net/i40e: add support for packet template to flow director") Fixes: 04b443fb2c43 ("net/i40e: fix port id type") Signed-off-by: Murphy Yang <murphyx.yang@intel.com> --- drivers/net/i40e/rte_pmd_i40e.c | 6 ++++++ 1 file changed, 6 insertions(+)