net/failsafe: fix RSS hash offload reporting
Checks
Commit Message
If sub-devices support RSS hash offload, the offload should be
reported by the failsafe device since handling is transparent
from failsafe point of view.
Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload")
Cc: stable@dpdk.org
Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
---
drivers/net/failsafe/failsafe_ops.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
Comments
On 12/22/2020 8:00 AM, Andrew Rybchenko wrote:
> If sub-devices support RSS hash offload, the offload should be
> reported by the failsafe device since handling is transparent
> from failsafe point of view.
>
> Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
It looks reasonable, but would be good to get ack from maintainer.
Gaetan, can you please look at this?
Thanks.
On Fri, Feb 19, 2021, at 08:49, Ferruh Yigit wrote:
> On 12/22/2020 8:00 AM, Andrew Rybchenko wrote:
> > If sub-devices support RSS hash offload, the offload should be
> > reported by the failsafe device since handling is transparent
> > from failsafe point of view.
> >
> > Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
> It looks reasonable, but would be good to get ack from maintainer.
>
> Gaetan, can you please look at this?
>
> Thanks.
>
Hi Ferruh,
Indeed, sorry Andrew about the delay.
I agree that this looks reasonable,
Acked-by: Gaetan Rivet <grive@u256.net>
On 2/22/2021 3:25 PM, Gaëtan Rivet wrote:
> On Fri, Feb 19, 2021, at 08:49, Ferruh Yigit wrote:
>> On 12/22/2020 8:00 AM, Andrew Rybchenko wrote:
>>> If sub-devices support RSS hash offload, the offload should be
>>> reported by the failsafe device since handling is transparent
>>> from failsafe point of view.
>>>
>>> Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
> Acked-by: Gaetan Rivet <grive@u256.net>
>
Applied to dpdk-next-net/main, thanks.
@@ -1192,7 +1192,8 @@ fs_dev_infos_get(struct rte_eth_dev *dev,
DEV_RX_OFFLOAD_JUMBO_FRAME |
DEV_RX_OFFLOAD_SCATTER |
DEV_RX_OFFLOAD_TIMESTAMP |
- DEV_RX_OFFLOAD_SECURITY;
+ DEV_RX_OFFLOAD_SECURITY |
+ DEV_RX_OFFLOAD_RSS_HASH;
infos->rx_queue_offload_capa =
DEV_RX_OFFLOAD_VLAN_STRIP |
@@ -1209,7 +1210,8 @@ fs_dev_infos_get(struct rte_eth_dev *dev,
DEV_RX_OFFLOAD_JUMBO_FRAME |
DEV_RX_OFFLOAD_SCATTER |
DEV_RX_OFFLOAD_TIMESTAMP |
- DEV_RX_OFFLOAD_SECURITY;
+ DEV_RX_OFFLOAD_SECURITY |
+ DEV_RX_OFFLOAD_RSS_HASH;
infos->tx_offload_capa =
DEV_TX_OFFLOAD_MULTI_SEGS |