diff mbox series

net/bnxt: limit per-poll Rx representor pkts

Message ID 20201214185352.252477-1-lance.richardson@broadcom.com (mailing list archive)
State Accepted, archived
Delegated to: Ajit Khaparde
Headers show
Series net/bnxt: limit per-poll Rx representor pkts | expand

Checks

Context Check Description
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/travis-robot warning Travis build: failed
ci/iol-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Lance Richardson Dec. 14, 2020, 6:53 p.m. UTC
Limit number of representor packets transferred per poll
to requested burst size.

Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Cc: stable@dpdk.org
---
 drivers/net/bnxt/bnxt_rxr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ajit Khaparde Dec. 17, 2020, 11:54 p.m. UTC | #1
On Mon, Dec 14, 2020 at 10:54 AM Lance Richardson
<lance.richardson@broadcom.com> wrote:
>
> Limit number of representor packets transferred per poll
> to requested burst size.
>
> Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Cc: stable@dpdk.org

Patch applied to dpdk-next-net-brcm. Thanks

> ---
>  drivers/net/bnxt/bnxt_rxr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> index 2b1dd97617..ffdeeecc3a 100644
> --- a/drivers/net/bnxt/bnxt_rxr.c
> +++ b/drivers/net/bnxt/bnxt_rxr.c
> @@ -901,7 +901,7 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
>                 }
>
>                 raw_cons = NEXT_RAW_CMP(raw_cons);
> -               if (nb_rx_pkts == nb_pkts || evt)
> +               if (nb_rx_pkts == nb_pkts || nb_rep_rx_pkts == nb_pkts || evt)
>                         break;
>                 /* Post some Rx buf early in case of larger burst processing */
>                 if (nb_rx_pkts == BNXT_RX_POST_THRESH)
> --
> 2.25.1
>
>
> --
> This electronic communication and the information and any files transmitted
> with it, or attached to it, are confidential and are intended solely for
> the use of the individual or entity to whom it is addressed and may contain
> information that is confidential, legally privileged, protected by privacy
> laws, or otherwise restricted from disclosure to anyone else. If you are
> not the intended recipient or the person responsible for delivering the
> e-mail to the intended recipient, you are hereby notified that any use,
> copying, distributing, dissemination, forwarding, printing, or copying of
> this e-mail is strictly prohibited. If you received this e-mail in error,
> please return the e-mail to the sender, delete it from your computer, and
> destroy any printed copy of it.
Ferruh Yigit Jan. 6, 2021, 9:27 a.m. UTC | #2
On 12/14/2020 6:53 PM, Lance Richardson wrote:
> Limit number of representor packets transferred per poll
> to requested burst size.
> 

Hi Lance,

Can you please describe the impact of the change? Since it has a fixes line, it 
seems it is fixing something but it is not clear what is fixed.

> Fixes: 6dc83230b43b ("net/bnxt: support port representor data path")
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Cc: stable@dpdk.org
> ---
>   drivers/net/bnxt/bnxt_rxr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> index 2b1dd97617..ffdeeecc3a 100644
> --- a/drivers/net/bnxt/bnxt_rxr.c
> +++ b/drivers/net/bnxt/bnxt_rxr.c
> @@ -901,7 +901,7 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
>   		}
>   
>   		raw_cons = NEXT_RAW_CMP(raw_cons);
> -		if (nb_rx_pkts == nb_pkts || evt)
> +		if (nb_rx_pkts == nb_pkts || nb_rep_rx_pkts == nb_pkts || evt)
>   			break;
>   		/* Post some Rx buf early in case of larger burst processing */
>   		if (nb_rx_pkts == BNXT_RX_POST_THRESH)
>
Lance Richardson Jan. 6, 2021, 8:54 p.m. UTC | #3
On Wed, Jan 6, 2021 at 4:27 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 12/14/2020 6:53 PM, Lance Richardson wrote:
> > Limit number of representor packets transferred per poll
> > to requested burst size.
> >
>
> Hi Lance,
>
> Can you please describe the impact of the change? Since it has a fixes line, it
> seems it is fixing something but it is not clear what is fixed.
>
Hi Ferruh,

How does this look:

Without some limit on the number of packets transferred from the
hw ring to the representor ring per burst receive call, an entire ring's
worth of packets can be transferred. This can break assumptions
about ring indices (index on return could be identical to the index
on entry, which is assumed to mean that no packets were processed),
and can result in representor packets being dropped unnecessarily
due to representor ring overflow.

Fix by limiting the number of representor packets transferred per
poll to requested burst size.

Thanks,
    Lance
Ferruh Yigit Jan. 7, 2021, 3:33 p.m. UTC | #4
On 1/6/2021 8:54 PM, Lance Richardson wrote:
> On Wed, Jan 6, 2021 at 4:27 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>
>> On 12/14/2020 6:53 PM, Lance Richardson wrote:
>>> Limit number of representor packets transferred per poll
>>> to requested burst size.
>>>
>>
>> Hi Lance,
>>
>> Can you please describe the impact of the change? Since it has a fixes line, it
>> seems it is fixing something but it is not clear what is fixed.
>>
> Hi Ferruh,
> 
> How does this look:
> 
> Without some limit on the number of packets transferred from the
> hw ring to the representor ring per burst receive call, an entire ring's
> worth of packets can be transferred. This can break assumptions
> about ring indices (index on return could be identical to the index
> on entry, which is assumed to mean that no packets were processed),
> and can result in representor packets being dropped unnecessarily
> due to representor ring overflow.
> 
> Fix by limiting the number of representor packets transferred per
> poll to requested burst size.
> 

Thank you, updated the commit log in next-net.
diff mbox series

Patch

diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
index 2b1dd97617..ffdeeecc3a 100644
--- a/drivers/net/bnxt/bnxt_rxr.c
+++ b/drivers/net/bnxt/bnxt_rxr.c
@@ -901,7 +901,7 @@  uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,
 		}
 
 		raw_cons = NEXT_RAW_CMP(raw_cons);
-		if (nb_rx_pkts == nb_pkts || evt)
+		if (nb_rx_pkts == nb_pkts || nb_rep_rx_pkts == nb_pkts || evt)
 			break;
 		/* Post some Rx buf early in case of larger burst processing */
 		if (nb_rx_pkts == BNXT_RX_POST_THRESH)