From patchwork Wed Dec 9 23:53:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 84910 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F076A04DB; Thu, 10 Dec 2020 00:59:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 66100CA5A; Thu, 10 Dec 2020 00:54:23 +0100 (CET) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 45458CA26 for ; Thu, 10 Dec 2020 00:54:15 +0100 (CET) Received: by mail-pg1-f195.google.com with SMTP id t3so2434703pgi.11 for ; Wed, 09 Dec 2020 15:54:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=TT8YdPYWfbYkyBD8nbmy/X4Y1w8JNrQ9q5fapLAPC0c=; b=tm1F/zqaYyJchugWgOG2Oo3he2/qTy91XbGG6IXLrmXxOFOE+u+62dOGYz7rLHC3me 6O7x1wgikVAEon0O5Jf2tpDqkhuYK97jXQKUK9s5cpyXjq1VXKynMcxOQRclQS4jCTaV Io09O/8ERKxiSksnju2S6bI8F8TxuGfCorWUOMFOidaqPd9mZQ7Jp3OQ+m9zXGGNaeBy Pnn+t91a2olvohQYk3RCcYfsZqkPqKmVdTTNfTPY4fAM51An6zxQbJvWWz4Xi0guGXGU 2r1YbEEycMmj7pnIVlp4k6q++IqnVDSQe0zcY1JFOsB4yClxBpuN6hLnHxb899reZnen fgYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TT8YdPYWfbYkyBD8nbmy/X4Y1w8JNrQ9q5fapLAPC0c=; b=J0CFZI6rWNLAyYXRBvGlsaCTBMBHxIVrTRLE0Z8JSfpCG3EoHxmCJtz8YohhWhJTe9 q+uGf36ox/LCW39L6MmC7w39rHtuUo68e2/nXjelmoBrtTRXHI4M5Ispb2aqhsKuR3W4 30N+RT59fNEE91GQS+PQhUtbPsK0jv9TknF1Z0lbscIvHkCzUgbWUkpmK1jJDvD46cTE QPxm/rCzItlAeDT1AfqN6nR4/yM8GXJ5aQyLPcfSumThxl2Rltzpw81XWfe6MSTiO1n/ JVxnwx4g4WGloQGgJoHgvuJEQ69xlDla3GyAlex8bIvzs91sng8GK14QPYCYDd+O3urG TrXw== X-Gm-Message-State: AOAM532TyCthmdCI70yaILr94czfsQzIAUUeOC6iK67XQGvWYuhN+qgO 4h1MPy5WkJ3DtnFsFIpD8o4Vb2pLwDn5uUkG X-Google-Smtp-Source: ABdhPJztZyksLJCUU/Lm2KH/k+LReTeh3yJS53oXywcSJnp+tdNLYSjdJDABwWfMRi/s/lHHz5FANw== X-Received: by 2002:a63:f201:: with SMTP id v1mr4179511pgh.267.1607558054264; Wed, 09 Dec 2020 15:54:14 -0800 (PST) Received: from localhost.localdomain ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id s7sm4047693pfh.207.2020.12.09.15.54.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Dec 2020 15:54:13 -0800 (PST) From: Ajit Khaparde X-Google-Original-From: Ajit Khaparde To: dev@dpdk.org Date: Wed, 9 Dec 2020 15:53:46 -0800 Message-Id: <20201209235347.16180-17-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20201209235347.16180-1-ajit.khaparde@broadcom.com> References: <20201209192233.6518-1-ajit.khaparde@broadcom.com> <20201209235347.16180-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v3 16/17] net/bnxt: add missing comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add and update some missing comments in the code. Signed-off-by: Ajit Khaparde Acked-by: Lance Richardson --- drivers/net/bnxt/bnxt.h | 6 ++++++ drivers/net/bnxt/tf_ulp/ulp_template_db_act.c | 5 +++++ drivers/net/bnxt/tf_ulp/ulp_template_db_class.c | 6 ++++++ 3 files changed, 17 insertions(+) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index 556e99203..07d39ee93 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -724,7 +724,13 @@ struct bnxt { void *hwrm_short_cmd_req_addr; rte_iova_t hwrm_short_cmd_req_dma_addr; rte_spinlock_t hwrm_lock; + /* synchronize between dev_configure_op and int handler */ pthread_mutex_t def_cp_lock; + /* synchronize between dev_start_op and async evt handler + * Locking sequence in async evt handler will be + * def_cp_lock + * health_check_lock + */ pthread_mutex_t health_check_lock; uint16_t max_req_len; uint16_t max_resp_len; diff --git a/drivers/net/bnxt/tf_ulp/ulp_template_db_act.c b/drivers/net/bnxt/tf_ulp/ulp_template_db_act.c index 00ada607a..509af7c58 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_template_db_act.c +++ b/drivers/net/bnxt/tf_ulp/ulp_template_db_act.c @@ -8,6 +8,10 @@ #include "ulp_template_struct.h" #include "ulp_rte_parser.h" +/* + * Action signature table: + * maps hash id to ulp_act_match_list[] index + */ uint16_t ulp_act_sig_tbl[BNXT_ULP_ACT_SIG_TBL_MAX_SZ] = { [BNXT_ULP_ACT_HID_015a] = 1, [BNXT_ULP_ACT_HID_00eb] = 2, @@ -93,6 +97,7 @@ uint16_t ulp_act_sig_tbl[BNXT_ULP_ACT_SIG_TBL_MAX_SZ] = { [BNXT_ULP_ACT_HID_0b4e] = 82 }; +/* Array for the act matcher list */ struct bnxt_ulp_act_match_info ulp_act_match_list[] = { [1] = { .act_hid = BNXT_ULP_ACT_HID_015a, diff --git a/drivers/net/bnxt/tf_ulp/ulp_template_db_class.c b/drivers/net/bnxt/tf_ulp/ulp_template_db_class.c index fdb26da3e..d904a04cb 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_template_db_class.c +++ b/drivers/net/bnxt/tf_ulp/ulp_template_db_class.c @@ -8,6 +8,11 @@ #include "ulp_template_struct.h" #include "ulp_rte_parser.h" +/* Define the template structures */ +/* + * Classification signature table: + * maps hash id to ulp_class_match_list[] index + */ uint16_t ulp_class_sig_tbl[BNXT_ULP_CLASS_SIG_TBL_MAX_SZ] = { [BNXT_ULP_CLASS_HID_0138] = 1, [BNXT_ULP_CLASS_HID_03f0] = 2, @@ -227,6 +232,7 @@ uint16_t ulp_class_sig_tbl[BNXT_ULP_CLASS_SIG_TBL_MAX_SZ] = { [BNXT_ULP_CLASS_HID_01b4] = 216 }; +/* Array for the proto matcher list */ struct bnxt_ulp_class_match_info ulp_class_match_list[] = { [1] = { .class_hid = BNXT_ULP_CLASS_HID_0138,