diff mbox series

[1/1] net/mlx5: fix flow shared action destroy error code

Message ID 20201124224022.2550640-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series [1/1] net/mlx5: fix flow shared action destroy error code | expand

Checks

Context Check Description
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Thomas Monjalon Nov. 24, 2020, 10:40 p.m. UTC
In the function rte_flow_shared_action_destroy(),
the errno ETOOMANYREFS has been replaced with EBUSY in the
commit dc328d1c555a ("ethdev: rename a flow shared action error code").

Another occurrence of ETOOMANYREFS, added later by mistake,
is replaced with EBUSY errno.

Fixes: fa7ad49e96b5 ("net/mlx5: fix shared RSS action update")

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tal Shnaiderman Nov. 25, 2020, 5:30 a.m. UTC | #1
> Subject: [dpdk-dev] [PATCH 1/1] net/mlx5: fix flow shared action destroy
> error code
> 
> External email: Use caution opening links or attachments
> 
> 
> In the function rte_flow_shared_action_destroy(), the errno
> ETOOMANYREFS has been replaced with EBUSY in the commit dc328d1c555a
> ("ethdev: rename a flow shared action error code").
> 
> Another occurrence of ETOOMANYREFS, added later by mistake, is replaced
> with EBUSY errno.
> 
> Fixes: fa7ad49e96b5 ("net/mlx5: fix shared RSS action update")
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c index 253f598310..aa21ff9613 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -11541,7 +11541,7 @@ __flow_dv_action_rss_release(struct
> rte_eth_dev *dev, uint32_t idx,
>         queue = shared_rss->ind_tbl->queues;
>         remaining = mlx5_ind_table_obj_release(dev, shared_rss->ind_tbl,
> true);
>         if (remaining)
> -               return rte_flow_error_set(error, ETOOMANYREFS,
> +               return rte_flow_error_set(error, EBUSY,
>                                           RTE_FLOW_ERROR_TYPE_ACTION,
>                                           NULL,
>                                           "shared rss indirection table has"
> --
> 2.28.0

Reviewed-by: Tal Shnaiderman <talshn@nvidia.com>
Tested-by: Tal Shnaiderman <talshn@nvidia.com>
Thomas Monjalon Nov. 25, 2020, 12:58 p.m. UTC | #2
> > In the function rte_flow_shared_action_destroy(), the errno
> > ETOOMANYREFS has been replaced with EBUSY in the commit dc328d1c555a
> > ("ethdev: rename a flow shared action error code").
> > 
> > Another occurrence of ETOOMANYREFS, added later by mistake, is replaced
> > with EBUSY errno.
> > 
> > Fixes: fa7ad49e96b5 ("net/mlx5: fix shared RSS action update")
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Reviewed-by: Tal Shnaiderman <talshn@nvidia.com>
> Tested-by: Tal Shnaiderman <talshn@nvidia.com>

Applied
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 253f598310..aa21ff9613 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -11541,7 +11541,7 @@  __flow_dv_action_rss_release(struct rte_eth_dev *dev, uint32_t idx,
 	queue = shared_rss->ind_tbl->queues;
 	remaining = mlx5_ind_table_obj_release(dev, shared_rss->ind_tbl, true);
 	if (remaining)
-		return rte_flow_error_set(error, ETOOMANYREFS,
+		return rte_flow_error_set(error, EBUSY,
 					  RTE_FLOW_ERROR_TYPE_ACTION,
 					  NULL,
 					  "shared rss indirection table has"