From patchwork Tue Nov 24 12:32:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ibtisam Tariq X-Patchwork-Id: 84506 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1ECCA04B1; Tue, 24 Nov 2020 13:34:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DAB7EC944; Tue, 24 Nov 2020 13:33:36 +0100 (CET) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id C69BCC942 for ; Tue, 24 Nov 2020 13:33:35 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id h21so2710507wmb.2 for ; Tue, 24 Nov 2020 04:33:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emumba-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fgWVONbzhG4ooI35IuyUeCIooENi5Nial/VuvBLCScE=; b=GIOh26o7dl1BJg7W4UPpf1R+yRTz9+nb5UoiJQbi92BCqGNHjyS8wdmWQZPAL5AOLQ zwJjUkzvOOTbIjWQnDuuAzhhbeNs6kQ58/QQwMtF6bS0OZTNkXmMDv6eIh50fZYUq9Ko 97J64K/1a57MuUXCSlbUUg06+baPCJri+qp3YakRrtiGO3gpRM7eFuDQVnv6Mwn+Lrxo +7oUrAh8j6e3TJqClpKNoMF4S3Xfksf1Ehi8Ko9OoNH18U2SH+BrT27v6pKRPpkUzsFY 80qjK0mnLibS2Ms5hr9BdRmIerbLpMX8sMMYm76aa1iGQMb2ro64V+WtkMQK43B5y6cB g3lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fgWVONbzhG4ooI35IuyUeCIooENi5Nial/VuvBLCScE=; b=fOWLuIzlKfdJY+VAqtN6UOuHACR0NE2LYTTnjNpE+P3Z4Fqu36FFdg/guninlNKwxv s1OCWiaGs6l/XyxSd9fkBHLCAJ9pA8adWK7GJASoKuqF5juwEZNoJSTbUWnjmDGNPiqu wajHjENcJq6xrnv09/OX2PhAzde25OWFsT85k+0f1rHJW/pKx441WyfEDe3WQe7rQc7e QJvL5hBGw5KeYc84gABd+FHlRDdMIPmt6HE3lLtXM7O7cZbtr695XsYcG1AHPf+notuU Ag2+rXB9srma5FRTggRxwN+GBEcEgnm3LXZYpAWUPOm1ZeXRyWhY5dmmY7MjhuMXrVMi qhCw== X-Gm-Message-State: AOAM530xkfwsC5gl8o8tP3DSe88HQgcVzg3DQmagj6jfvYvnmxjKjsK7 lP7sR/6tW+ZOM2Yo6zsVoObkMA== X-Google-Smtp-Source: ABdhPJzI8reFsWu/UuXzgR4I8CzdkHFXPt6lQKc6mTIg4f9YeNk6fLsiOG4G5tf5EmS8J8Ih6HebiQ== X-Received: by 2002:a1c:20c1:: with SMTP id g184mr4408905wmg.32.1606221214437; Tue, 24 Nov 2020 04:33:34 -0800 (PST) Received: from localhost.localdomain ([39.33.169.238]) by smtp.gmail.com with ESMTPSA id w3sm5409034wma.3.2020.11.24.04.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 04:33:33 -0800 (PST) From: Ibtisam Tariq To: maxime.coquelin@redhat.com, chenbo.xia@intel.com, cristian.dumitrescu@intel.com, jasvinder.singh@intel.com, john.mcnamara@intel.com, reshma.pattan@intel.com, konstantin.ananyev@intel.com, marko.kovacevic@intel.com Cc: dev@dpdk.org, Ibtisam Tariq , sergio.gonzalez.monroy@intel.com, phil.yang@arm.com Date: Tue, 24 Nov 2020 12:32:45 +0000 Message-Id: <20201124123249.14451-3-ibtisam.tariq@emumba.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201124123249.14451-1-ibtisam.tariq@emumba.com> References: <20201124123249.14451-1-ibtisam.tariq@emumba.com> Subject: [dpdk-dev] [PATCH 3/7] examples/packet_ordering: enhance getopt_long usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Instead of using getopt_long return value, strcmp was used to compare the input parameters with the struct option array. This patch get rid of all those strcmp by directly binding each longopt with an int enum. This is to improve readability and consistency in all examples. Bugzilla ID: 238 Cc: sergio.gonzalez.monroy@intel.com Cc: phil.yang@arm.com Reported-by: David Marchand Signed-off-by: Ibtisam Tariq --- v3: * None. v2: * Remove extra indentations. * Remove extra block brackets in switch statement. * Change enum names to start with OPT_ and remove KEYWORD from enum names. v1: * enhance getopt_long usage. --- examples/packet_ordering/main.c | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c index 4bea1982d..32e58c9cd 100644 --- a/examples/packet_ordering/main.c +++ b/examples/packet_ordering/main.c @@ -29,6 +29,13 @@ /* Macros for printing using RTE_LOG */ #define RTE_LOGTYPE_REORDERAPP RTE_LOGTYPE_USER1 +enum { +#define OPT_DISABLE_REORDER "disable-reorder" + OPT_DISABLE_REORDER_NUM = 256, +#define OPT_INSIGHT_WORKER "insight-worker" + OPT_INSIGHT_WORKER_NUM, +}; + unsigned int portmask; unsigned int disable_reorder; unsigned int insight_worker; @@ -157,9 +164,9 @@ parse_args(int argc, char **argv) char **argvopt; char *prgname = argv[0]; static struct option lgopts[] = { - {"disable-reorder", 0, 0, 0}, - {"insight-worker", 0, 0, 0}, - {NULL, 0, 0, 0} + {OPT_DISABLE_REORDER, 0, NULL, OPT_DISABLE_REORDER_NUM}, + {OPT_INSIGHT_WORKER, 0, NULL, OPT_INSIGHT_WORKER_NUM }, + {NULL, 0, 0, 0 } }; argvopt = argv; @@ -176,18 +183,18 @@ parse_args(int argc, char **argv) return -1; } break; + /* long options */ - case 0: - if (!strcmp(lgopts[option_index].name, "disable-reorder")) { - printf("reorder disabled\n"); - disable_reorder = 1; - } - if (!strcmp(lgopts[option_index].name, - "insight-worker")) { - printf("print all worker statistics\n"); - insight_worker = 1; - } + case OPT_DISABLE_REORDER_NUM: + printf("reorder disabled\n"); + disable_reorder = 1; + break; + + case OPT_INSIGHT_WORKER_NUM: + printf("print all worker statistics\n"); + insight_worker = 1; break; + default: print_usage(prgname); return -1;