diff mbox series

[v1,2/2] app/testpmd: support extended RSS offload types

Message ID 20201116053238.440870-3-simei.su@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers show
Series extend RSS offload types | expand

Checks

Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional fail Functional Testing issues
ci/iol-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Simei Su Nov. 16, 2020, 5:32 a.m. UTC
This patch adds testpmd cmdline support for eCPRI.

Signed-off-by: Simei Su <simei.su@intel.com>
---
 app/test-pmd/cmdline.c | 9 ++++++---
 app/test-pmd/config.c  | 3 ++-
 2 files changed, 8 insertions(+), 4 deletions(-)

Comments

Ferruh Yigit Nov. 17, 2020, 1:11 p.m. UTC | #1
On 11/16/2020 5:32 AM, Simei Su wrote:
> This patch adds testpmd cmdline support for eCPRI.
> 
> Signed-off-by: Simei Su <simei.su@intel.com>
> ---
>   app/test-pmd/cmdline.c | 9 ++++++---
>   app/test-pmd/config.c  | 3 ++-
>   2 files changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 5e2881e..e5f3462 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -2164,7 +2164,8 @@ cmd_config_rss_parsed(void *parsed_result,
>   		rss_conf.rss_hf = ETH_RSS_ETH | ETH_RSS_VLAN | ETH_RSS_IP |
>   			ETH_RSS_TCP | ETH_RSS_UDP | ETH_RSS_SCTP |
>   			ETH_RSS_L2_PAYLOAD | ETH_RSS_L2TPV3 | ETH_RSS_ESP |
> -			ETH_RSS_AH | ETH_RSS_PFCP | ETH_RSS_GTPU;
> +			ETH_RSS_AH | ETH_RSS_PFCP | ETH_RSS_GTPU |
> +			ETH_RSS_ECPRI;
>   	else if (!strcmp(res->value, "eth"))
>   		rss_conf.rss_hf = ETH_RSS_ETH;
>   	else if (!strcmp(res->value, "vlan"))
> @@ -2223,6 +2224,8 @@ cmd_config_rss_parsed(void *parsed_result,
>   		rss_conf.rss_hf = ETH_RSS_PPPOE;
>   	else if (!strcmp(res->value, "gtpu"))
>   		rss_conf.rss_hf = ETH_RSS_GTPU;
> +	else if (!strcmp(res->value, "ecpri"))
> +		rss_conf.rss_hf = ETH_RSS_ECPRI;
>   	else if (!strcmp(res->value, "none"))
>   		rss_conf.rss_hf = 0;
>   	else if (!strcmp(res->value, "level-default")) {

Can you please update 'cmd_config_rss.help_str' to add the 'ecpri'?

Also please update 'cmd_help_long_parsed()', "port config all rss ..." cmd to 
add the 'ecpri'.

And please update the documentation 
(doc/guides/testpmd_app_ug/testpmd_funcs.rst), add 'ecpri' to the section "port 
config - RSS"
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 5e2881e..e5f3462 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -2164,7 +2164,8 @@  cmd_config_rss_parsed(void *parsed_result,
 		rss_conf.rss_hf = ETH_RSS_ETH | ETH_RSS_VLAN | ETH_RSS_IP |
 			ETH_RSS_TCP | ETH_RSS_UDP | ETH_RSS_SCTP |
 			ETH_RSS_L2_PAYLOAD | ETH_RSS_L2TPV3 | ETH_RSS_ESP |
-			ETH_RSS_AH | ETH_RSS_PFCP | ETH_RSS_GTPU;
+			ETH_RSS_AH | ETH_RSS_PFCP | ETH_RSS_GTPU |
+			ETH_RSS_ECPRI;
 	else if (!strcmp(res->value, "eth"))
 		rss_conf.rss_hf = ETH_RSS_ETH;
 	else if (!strcmp(res->value, "vlan"))
@@ -2223,6 +2224,8 @@  cmd_config_rss_parsed(void *parsed_result,
 		rss_conf.rss_hf = ETH_RSS_PPPOE;
 	else if (!strcmp(res->value, "gtpu"))
 		rss_conf.rss_hf = ETH_RSS_GTPU;
+	else if (!strcmp(res->value, "ecpri"))
+		rss_conf.rss_hf = ETH_RSS_ECPRI;
 	else if (!strcmp(res->value, "none"))
 		rss_conf.rss_hf = 0;
 	else if (!strcmp(res->value, "level-default")) {
@@ -2407,7 +2410,7 @@  cmdline_parse_token_string_t cmd_config_rss_hash_key_rss_type =
 				 "ipv6-tcp-ex#ipv6-udp-ex#"
 				 "l3-src-only#l3-dst-only#l4-src-only#l4-dst-only#"
 				 "l2-src-only#l2-dst-only#s-vlan#c-vlan#"
-				 "l2tpv3#esp#ah#pfcp#pppoe#gtpu");
+				 "l2tpv3#esp#ah#pfcp#pppoe#gtpu#ecpri");
 cmdline_parse_token_string_t cmd_config_rss_hash_key_value =
 	TOKEN_STRING_INITIALIZER(struct cmd_config_rss_hash_key, key, NULL);
 
@@ -2420,7 +2423,7 @@  cmdline_parse_inst_t cmd_config_rss_hash_key = {
 		"l2-payload|ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex|"
 		"l3-src-only|l3-dst-only|l4-src-only|l4-dst-only|"
 		"l2-src-only|l2-dst-only|s-vlan|c-vlan|"
-		"l2tpv3|esp|ah|pfcp|pppoe|gtpu "
+		"l2tpv3|esp|ah|pfcp|pppoe|gtpu|ecpri "
 		"<string of hex digits (variable length, NIC dependent)>",
 	.tokens = {
 		(void *)&cmd_config_rss_hash_key_port,
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 91e7542..b51de59 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -87,7 +87,7 @@  const struct rss_type_info rss_type_table[] = {
 	{ "all", ETH_RSS_ETH | ETH_RSS_VLAN | ETH_RSS_IP | ETH_RSS_TCP |
 		ETH_RSS_UDP | ETH_RSS_SCTP | ETH_RSS_L2_PAYLOAD |
 		ETH_RSS_L2TPV3 | ETH_RSS_ESP | ETH_RSS_AH | ETH_RSS_PFCP |
-		ETH_RSS_GTPU},
+		ETH_RSS_GTPU | ETH_RSS_ECPRI},
 	{ "none", 0 },
 	{ "eth", ETH_RSS_ETH },
 	{ "l2-src-only", ETH_RSS_L2_SRC_ONLY },
@@ -136,6 +136,7 @@  const struct rss_type_info rss_type_table[] = {
 	{ "pfcp", ETH_RSS_PFCP },
 	{ "pppoe", ETH_RSS_PPPOE },
 	{ "gtpu", ETH_RSS_GTPU },
+	{ "ecpri", ETH_RSS_ECPRI },
 	{ NULL, 0 },
 };