From patchwork Fri Nov 6 02:10:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiawen Wu X-Patchwork-Id: 83780 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4280A0524; Fri, 6 Nov 2020 03:09:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 319A41D9E; Fri, 6 Nov 2020 03:09:42 +0100 (CET) Received: from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130]) by dpdk.org (Postfix) with ESMTP id 55FA0100C for ; Fri, 6 Nov 2020 03:09:36 +0100 (CET) X-QQ-mid: bizesmtp17t1604628570t6ws1cj7 Received: from localhost.localdomain.com (unknown [183.129.236.74]) by esmtp6.qq.com (ESMTP) with id ; Fri, 06 Nov 2020 10:09:24 +0800 (CST) X-QQ-SSF: 01400000002000C0C000B00A0000000 X-QQ-FEAT: tgXHSoBo5rGYlZMyvGQQKgE9A07laetUtjZNw9O6O09LzYz3aXepL85xN6yrZ zA3hexyhYglCfW8egRsdJpM7hWOob3Z3cX2Aya0qx1xf2He0FsorKh+LL2D8lysQt0pc3mz I9x0wduB1I3pnCjpPiGTZD7IbTDk+E7lXH/ER0Z8XkqUCGUylDRcPJSDL528Q0nHSKj/KjU 915QSLL7gTbMeviJb3Or/8I6JDxd0vLUTUf5q2/qGg9cbMDg1zxroo/jUyzXPNRkMfjyAA5 TRVY4ZSQgDao8oZomtxNQZt8te9HUK+7XVCUZfgsDYZt/fBImiblhb0gytB3Ea0dlWHw== X-QQ-GoodBg: 2 From: Jiawen Wu To: dev@dpdk.org Cc: Jiawen Wu Date: Fri, 6 Nov 2020 10:10:53 +0800 Message-Id: <20201106021053.2015777-1-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.18.4 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign7 X-QQ-Bgrelay: 1 Subject: [dpdk-dev] [PATCH] net/txgbe: remove warning functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Remove rte_panic(), and use rte_atomic_thread_fence() instead of rte_smp_[r/w]mb. Signed-off-by: Jiawen Wu Reviewed-by: Ferruh Yigit --- drivers/net/txgbe/base/txgbe_osdep.h | 2 +- drivers/net/txgbe/txgbe_rxtx.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/txgbe/base/txgbe_osdep.h b/drivers/net/txgbe/base/txgbe_osdep.h index f3d443ad3..756eb50eb 100644 --- a/drivers/net/txgbe/base/txgbe_osdep.h +++ b/drivers/net/txgbe/base/txgbe_osdep.h @@ -27,7 +27,7 @@ #define ASSERT(x) do { \ if (!(x)) \ - rte_panic("TXGBE: x"); \ + PMD_DRV_LOG(ERR, "TXGBE: %d", x); \ } while (0) #define usec_delay(x) rte_delay_us(x) diff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c index 00214b48f..82dde509a 100644 --- a/drivers/net/txgbe/txgbe_rxtx.c +++ b/drivers/net/txgbe/txgbe_rxtx.c @@ -1145,7 +1145,7 @@ txgbe_rx_scan_hw_ring(struct txgbe_rx_queue *rxq) for (j = 0; j < LOOK_AHEAD; j++) s[j] = rte_le_to_cpu_32(rxdp[j].qw1.lo.status); - rte_smp_rmb(); + rte_atomic_thread_fence(__ATOMIC_ACQUIRE); /* Compute how many status bits were set */ for (nb_dd = 0; nb_dd < LOOK_AHEAD &&