From patchwork Wed Nov 4 18:58:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dharmik Thakkar X-Patchwork-Id: 83699 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEC7AA04B1; Wed, 4 Nov 2020 19:59:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 77ED92C15; Wed, 4 Nov 2020 19:59:19 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 2316C2986; Wed, 4 Nov 2020 19:59:14 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 68EB61516; Wed, 4 Nov 2020 10:59:12 -0800 (PST) Received: from localhost.localdomain (2p2660v4-1.austin.arm.com [10.118.13.220]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5A6A63F718; Wed, 4 Nov 2020 10:59:12 -0800 (PST) From: Dharmik Thakkar To: Bruce Richardson , Vladimir Medvedkin , Gavin Hu , Honnappa Nagarahalli , Ruifeng Wang Cc: dev@dpdk.org, nd@arm.com, Dharmik Thakkar , stable@dpdk.org Date: Wed, 4 Nov 2020 12:58:56 -0600 Message-Id: <20201104185858.18397-3-dharmik.thakkar@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201104185858.18397-1-dharmik.thakkar@arm.com> References: <20201103222352.11566-1-dharmik.thakkar@arm.com> <20201104185858.18397-1-dharmik.thakkar@arm.com> Subject: [dpdk-dev] [PATCH v5 2/4] test/lpm: return error on failure in rcu qsbr perf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Return error if Add/Delete fail in multiwriter perf test Return error if single or multi writer test fails Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") Cc: honnappa.nagarahalli@arm.com Cc: stable@dpdk.org Signed-off-by: Dharmik Thakkar Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli Acked-by: Vladimir Medvedkin --- app/test/test_lpm_perf.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c index 45164b23214b..873ecf511c97 100644 --- a/app/test/test_lpm_perf.c +++ b/app/test/test_lpm_perf.c @@ -453,6 +453,7 @@ test_lpm_rcu_qsbr_writer(void *arg) next_hop_add) != 0) { printf("Failed to add iteration %d, route# %d\n", i, j); + goto error; } pthread_mutex_unlock(&lpm_mutex); } @@ -464,6 +465,7 @@ test_lpm_rcu_qsbr_writer(void *arg) large_ldepth_route_table[j].depth) != 0) { printf("Failed to delete iteration %d, route# %d\n", i, j); + goto error; } pthread_mutex_unlock(&lpm_mutex); } @@ -474,6 +476,10 @@ test_lpm_rcu_qsbr_writer(void *arg) __atomic_fetch_add(&gwrite_cycles, total_cycles, __ATOMIC_RELAXED); return 0; + +error: + pthread_mutex_unlock(&lpm_mutex); + return -1; } /* @@ -947,9 +953,11 @@ test_lpm_perf(void) rte_lpm_delete_all(lpm); rte_lpm_free(lpm); - test_lpm_rcu_perf(); + if (test_lpm_rcu_perf() < 0) + return -1; - test_lpm_rcu_perf_multi_writer(); + if (test_lpm_rcu_perf_multi_writer() < 0) + return -1; return 0; }