diff mbox series

net/enic: check return code

Message ID 20201014202522.7466-1-johndale@cisco.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/enic: check return code |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional fail Functional Testing issues
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

John Daley (johndale) Oct. 14, 2020, 8:25 p.m. UTC 
Coverity issue: 363046
Fixes: bb66d562aefc ("net/enic: share flow actions with same signature")

Signed-off-by: John Daley <johndale@cisco.com>
---
 drivers/net/enic/enic_fm_flow.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Ferruh Yigit Oct. 14, 2020, 9:31 p.m. UTC | #1 
On 10/14/2020 9:25 PM, John Daley wrote:
> Coverity issue: 363046
> Fixes: bb66d562aefc ("net/enic: share flow actions with same signature")
> 
> Signed-off-by: John Daley <johndale@cisco.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/drivers/net/enic/enic_fm_flow.c b/drivers/net/enic/enic_fm_flow.c
index 96ec360a85..9cea94269c 100644
--- a/drivers/net/enic/enic_fm_flow.c
+++ b/drivers/net/enic/enic_fm_flow.c
@@ -2232,7 +2232,11 @@  enic_action_handle_get(struct enic_flowman *fm, struct fm_action *action_in,
 error_with_action_handle:
 	args[0] = FM_ACTION_FREE;
 	args[1] = ah->handle;
-	flowman_cmd(fm, args, 2);
+	ret = flowman_cmd(fm, args, 2);
+	if (ret != 0)
+		rte_flow_error_set(error, -ret,
+				   RTE_FLOW_ERROR_TYPE_UNSPECIFIED,
+				   NULL, "enic: devcmd(action-free)");
 error_with_ah:
 	free(ah);
 	return ret;