diff mbox series

net/octeontx2: fix rss flow create

Message ID 20201010063310.809945-1-kirankumark@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers show
Series net/octeontx2: fix rss flow create | expand

Checks

Context Check Description
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/checkpatch success coding style OK

Commit Message

Kiran Kumar Kokkilagadda Oct. 10, 2020, 6:33 a.m. UTC
From: Kiran Kumar K <kirankumark@marvell.com>

While creating flow with action type RSS, action type is not being
set to RSS, and action type is being set to unicast. Therefore it breaks
RSS functionality. This patch add changes to program the RSS action
properly.

Fixes: 4092e4845d ("net/octeontx2: add flow operations")

Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
---
 drivers/net/octeontx2/otx2_flow.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jerin Jacob Oct. 11, 2020, 9:37 a.m. UTC | #1
On Sat, Oct 10, 2020 at 12:03 PM <kirankumark@marvell.com> wrote:
>
> From: Kiran Kumar K <kirankumark@marvell.com>
>
> While creating flow with action type RSS, action type is not being
> set to RSS, and action type is being set to unicast. Therefore it breaks
> RSS functionality. This patch add changes to program the RSS action
> properly.
>
> Fixes: 4092e4845d ("net/octeontx2: add flow operations")

Cc: stable@dpdk.org

Applied to dpdk-next-net-mrvl/for-main. Thanks.

>
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
> ---
>  drivers/net/octeontx2/otx2_flow.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/octeontx2/otx2_flow.c b/drivers/net/octeontx2/otx2_flow.c
> index 13a76e441..90540ffbd 100644
> --- a/drivers/net/octeontx2/otx2_flow.c
> +++ b/drivers/net/octeontx2/otx2_flow.c
> @@ -270,6 +270,8 @@ flow_program_rss_action(struct rte_eth_dev *eth_dev,
>                         if (rc)
>                                 return rc;
>
> +                       flow->npc_action &= (~(0xfULL));
> +                       flow->npc_action |= NIX_RX_ACTIONOP_RSS;
>                         flow->npc_action |=
>                                 ((uint64_t)(alg_idx & NIX_RSS_ACT_ALG_MASK) <<
>                                  NIX_RSS_ACT_ALG_OFFSET) |
> --
> 2.25.1
>
diff mbox series

Patch

diff --git a/drivers/net/octeontx2/otx2_flow.c b/drivers/net/octeontx2/otx2_flow.c
index 13a76e441..90540ffbd 100644
--- a/drivers/net/octeontx2/otx2_flow.c
+++ b/drivers/net/octeontx2/otx2_flow.c
@@ -270,6 +270,8 @@  flow_program_rss_action(struct rte_eth_dev *eth_dev,
 			if (rc)
 				return rc;
 
+			flow->npc_action &= (~(0xfULL));
+			flow->npc_action |= NIX_RX_ACTIONOP_RSS;
 			flow->npc_action |=
 				((uint64_t)(alg_idx & NIX_RSS_ACT_ALG_MASK) <<
 				 NIX_RSS_ACT_ALG_OFFSET) |