[v3,3/3] examples/l3fwd-acl: add support for AVX512

Message ID 20201006171618.19374-4-konstantin.ananyev@intel.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series Few enhancements for l3fwd-acl |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-testing fail Testing issues
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation fail apply issues

Commit Message

Ananyev, Konstantin Oct. 6, 2020, 5:16 p.m. UTC
  Add ability to select AVX512 classify algorithm.

Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
Depends-on: series-12721 ("acl: introduce AVX512 classify methods")

 doc/guides/sample_app_ug/l3_forward_access_ctrl.rst | 2 +-
 examples/l3fwd-acl/main.c                           | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)
  

Comments

David Marchand Oct. 15, 2020, 12:11 p.m. UTC | #1
On Tue, Oct 6, 2020 at 7:17 PM Konstantin Ananyev
<konstantin.ananyev@intel.com> wrote:
>
> Add ability to select AVX512 classify algorithm.
>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

No need to separate this from patch 2, right?
  
Ananyev, Konstantin Oct. 15, 2020, 12:42 p.m. UTC | #2
> On Tue, Oct 6, 2020 at 7:17 PM Konstantin Ananyev
> <konstantin.ananyev@intel.com> wrote:
> >
> > Add ability to select AVX512 classify algorithm.
> >
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 
> No need to separate this from patch 2, right?
> 

Yes, could be squashed into one, I think.
  

Patch

diff --git a/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst b/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst
index 80dd8ba008..6e4d17a2a8 100644
--- a/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst
+++ b/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst
@@ -253,7 +253,7 @@  where,
 *   --rule_ipv6 FILENAME: Specifies the IPv6 ACL and route rules file
 
 *   --alg=<val>: optional, ACL classify method to use, one of:
-    ``scalar|sse|avx2|neon|altivec``
+    ``scalar|sse|avx2|neon|altivec|avx512x16|avx512x32``
 
 *   --enable-jumbo: optional, enables jumbo frames
 
diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c
index c27d4025e8..cbb92abdb3 100644
--- a/examples/l3fwd-acl/main.c
+++ b/examples/l3fwd-acl/main.c
@@ -170,6 +170,14 @@  static const struct {
 		.name = "altivec",
 		.alg = RTE_ACL_CLASSIFY_ALTIVEC,
 	},
+	{
+		.name = "avx512x16",
+		.alg = RTE_ACL_CLASSIFY_AVX512X16,
+	},
+	{
+		.name = "avx512x32",
+		.alg = RTE_ACL_CLASSIFY_AVX512X32,
+	},
 };
 
 /***********************start of ACL part******************************/