diff mbox series

[v3,08/18] net/fm10k: add checks for max SIMD bitwidth

Message ID	20200930130415.11211-9-ciara.power@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	David Marchand
Headers	IronPort-SDR: DPhZhsM5UHUvK1CqpqXQDHcxLPp+MAgQxtKk209d6SW9Ag4zD4gIavjlhBWetKEcrqD3M4Aqqs dL+g8lThQC7Q== IronPort-SDR: gW+a7K67X8/iwiONdMPkZUSOWEb5VzqJOaB3zzEkgacAyZlfKEc5FVXxsH90HVhOyGYVivBi3Q K+rcK2KJAIAw== From: Ciara Power <ciara.power@intel.com> To: dev@dpdk.org Cc: Ciara Power <ciara.power@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Xiao Wang <xiao.w.wang@intel.com> Date: Wed, 30 Sep 2020 14:04:04 +0100 Message-Id: <20200930130415.11211-9-ciara.power@intel.com> In-Reply-To: <20200930130415.11211-1-ciara.power@intel.com> References: <20200807155859.63888-1-ciara.power@intel.com> <20200930130415.11211-1-ciara.power@intel.com> Subject: [dpdk-dev] [PATCH v3 08/18] net/fm10k: add checks for max SIMD bitwidth Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	add max SIMD bitwidth to EAL \| [v3,00/18] add max SIMD bitwidth to EAL [v3,01/18] eal: add max SIMD bitwidth [v3,02/18] eal: add default SIMD bitwidth values [v3,03/18] doc: add detail on using max SIMD bitwidth [v3,04/18] net/i40e: add checks for max SIMD bitwidth [v3,05/18] net/axgbe: add checks for max SIMD bitwidth [v3,06/18] net/bnxt: add checks for max SIMD bitwidth [v3,07/18] net/enic: add checks for max SIMD bitwidth [v3,08/18] net/fm10k: add checks for max SIMD bitwidth [v3,09/18] net/iavf: add checks for max SIMD bitwidth [v3,10/18] net/ice: add checks for max SIMD bitwidth [v3,11/18] net/ixgbe: add checks for max SIMD bitwidth [v3,12/18] net/mlx5: add checks for max SIMD bitwidth [v3,13/18] net/virtio: add checks for max SIMD bitwidth [v3,14/18] distributor: add checks for max SIMD bitwidth [v3,15/18] member: add checks for max SIMD bitwidth [v3,16/18] efd: add checks for max SIMD bitwidth [v3,17/18] net: add checks for max SIMD bitwidth [v3,18/18] lpm: choose vector path at runtime

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Power, Ciara Sept. 30, 2020, 1:04 p.m. UTC

When choosing a vector path to take, an extra condition must be
satisfied to ensure the max SIMD bitwidth allows for the CPU enabled
path.

Cc: Qi Zhang <qi.z.zhang@intel.com>
Cc: Xiao Wang <xiao.w.wang@intel.com>

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 drivers/net/fm10k/fm10k_ethdev.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

Comments

Qi Zhang Oct. 9, 2020, 12:18 a.m. UTC | #1

> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Wednesday, September 30, 2020 9:04 PM
> To: dev@dpdk.org
> Cc: Power, Ciara <ciara.power@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>
> Subject: [PATCH v3 08/18] net/fm10k: add checks for max SIMD bitwidth
> 
> When choosing a vector path to take, an extra condition must be satisfied to
> ensure the max SIMD bitwidth allows for the CPU enabled path.
> 
> Cc: Qi Zhang <qi.z.zhang@intel.com>
> Cc: Xiao Wang <xiao.w.wang@intel.com>
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

> ---
>  drivers/net/fm10k/fm10k_ethdev.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/fm10k/fm10k_ethdev.c
> b/drivers/net/fm10k/fm10k_ethdev.c
> index 5771d83b55..a8bc1036a3 100644
> --- a/drivers/net/fm10k/fm10k_ethdev.c
> +++ b/drivers/net/fm10k/fm10k_ethdev.c
> @@ -2930,7 +2930,9 @@ fm10k_set_tx_function(struct rte_eth_dev *dev)
>  	if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
>  		/* primary process has set the ftag flag and offloads */
>  		txq = dev->data->tx_queues[0];
> -		if (fm10k_tx_vec_condition_check(txq)) {
> +		if (fm10k_tx_vec_condition_check(txq) ||
> +				rte_get_max_simd_bitwidth()
> +				< RTE_MAX_128_SIMD) {
>  			dev->tx_pkt_burst = fm10k_xmit_pkts;
>  			dev->tx_pkt_prepare = fm10k_prep_pkts;
>  			PMD_INIT_LOG(DEBUG, "Use regular Tx func"); @@ -2949,7
> +2951,8 @@ fm10k_set_tx_function(struct rte_eth_dev *dev)
>  		txq = dev->data->tx_queues[i];
>  		txq->tx_ftag_en = tx_ftag_en;
>  		/* Check if Vector Tx is satisfied */
> -		if (fm10k_tx_vec_condition_check(txq))
> +		if (fm10k_tx_vec_condition_check(txq) ||
> +				rte_get_max_simd_bitwidth() < RTE_MAX_128_SIMD)
>  			use_sse = 0;
>  	}
> 
> @@ -2983,7 +2986,9 @@ fm10k_set_rx_function(struct rte_eth_dev *dev)
>  	 * conditions to be met.
>  	 */
>  	if (!fm10k_rx_vec_condition_check(dev) &&
> -			dev_info->rx_vec_allowed && !rx_ftag_en) {
> +			dev_info->rx_vec_allowed && !rx_ftag_en &&
> +				rte_get_max_simd_bitwidth()
> +				>= RTE_MAX_128_SIMD) {
>  		if (dev->data->scattered_rx)
>  			dev->rx_pkt_burst = fm10k_recv_scattered_pkts_vec;
>  		else
> --
> 2.17.1

diff mbox series

Patch

diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index 5771d83b55..a8bc1036a3 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -2930,7 +2930,9 @@  fm10k_set_tx_function(struct rte_eth_dev *dev)
 	if (rte_eal_process_type() != RTE_PROC_PRIMARY) {
 		/* primary process has set the ftag flag and offloads */
 		txq = dev->data->tx_queues[0];
-		if (fm10k_tx_vec_condition_check(txq)) {
+		if (fm10k_tx_vec_condition_check(txq) ||
+				rte_get_max_simd_bitwidth()
+				< RTE_MAX_128_SIMD) {
 			dev->tx_pkt_burst = fm10k_xmit_pkts;
 			dev->tx_pkt_prepare = fm10k_prep_pkts;
 			PMD_INIT_LOG(DEBUG, "Use regular Tx func");
@@ -2949,7 +2951,8 @@  fm10k_set_tx_function(struct rte_eth_dev *dev)
 		txq = dev->data->tx_queues[i];
 		txq->tx_ftag_en = tx_ftag_en;
 		/* Check if Vector Tx is satisfied */
-		if (fm10k_tx_vec_condition_check(txq))
+		if (fm10k_tx_vec_condition_check(txq) ||
+				rte_get_max_simd_bitwidth() < RTE_MAX_128_SIMD)
 			use_sse = 0;
 	}
 
@@ -2983,7 +2986,9 @@  fm10k_set_rx_function(struct rte_eth_dev *dev)
 	 * conditions to be met.
 	 */
 	if (!fm10k_rx_vec_condition_check(dev) &&
-			dev_info->rx_vec_allowed && !rx_ftag_en) {
+			dev_info->rx_vec_allowed && !rx_ftag_en &&
+				rte_get_max_simd_bitwidth()
+				>= RTE_MAX_128_SIMD) {
 		if (dev->data->scattered_rx)
 			dev->rx_pkt_burst = fm10k_recv_scattered_pkts_vec;
 		else