diff mbox series

[v3,14/18] distributor: add checks for max SIMD bitwidth

Message ID	20200930130415.11211-15-ciara.power@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	David Marchand
Headers	IronPort-SDR: sxR4k9TgJ1WqLmmlEq6EhtGu7lcd3JkyDRkKkDqQTxydlmKEDL5VoiPNODfAcN7WosUixEEMhl ZyhwnHDw1ppw== IronPort-SDR: fA5LH/deRl6RngHd71+7O5SvKDp3ARzbQ0SKiGUB7QQbjGk0GaLi1M2MNWAzi46R/DW5jaSm9R GHGtxms9ZJwg== From: Ciara Power <ciara.power@intel.com> To: dev@dpdk.org Cc: Ciara Power <ciara.power@intel.com>, David Hunt <david.hunt@intel.com> Date: Wed, 30 Sep 2020 14:04:10 +0100 Message-Id: <20200930130415.11211-15-ciara.power@intel.com> In-Reply-To: <20200930130415.11211-1-ciara.power@intel.com> References: <20200807155859.63888-1-ciara.power@intel.com> <20200930130415.11211-1-ciara.power@intel.com> Subject: [dpdk-dev] [PATCH v3 14/18] distributor: add checks for max SIMD bitwidth Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	add max SIMD bitwidth to EAL \| [v3,00/18] add max SIMD bitwidth to EAL [v3,01/18] eal: add max SIMD bitwidth [v3,02/18] eal: add default SIMD bitwidth values [v3,03/18] doc: add detail on using max SIMD bitwidth [v3,04/18] net/i40e: add checks for max SIMD bitwidth [v3,05/18] net/axgbe: add checks for max SIMD bitwidth [v3,06/18] net/bnxt: add checks for max SIMD bitwidth [v3,07/18] net/enic: add checks for max SIMD bitwidth [v3,08/18] net/fm10k: add checks for max SIMD bitwidth [v3,09/18] net/iavf: add checks for max SIMD bitwidth [v3,10/18] net/ice: add checks for max SIMD bitwidth [v3,11/18] net/ixgbe: add checks for max SIMD bitwidth [v3,12/18] net/mlx5: add checks for max SIMD bitwidth [v3,13/18] net/virtio: add checks for max SIMD bitwidth [v3,14/18] distributor: add checks for max SIMD bitwidth [v3,15/18] member: add checks for max SIMD bitwidth [v3,16/18] efd: add checks for max SIMD bitwidth [v3,17/18] net: add checks for max SIMD bitwidth [v3,18/18] lpm: choose vector path at runtime

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Power, Ciara Sept. 30, 2020, 1:04 p.m. UTC

When choosing a vector path to take, an extra condition must be
satisfied to ensure the max SIMD bitwidth allows for the CPU enabled
path.

Cc: David Hunt <david.hunt@intel.com>

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 lib/librte_distributor/rte_distributor.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Hunt, David Oct. 6, 2020, 12:17 p.m. UTC | #1

Hi Ciara,

On 30/9/2020 2:04 PM, Ciara Power wrote:
> When choosing a vector path to take, an extra condition must be
> satisfied to ensure the max SIMD bitwidth allows for the CPU enabled
> path.
>
> Cc: David Hunt <david.hunt@intel.com>
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
>   lib/librte_distributor/rte_distributor.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c
> index 1c047f065a..9f0a9b1d48 100644
> --- a/lib/librte_distributor/rte_distributor.c
> +++ b/lib/librte_distributor/rte_distributor.c
> @@ -636,7 +636,8 @@ rte_distributor_create(const char *name,
>   
>   	d->dist_match_fn = RTE_DIST_MATCH_SCALAR;
>   #if defined(RTE_ARCH_X86)
> -	d->dist_match_fn = RTE_DIST_MATCH_VECTOR;
> +	if (rte_get_max_simd_bitwidth() >= RTE_MAX_128_SIMD)
> +		d->dist_match_fn = RTE_DIST_MATCH_VECTOR;
>   #endif
>   
>   	/*


Acked-by: David Hunt <david.hunt@intel.com>

diff mbox series

Patch

diff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c
index 1c047f065a..9f0a9b1d48 100644
--- a/lib/librte_distributor/rte_distributor.c
+++ b/lib/librte_distributor/rte_distributor.c
@@ -636,7 +636,8 @@  rte_distributor_create(const char *name,
 
 	d->dist_match_fn = RTE_DIST_MATCH_SCALAR;
 #if defined(RTE_ARCH_X86)
-	d->dist_match_fn = RTE_DIST_MATCH_VECTOR;
+	if (rte_get_max_simd_bitwidth() >= RTE_MAX_128_SIMD)
+		d->dist_match_fn = RTE_DIST_MATCH_VECTOR;
 #endif
 
 	/*