From patchwork Thu Sep 17 05:30:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 77968 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91165A04B6; Thu, 17 Sep 2020 07:32:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 829881D562; Thu, 17 Sep 2020 07:31:05 +0200 (CEST) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by dpdk.org (Postfix) with ESMTP id 735501D554 for ; Thu, 17 Sep 2020 07:31:00 +0200 (CEST) Received: by mail-lf1-f66.google.com with SMTP id x69so782648lff.3 for ; Wed, 16 Sep 2020 22:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RxNWGt0esRwLrguNnMGRCh7E9ELHdYdWKRyQw7hPsQE=; b=JMBPirzMsYfxq11n7W1xYHnwTOyOCm25wENfcuKDltprS8+aFSpmdZhYf5lJko0RYD ttk6GGBU8G3dKDST4prjZx6rBdDlGWXnkzDTOKLQRiumFQ+Z2AYWD7Fv/D0Oa+1Asezr PFNPIdOQ8j3jo6nKzm5t/ZwvcvAaTUHiFXS4QnNbbaqFtTBIxKw1xhyLM24wgCBJ6xaI GJj8cBYDRpeTcES9R8XLE7WkdXEL8UoBCgBaS/3RLbhORaCTI9JBgT9xGvkQTYkID1a+ zj4KZN+zwhVW9LCBLL/KFdKG8rvsWbqE4scSFQ27tnm2/kH9Z3YXufpaN+W2ybcchc/q 1vvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RxNWGt0esRwLrguNnMGRCh7E9ELHdYdWKRyQw7hPsQE=; b=iUWGlA34Txsp2GQn0zIavLeQFzC96i5/M8Kcp+WNzngx6AVzw0mQxfxuG5yHCNDmbR JEO8Ym5DEIVLz7ZpQcpynLxj9aQjGYX2PIP+GUerTWeY/rT0J/dX13pTKQQG7OlHpmHW mBFEIa55/m+MIaZQVm6DhiO532KQaJsigxQJNnI/J9hWrR02zEu8oEGmbXMqxP6T7XsL ZoAQC0dmMfrlFuuzm3RggT3uGo7IAaSkyy5xOMZoMc3GMa1+mPjlgm662S2eoaC0pqZE BmcJq4gOPftKOkXtWZz4IojgHQ/Ax2GWPfLI1ClYzeehuQ/mZE3AkYrDXqxkq87O3qTC qwDQ== X-Gm-Message-State: AOAM530DswEIou6Cw6EGz2nmYaVDlixs/XqYKvrd6BZtIrRUAEvggX+k +4Wf4qO+vnCNTl8LxmFIYWdfMqtGcqCVXfyj X-Google-Smtp-Source: ABdhPJyqVoDixwZzWLncE7O/+MKRZV9yuA/TSFGlkQhMbB9PAw1+W0RP1tBOtJ5JrbVXB32UnKEIEA== X-Received: by 2002:a19:be45:: with SMTP id o66mr8251355lff.44.1600320659760; Wed, 16 Sep 2020 22:30:59 -0700 (PDT) Received: from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl. [193.106.246.138]) by smtp.gmail.com with ESMTPSA id j3sm5033686lfb.185.2020.09.16.22.30.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 22:30:58 -0700 (PDT) From: Michal Krawczyk To: dev@dpdk.org Cc: gtzalik@amazon.com, igorch@amazon.com, Michal Krawczyk , Marcin Wojtas , Evgeny Schemeilin Date: Thu, 17 Sep 2020 07:30:23 +0200 Message-Id: <20200917053035.1889989-9-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200917053035.1889989-1-mk@semihalf.com> References: <20200917053035.1889989-1-mk@semihalf.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 08/20] net/ena/base: add ENI stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The Elastic Netfwork Interface (ENI) stats can be acquired from the HW. They can provide advanced values which can be further used by the application for better flow management. It isn't available to the DPDK application, yet. The PMD must expose them directly. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 19 +++++++++- drivers/net/ena/base/ena_com.h | 9 +++++ .../net/ena/base/ena_defs/ena_admin_defs.h | 37 ++++++++++++++++++- 3 files changed, 62 insertions(+), 3 deletions(-) diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c index b21c1f8d83..1463f5f1d4 100644 --- a/drivers/net/ena/base/ena_com.c +++ b/drivers/net/ena/base/ena_com.c @@ -2206,6 +2206,21 @@ static int ena_get_dev_stats(struct ena_com_dev *ena_dev, return ret; } +int ena_com_get_eni_stats(struct ena_com_dev *ena_dev, + struct ena_admin_eni_stats *stats) +{ + struct ena_com_stats_ctx ctx; + int ret; + + memset(&ctx, 0x0, sizeof(ctx)); + ret = ena_get_dev_stats(ena_dev, &ctx, ENA_ADMIN_GET_STATS_TYPE_ENI); + if (likely(ret == 0)) + memcpy(stats, &ctx.get_resp.u.eni_stats, + sizeof(ctx.get_resp.u.eni_stats)); + + return ret; +} + int ena_com_get_dev_basic_stats(struct ena_com_dev *ena_dev, struct ena_admin_basic_stats *stats) { @@ -2215,8 +2230,8 @@ int ena_com_get_dev_basic_stats(struct ena_com_dev *ena_dev, memset(&ctx, 0x0, sizeof(ctx)); ret = ena_get_dev_stats(ena_dev, &ctx, ENA_ADMIN_GET_STATS_TYPE_BASIC); if (likely(ret == 0)) - memcpy(stats, &ctx.get_resp.basic_stats, - sizeof(ctx.get_resp.basic_stats)); + memcpy(stats, &ctx.get_resp.u.basic_stats, + sizeof(ctx.get_resp.u.basic_stats)); return ret; } diff --git a/drivers/net/ena/base/ena_com.h b/drivers/net/ena/base/ena_com.h index 2acf6d8ae5..751bfcdd7e 100644 --- a/drivers/net/ena/base/ena_com.h +++ b/drivers/net/ena/base/ena_com.h @@ -600,6 +600,15 @@ int ena_com_get_dev_attr_feat(struct ena_com_dev *ena_dev, int ena_com_get_dev_basic_stats(struct ena_com_dev *ena_dev, struct ena_admin_basic_stats *stats); +/* ena_com_get_eni_stats - Get extended network interface statistics + * @ena_dev: ENA communication layer struct + * @stats: stats return value + * + * @return: 0 on Success and negative value otherwise. + */ +int ena_com_get_eni_stats(struct ena_com_dev *ena_dev, + struct ena_admin_eni_stats *stats); + /* ena_com_set_dev_mtu - Configure the device mtu. * @ena_dev: ENA communication layer struct * @mtu: mtu value diff --git a/drivers/net/ena/base/ena_defs/ena_admin_defs.h b/drivers/net/ena/base/ena_defs/ena_admin_defs.h index 6d266c4cf4..be1747cd9f 100644 --- a/drivers/net/ena/base/ena_defs/ena_admin_defs.h +++ b/drivers/net/ena/base/ena_defs/ena_admin_defs.h @@ -95,6 +95,8 @@ enum ena_admin_completion_policy_type { enum ena_admin_get_stats_type { ENA_ADMIN_GET_STATS_TYPE_BASIC = 0, ENA_ADMIN_GET_STATS_TYPE_EXTENDED = 1, + /* extra HW stats for specific network interface */ + ENA_ADMIN_GET_STATS_TYPE_ENI = 2, }; enum ena_admin_get_stats_scope { @@ -388,10 +390,43 @@ struct ena_admin_basic_stats { uint32_t tx_drops_high; }; +/* ENI Statistics Command. */ +struct ena_admin_eni_stats { + /* The number of packets shaped due to inbound aggregate BW + * allowance being exceeded + */ + uint64_t bw_in_allowance_exceeded; + + /* The number of packets shaped due to outbound aggregate BW + * allowance being exceeded + */ + uint64_t bw_out_allowance_exceeded; + + /* The number of packets shaped due to PPS allowance being exceeded */ + uint64_t pps_allowance_exceeded; + + /* The number of packets shaped due to connection tracking + * allowance being exceeded and leading to failure in establishment + * of new connections + */ + uint64_t conntrack_allowance_exceeded; + + /* The number of packets shaped due to linklocal packet rate + * allowance being exceeded + */ + uint64_t linklocal_allowance_exceeded; +}; + struct ena_admin_acq_get_stats_resp { struct ena_admin_acq_common_desc acq_common_desc; - struct ena_admin_basic_stats basic_stats; + union { + uint64_t raw[7]; + + struct ena_admin_basic_stats basic_stats; + + struct ena_admin_eni_stats eni_stats; + } u; }; struct ena_admin_get_set_feature_common_desc {