From patchwork Thu Sep 17 05:30:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 77973 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3C73A04B6; Thu, 17 Sep 2020 07:32:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8BEC81D585; Thu, 17 Sep 2020 07:31:14 +0200 (CEST) Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by dpdk.org (Postfix) with ESMTP id D014C1D56F for ; Thu, 17 Sep 2020 07:31:07 +0200 (CEST) Received: by mail-lj1-f195.google.com with SMTP id r24so900647ljm.3 for ; Wed, 16 Sep 2020 22:31:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NrNtQihIvJUKFUEgQMk6tw9kFNfQ9T8KGc+43DQP0Xk=; b=vrZ25P1zUEVpx3s0gtqcLYj9ciCjFnaZ0IGr9aGj7+Xf9JCtCOVD2pnRypLIkhytso VKH1azY+ZK80PdnTuhwLcW3sEU/dUBdRBx1yI+dbOHHnBBZ2tUjr5Yggdw7YD7nEPl8U DKfbgYYECesr0HQ10g8VP/lJXvNjYc0e/+GmxntjGavhspMWyy/Y0Cy0qRJDyDgOtIM0 Hl5cgMCAd+Sf3Bbc/BKyXWN6Jc817URwbs+ncxKcPTp7wzmkuh7seD+FuOnMWVvqGHKs H1Nas4BX0WYzSC/hNI/L1rPZ8gSpcVa/Drew6l61DmBrc6C/+M3pSiJpbJO3VhaJ8G8F XTBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NrNtQihIvJUKFUEgQMk6tw9kFNfQ9T8KGc+43DQP0Xk=; b=lL2PALyuB9/JUEUdEyOKR7eFVmqlBWM47dxZVVlE9Nj5SoxhxhcPreVTaRnbwgk1qz XInAUXMX5uqZ0ggGNBhNAxo3/j8tcQ8LKuNV7D4dxThyHn7gU1/OxR2hpEPcoQ7zfnkk 8kv6JZmd/0RmOw/NC2VlVEVYaCU5cj2xpUEyp6ox1bPSXMPLo8eGGv/gSTeUxzuakop7 foCxjqFCfu/0+G1B+rteLkKer7xJ1lEnZwbW/QuRmg4lCi075W4NS9rv1//4JXt/oYAd RmgBrcwFp6jDwy8Q2q9EDEEWDejPxxZE8I7jHpHVlJYzmywrWlaZaR1ySHqsdsUxyaD7 WOiQ== X-Gm-Message-State: AOAM532I0qq5ngDeiDJXkVpOJIWJC2hJ/npNTmAwKgXLrdZPygWO554y 1QAdugYO0MTplTbejyXoZ074LgT4NiKraVjt X-Google-Smtp-Source: ABdhPJwqAJb5Zcwn3utzHLeTGF174rR0P0lZPmoIUzwDI7DSrFSAFhdVxBwGyk4HWdvmDrKusugTdw== X-Received: by 2002:a2e:6f1c:: with SMTP id k28mr8809381ljc.297.1600320667103; Wed, 16 Sep 2020 22:31:07 -0700 (PDT) Received: from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl. [193.106.246.138]) by smtp.gmail.com with ESMTPSA id j3sm5033686lfb.185.2020.09.16.22.31.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 22:31:06 -0700 (PDT) From: Michal Krawczyk To: dev@dpdk.org Cc: gtzalik@amazon.com, igorch@amazon.com, Michal Krawczyk , Marcin Wojtas , Evgeny Schemeilin Date: Thu, 17 Sep 2020 07:30:28 +0200 Message-Id: <20200917053035.1889989-14-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200917053035.1889989-1-mk@semihalf.com> References: <20200917053035.1889989-1-mk@semihalf.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 13/20] net/ena/base: add missing unlikely X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" To align the error checking code with other parts of the ena_com, the conditional check is being tested for the error was wrapped inside unlikely(). Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c index f2668f79c7..3686ae05c4 100644 --- a/drivers/net/ena/base/ena_com.c +++ b/drivers/net/ena/base/ena_com.c @@ -2973,7 +2973,7 @@ int ena_com_config_dev_mode(struct ena_com_dev *ena_dev, ena_dev->tx_max_header_size = llq_info->desc_list_entry_size - (llq_info->descs_num_before_header * sizeof(struct ena_eth_io_tx_desc)); - if (ena_dev->tx_max_header_size == 0) { + if (unlikely(ena_dev->tx_max_header_size == 0)) { ena_trc_err("the size of the LLQ entry is smaller than needed\n"); return -EINVAL; }