From patchwork Thu Sep 17 05:30:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 77972 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30A79A04B6; Thu, 17 Sep 2020 07:32:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0EF8F1D57E; Thu, 17 Sep 2020 07:31:13 +0200 (CEST) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by dpdk.org (Postfix) with ESMTP id DEED91D566 for ; Thu, 17 Sep 2020 07:31:05 +0200 (CEST) Received: by mail-lf1-f66.google.com with SMTP id x69so782832lff.3 for ; Wed, 16 Sep 2020 22:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ezVq2xd/mapEl8AKjQmhi3tI0BWuXXRaPbNGIPiI59o=; b=dlms8HPD0hpONMIcchIbgFL2EMIYTY9gQcyKKsWYjhiC/veOij6w4Loj6ItAHjHYyw 1Pd7LF1OSi24wsCtCziGEVq3qA7PzR+kpqkgc84R/JzdX2dK6kjZaSUb0ecx9AVKoggP q1cjKyemmMM1RNS0kTnXECslZqv/iC38/RLCq2I0gFW9WG2IUx3m8GeVzKpvui2Ylinf PqWfNI4EmKtqArKpd5iRZetpkB3lJnS7KSIxu+udyTFSbljX1l+L+OUzZK8aLMaLQRMN nZ+CN5E78gMOjeC+PnWQ4UHVh4ipYyaccf6nNcvt1U8F5Wj5xbfKzYSSVpzIdYNMZxjQ qjUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ezVq2xd/mapEl8AKjQmhi3tI0BWuXXRaPbNGIPiI59o=; b=Q7/v9CvxVNPCtZuBaYQJVb85hoHvo2ynukKSW8Rl1UGqUk7OB9ZBhKbjvPqd37JpVk j0CoD92+7gxZjob+Uxa4gR8UteXqS1aIP8JgJeQ6HGzzPfQvOXvQWO1GOmALaVVRd1El MVU/7W4DoQYjGXdHlWmKqG0zjpw+XNl4rO3SYqY5Qg+yVcvWaH3VqhRKX8HMEwn3MccW QKF9e5YsexMiFWwOkA2M5tLdTKeFJZ0hd1m3sOVsIleV+hCLKcsEZ3XGuUzAmexGfOno c67+FTIsvlRMdXl+YjhhgdEDaTEXX+JQUyChNzaG8zVH+DJs9C8wyBgF0MtQ0ehGM+c6 G3uw== X-Gm-Message-State: AOAM530NFn2bSdapH4ZeyHWPAS8GkrU/Fqu5zy3Sxdr7wwa7bbBN6mUS h5Qa1jC9AD3cKz17ow2cLhDhuGxwXQlaeURn X-Google-Smtp-Source: ABdhPJy6/NAHDK+8w4iNchj26nRjUFR3PAUM7rxpvGeFz6Ac+BMLgft2VkxBls2GAb+q1T+BKfSpfA== X-Received: by 2002:a19:5f5e:: with SMTP id a30mr8516116lfj.64.1600320665219; Wed, 16 Sep 2020 22:31:05 -0700 (PDT) Received: from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl. [193.106.246.138]) by smtp.gmail.com with ESMTPSA id j3sm5033686lfb.185.2020.09.16.22.31.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 22:31:04 -0700 (PDT) From: Michal Krawczyk To: dev@dpdk.org Cc: gtzalik@amazon.com, igorch@amazon.com, Michal Krawczyk , Marcin Wojtas , Evgeny Schemeilin Date: Thu, 17 Sep 2020 07:30:27 +0200 Message-Id: <20200917053035.1889989-13-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200917053035.1889989-1-mk@semihalf.com> References: <20200917053035.1889989-1-mk@semihalf.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 12/20] net/ena/base: minor style adjustments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" * Function argument style improvement (space after *) * Align indentation of the define * Typo fix in the documentation * Remove extra empty line after license (aligned with other files) * Extra alignment of one line was fixed Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_com.c | 4 ++-- drivers/net/ena/base/ena_com.h | 4 ++-- drivers/net/ena/base/ena_defs/ena_eth_io_defs.h | 3 +-- drivers/net/ena/base/ena_defs/ena_gen_info.h | 1 - drivers/net/ena/base/ena_defs/ena_regs_defs.h | 3 +-- drivers/net/ena/base/ena_eth_com.c | 4 ++-- 6 files changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c index 9764bd2f48..f2668f79c7 100644 --- a/drivers/net/ena/base/ena_com.c +++ b/drivers/net/ena/base/ena_com.c @@ -1701,7 +1701,7 @@ void ena_com_set_admin_polling_mode(struct ena_com_dev *ena_dev, bool polling) ena_dev->admin_queue.polling = polling; } -bool ena_com_get_admin_polling_mode(struct ena_com_dev * ena_dev) +bool ena_com_get_admin_polling_mode(struct ena_com_dev *ena_dev) { return ena_dev->admin_queue.polling; } @@ -2958,8 +2958,8 @@ int ena_com_config_dev_mode(struct ena_com_dev *ena_dev, struct ena_admin_feature_llq_desc *llq_features, struct ena_llq_configurations *llq_default_cfg) { + struct ena_com_llq_info *llq_info = &ena_dev->llq_info; int rc; - struct ena_com_llq_info *llq_info = &(ena_dev->llq_info);; if (!llq_features->max_llq_num) { ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST; diff --git a/drivers/net/ena/base/ena_com.h b/drivers/net/ena/base/ena_com.h index ba367b4ca0..f507aa47ed 100644 --- a/drivers/net/ena/base/ena_com.h +++ b/drivers/net/ena/base/ena_com.h @@ -31,7 +31,7 @@ #define ENA_INTR_INITIAL_RX_INTERVAL_USECS 0 #define ENA_DEFAULT_INTR_DELAY_RESOLUTION 1 -#define ENA_HASH_KEY_SIZE 40 +#define ENA_HASH_KEY_SIZE 40 #define ENA_HW_HINTS_NO_TIMEOUT 0xFFFF @@ -744,7 +744,7 @@ int ena_com_set_hash_ctrl(struct ena_com_dev *ena_dev); * * Retrieve the hash control from the device. * - * @note: If the caller called ena_com_fill_hash_ctrl but didn't flash + * @note: If the caller called ena_com_fill_hash_ctrl but didn't flush * it to the device, the new configuration will be lost. * * @return: 0 on Success and negative value otherwise. diff --git a/drivers/net/ena/base/ena_defs/ena_eth_io_defs.h b/drivers/net/ena/base/ena_defs/ena_eth_io_defs.h index 108bed8520..2b934fff08 100644 --- a/drivers/net/ena/base/ena_defs/ena_eth_io_defs.h +++ b/drivers/net/ena/base/ena_defs/ena_eth_io_defs.h @@ -1,8 +1,7 @@ /* SPDX-License-Identifier: BSD-3-Clause - * Copyright (c) 2015-2019 Amazon.com, Inc. or its affiliates. + * Copyright (c) 2015-2020 Amazon.com, Inc. or its affiliates. * All rights reserved. */ - #ifndef _ENA_ETH_IO_H_ #define _ENA_ETH_IO_H_ diff --git a/drivers/net/ena/base/ena_defs/ena_gen_info.h b/drivers/net/ena/base/ena_defs/ena_gen_info.h index f486e9fe6e..8f55504bc5 100644 --- a/drivers/net/ena/base/ena_defs/ena_gen_info.h +++ b/drivers/net/ena/base/ena_defs/ena_gen_info.h @@ -2,6 +2,5 @@ * Copyright (c) 2015-2020 Amazon.com, Inc. or its affiliates. * All rights reserved. */ - #define ENA_GEN_DATE "Wed Sep 25 11:32:57 UTC 2019" #define ENA_GEN_COMMIT "952697a9e0d3" diff --git a/drivers/net/ena/base/ena_defs/ena_regs_defs.h b/drivers/net/ena/base/ena_defs/ena_regs_defs.h index 2d6bf5486e..639cd98c0a 100644 --- a/drivers/net/ena/base/ena_defs/ena_regs_defs.h +++ b/drivers/net/ena/base/ena_defs/ena_regs_defs.h @@ -1,8 +1,7 @@ /* SPDX-License-Identifier: BSD-3-Clause - * Copyright (c) 2015-2019 Amazon.com, Inc. or its affiliates. + * Copyright (c) 2015-2020 Amazon.com, Inc. or its affiliates. * All rights reserved. */ - #ifndef _ENA_REGS_H_ #define _ENA_REGS_H_ diff --git a/drivers/net/ena/base/ena_eth_com.c b/drivers/net/ena/base/ena_eth_com.c index 80d35556cb..9c4e6133f5 100644 --- a/drivers/net/ena/base/ena_eth_com.c +++ b/drivers/net/ena/base/ena_eth_com.c @@ -188,8 +188,8 @@ static int ena_com_sq_update_llq_tail(struct ena_com_io_sq *io_sq) pkt_ctrl->curr_bounce_buf = ena_com_get_next_bounce_buffer(&io_sq->bounce_buf_ctrl); - memset(io_sq->llq_buf_ctrl.curr_bounce_buf, - 0x0, llq_info->desc_list_entry_size); + memset(io_sq->llq_buf_ctrl.curr_bounce_buf, + 0x0, llq_info->desc_list_entry_size); pkt_ctrl->idx = 0; if (unlikely(llq_info->desc_stride_ctrl == ENA_ADMIN_SINGLE_DESC_PER_ENTRY))