From patchwork Sun Sep 6 01:31:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 76623 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16DD7A04C5; Sun, 6 Sep 2020 03:33:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DA7A31C190; Sun, 6 Sep 2020 03:31:57 +0200 (CEST) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by dpdk.org (Postfix) with ESMTP id 9B3171C129 for ; Sun, 6 Sep 2020 03:31:53 +0200 (CEST) Received: by mail-pg1-f170.google.com with SMTP id u13so6306195pgh.1 for ; Sat, 05 Sep 2020 18:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fKkIOINUQ2FC8wT3qqw/AlsKkaC+NNbLh/FZX952GRc=; b=QtHic2I8YnPEKrXGk+KAMd7eYEPpgBhmd9HHleVCrzeC8J7rlhvJnxq8JG9voo1VBU dOGX/eBAtEzWYcuE1EcnP9K+obxq5dztlX6LKIPLaHnz7WVzIvPYCUERFKEwMGALindY vX6GVs7DbpdiFNCoJ+ZMSbOb6xguN4SUVnREyqmYZKl+G8Oh6iE5NSbpSY6N8ZQCnT2T lT4OwWGtEznbhcCYY55wtZDy9drYyNDX1AQr9whXQv+aakB3sZpu2QhXl0kYe+r/HF+A rOVlm839TephFKWexSfKjvvzvuCIStnRp8fSag3BgItPs/DWgDNOhBoOfoUUTCPZVxhh ufrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fKkIOINUQ2FC8wT3qqw/AlsKkaC+NNbLh/FZX952GRc=; b=XcayyIqa8yzw4sNoDkCVUJsN3TTy7aqLszh/Q8CcvCR0BDKUN+nkPlGJYki8iCKXoV gDZnNxy9zu8MUWNmFUFB9i47fTy6vSJbWAVqxwr0M9QVeyjdTDiYIqL8ePzFg/1d2vli oxL71zZqw/E8tRpgzEI+BI7GygjKl4Jt0zwelZ7fxJ7Vht8H/2pq9XQgKTbl1cSiKm23 MoCgalkjLJd0X0KImTvQr/EtJclYsOYMDOCkeau2ImmkMd12vmafh1gdbDmJzw1vKTOA rFBJ75GqwYETGqag5yFKIXunuefEzqWgLI7QeOf8RBIM1nXuR/1wOaXd/vDglooPs694 9lAA== X-Gm-Message-State: AOAM532xlFc8ZzQ8KXGciImbbvyRUiIjHClcsR7SyM9+eHl1Ic8lk2uI hogqRs5PHM/h0a/AmKu4SqvzCCOf5hTxLg== X-Google-Smtp-Source: ABdhPJzJ8W6xmCGcLERqx2k4Q4X6NOyvNWivpI7D2uvcHihZ1Lp93DLDBoApNthvmlwbG/dUsXhNkA== X-Received: by 2002:aa7:84d5:0:b029:13c:1611:653a with SMTP id x21-20020aa784d50000b029013c1611653amr13128355pfn.12.1599355912270; Sat, 05 Sep 2020 18:31:52 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id n127sm10731863pfn.155.2020.09.05.18.31.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Sep 2020 18:31:51 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Sat, 5 Sep 2020 18:31:32 -0700 Message-Id: <20200906013133.26360-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200906013133.26360-1-stephen@networkplumber.org> References: <20200906013133.26360-1-stephen@networkplumber.org> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 10/11] dpdk-telemetry-client: fix some pylint warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Convert comments to docstrings as appropriate. Remove unnecessary paren in if statement. Remove extra whitespace after print. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- usertools/dpdk-telemetry-client.py | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py index fa599046a46b..7a22d1b99864 100755 --- a/usertools/dpdk-telemetry-client.py +++ b/usertools/dpdk-telemetry-client.py @@ -32,7 +32,8 @@ def __del__(self): class Client: - def __init__(self): # Creates a client instance + def __init__(self): + ''' Creates a client instance ''' self.socket = Socket() self.file_path = None self.choice = None @@ -45,16 +46,18 @@ def __del__(self): except: print("Error - Client could not be destroyed") - def getFilepath(self, file_path): # Gets arguments from Command-Line and assigns to instance of client + def getFilepath(self, file_path): + '''Gets arguments from Command-Line and assigns to instance of client''' self.file_path = file_path - def register(self): # Connects a client to DPDK-instance + def register(self): + '''Connects a client to DPDK-instance''' if os.path.exists(self.file_path): os.unlink(self.file_path) try: self.socket.recv_fd.bind(self.file_path) except socket.error as msg: - print ("Error - Socket binding error: " + str(msg) + "\n") + print("Error - Socket binding error: " + str(msg) + "\n") self.socket.recv_fd.settimeout(2) self.socket.send_fd.connect("/var/run/dpdk/rte/telemetry") JSON = (API_REG + self.file_path + "\"}}") @@ -63,16 +66,19 @@ def register(self): # Connects a client to DPDK-instance self.socket.recv_fd.listen(1) self.socket.client_fd = self.socket.recv_fd.accept()[0] - def unregister(self): # Unregister a given client + def unregister(self): + ''' Unregister a given client ''' self.socket.client_fd.send((API_UNREG + self.file_path + "\"}}").encode()) self.socket.client_fd.close() - def requestMetrics(self): # Requests metrics for given client + def requestMetrics(self): + ''' Requests metrics for given client ''' self.socket.client_fd.send(METRICS_REQ.encode()) data = self.socket.client_fd.recv(BUFFER_SIZE).decode() print("\nResponse: \n", data) - def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client + def repeatedlyRequestMetrics(self, sleep_time): + ''' Recursively requests metrics for given client ''' print("\nPlease enter the number of times you'd like to continuously request Metrics:") n_requests = int(input("\n:")) print("\033[F") #Removes the user input from screen, cleans it up @@ -81,12 +87,14 @@ def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics f self.requestMetrics() time.sleep(sleep_time) - def requestGlobalMetrics(self): #Requests global metrics for given client + def requestGlobalMetrics(self): + ''' Requests global metrics for given client ''' self.socket.client_fd.send(GLOBAL_METRICS_REQ.encode()) data = self.socket.client_fd.recv(BUFFER_SIZE).decode() print("\nResponse: \n", data) - def interactiveMenu(self, sleep_time): # Creates Interactive menu within the script + def interactiveMenu(self, sleep_time): + ''' Creates Interactive menu within the script ''' while self.choice != 4: print("\nOptions Menu") print("[1] Send for Metrics for all ports") @@ -116,7 +124,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr sleep_time = 1 file_path = "" - if (len(sys.argv) == 2): + if len(sys.argv) == 2: file_path = sys.argv[1] else: print("Warning - No filepath passed, using default (" + DEFAULT_FP + ").")